Skip to content

Run the plugin unit test suite #245

Description

@somethingwithproof

The repository has 23 test files and 119 tests that no workflow ever ran, so a
failing prepared-statement check and two tests that asserted nothing had gone
unnoticed on develop.

  • adds a unit-test job across PHP 8.1-8.4 that installs the plugin's own
    composer dependencies and runs lint plus the suite
  • moves the toolchain to Pest 2; Pest 1 is not PHP 8.4-clean, which the old
    phpunit.xml worked around by muting E_DEPRECATED
  • narrows the prepared-statement check to raw db calls that actually build SQL
    from a variable, so the fully static query in cli/cacti-mapper.php no
    longer fails it
  • makes the two XSS handoff tests assert on a collected list, so the
    expectation still runs when nothing matches

Tracking issue for #243, which carries the fix.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions