Skip to content

Fix rendering of UP face for waterlogged blocks with translucent sides #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Auth0x78 wants to merge 4 commits into
base: dev
Choose a base branch
from
+9 −3
Open

Fix rendering of UP face for waterlogged blocks with translucent sides #3775

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e8788f
Fix issue where UP face of water in waterlogged block with translucen…
Auth0x78 Jun 26, 2026
d565857
Remove redundant height info by improving the fluid VoxelShape
Auth0x78 Jun 26, 2026
8c24f80
Merge branch 'dev' into fix-culled-fluid-up-face
Auth0x78 Jun 27, 2026
90b65be
Replace manual voxel shape construction with fluid.getShape()
Auth0x78 Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions ...net/caffeinemc/mods/sodium/client/render/chunk/compile/pipeline/DefaultFluidRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ private boolean isFluidSelfVisible(BlockState selfBlockState, Direction facing,
// only a non-empty self-shape can occlude anything
if (!ShapeComparisonCache.isEmptyShape(selfShape)) {
// a full self-shape occludes everything
if (ShapeComparisonCache.isFullShape(selfShape) && ShapeComparisonCache.isFullShape(fluidShape)) {
return false;
if (ShapeComparisonCache.isFullShape(selfShape)) {
return !ShapeComparisonCache.isFullShape(fluidShape);
Comment thread
Auth0x78 marked this conversation as resolved.
}

// perform occlusion of the fluid by the block it's contained in
Expand All @@ -168,7 +168,12 @@ private boolean isFluidSelfVisible(BlockState selfBlockState, Direction facing,
return true;
}

private boolean isFullBlockFluidSelfVisible(BlockState blockState, Direction dir, VoxelShape fluidShape) {
return this.isFluidSelfVisible(blockState, dir, fluidShape);
}

private boolean isFullBlockFluidSelfVisible(BlockState blockState, Direction dir) {
// Assume that is the fluid block is a full sized block
return this.isFluidSelfVisible(blockState, dir, Shapes.block());
}

Expand Down Expand Up @@ -232,7 +237,8 @@ private boolean isSideExposedOffset(BlockAndTintGetter world, BlockState ownBloc
* Calculates the combined visibility of a fluid face based on the neighboring block states and the fluid state.
*/
private boolean isFullBlockFluidVisible(BlockAndTintGetter world, BlockPos pos, Direction dir, BlockState blockState, FluidState fluid) {
return this.isFullBlockFluidSelfVisible(blockState, dir) && this.isFullBlockFluidSideVisible(world, pos, dir, fluid);
VoxelShape fluidShape = fluid.getShape(world, pos);
return isFullBlockFluidSelfVisible(blockState, dir, fluidShape) && this.isFullBlockFluidSideVisible(world, pos, dir, fluid);
}

/**
Expand Down