Fix OpenGL performance regression on some systems since 26.2 - #3890
Open
kupa22 wants to merge 2 commits into
Open
Fix OpenGL performance regression on some systems since 26.2#3890kupa22 wants to merge 2 commits into
kupa22 wants to merge 2 commits into
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Contributor
|
We've merged some related code recently. Is the performance problem fixed on the current |
Author
I've just tested - makes no difference in my case (i.e. problem is not fixed). |
|
not fixed bro
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
26.2 seems to have introduced a major OpenGL performance regression, which halves the framerate on some systems in almost all situations (at least on Apple Silicon devices).
Could reproduce on an M1 Max system in a newly created flat world (~230 FPS without the fix, ~580 FPS with the fix).
Problem is present since 26.2 pre-release 1 (since this version, a GL fence sync seems to be created unconditionally for each frame).
This PR contains a small mixin to work around this, which fixed the problem in my case (and hopefully also for others).
Since I don't have much experience with OpenGL or rendering, I'm not sure if this could have unintended side effects, but I haven't encountered any issues in my testing.
Would be great to have this tested on different systems and hardware configurations to see whether the issue is specific to my setup or affects other systems as well.