fix(resources): disable unsafe citizen workspace eviction - #3921
Merged
joelteply merged 1 commit intoSep 8, 2026
Conversation
joelteply
enabled auto-merge (squash)
September 8, 2026 19:42
joelteply
deleted the
af44428c/disable-unsafe-citizen-workspace-evictio
branch
September 8, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The citizen workspace pool added in #3920 can delete the only copy of clean, unpushed Persona autosaves: preservation checks git status, skips clean repositories, and does not preserve local commit objects or refs. Its synchronous snapshot also recursively scans citizen trees during broker status reads.
Remove the pool's production registration until preservation and accounting are repaired. The generic disk-pressure monitor only reports pressure; it cannot delete files. Existing pool implementation and its repair work remain available; this change stops the broker from invoking it.
Validation: independent source review audited all CitizenWorkspacePool references and the non-deleting generic disk-pressure monitor; the removed registration was its only production construction. Diff checks pass. This containment does not claim to repair archival or recover already-deleted data. No live processes were changed.
AIRC card af44428c-fda2-4405-878a-dbaa85af311a. Blocking review: #3920 (comment)