Repository navigation
Add an English / Chinese interface (V3 Milestone 4) - #21
Merged
Merged
Conversation
- moves.name_zh / name_zh_source ('wiki' | 'translation') /
name_zh_source_url, with check constraints added by hand to the
reviewed migration (autogenerate misses them)
- seed validation requires a Chinese name for every move; 102 existing
moves named: 6 from BWIKI combat-art pages, 96 translations
- API returns the Chinese names; interim frontend display to be replaced
by the language switch
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- language switch in the nav bar; saved on the account (users.preferred_language, PATCH /api/auth/me) or in the browser for visitors, defaulting to the browser language - every interface string in both languages via a small in-house dictionary and t(); each language shows only its own text - Chinese boss content for the 8 existing bosses: locations, phase names, and all 234 move text fields, translated from the sourced English; the seed requires a Chinese version for every English field - Chinese moveset shows one note about translations; wiki-sourced names link to their page - reviewed migration with a hand-added check constraint Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Each move option carries its description as a hover tooltip, and the chosen move's description is shown under the select (phones have no hover). Both follow the interface language. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The review file is committed temporarily so the review can continue on another machine; it must be deleted before the pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # CLAUDE.md
- Owl (Father)'s Shadowfall becomes the translation 巨型忍者落杀 rather than the combat art 秘传·巨型忍者落杀, since no authoritative source ties the two together; descriptions that mention it follow - Corrupted Monk (Mibu Village) is 破戒僧; True Corrupted Monk stays 宫内破戒僧 - regenerate the review file with these marked as decided Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Chinese content review is done, so the temporary review file is removed and the bilingual interface is recorded as delivered in CLAUDE.md, ROADMAP and both READMEs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
users.preferred_language,PATCH /api/auth/me); visitors keep it in the browser, and the first visit follows the browser language.frontend/src/i18n/messages.ts. The Chinese table must have the same keys as the English one, which the TypeScript type enforces. Each language shows only its own text.wikiis used only when the full name appears on a Chinese wiki page, and a database constraint requires the page URL. Everything else is markedtranslation. 5 names come from BWIKI combat-art pages; the rest are translations.Data rules
Migrations
Two reviewed migrations that only add columns:
Autogenerate missed every check constraint, so they were added by hand. Existing rows get NULLs, and the next seed sync fills them in.
Testing
🤖 Generated with Claude Code