Skip to content

Release V3.0.0: Multi-User Product Foundation - #22

Merged
CanYouTeachMeHowToCode merged 24 commits into
mainfrom
dev
Oct 5, 2026
Merged

Release V3.0.0: Multi-User Product Foundation#22
CanYouTeachMeHowToCode merged 24 commits into
mainfrom
dev

Conversation

@CanYouTeachMeHowToCode

@CanYouTeachMeHowToCode CanYouTeachMeHowToCode commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Merges V3 from dev into main for the v3.0.0 release.

What's in V3

  • Accounts: registration, login, logout; argon2 password hashing; server-side sessions in an httpOnly cookie
  • User-owned attempts and per-user analytics, with isolation tests at the API and service level; attempts recorded before accounts existed are kept and can be claimed
  • English / 中文 interface, saved on the account or in the browser for visitors
  • Existing boss content checked against Fextralife and Fandom: errors and phase structures fixed, Genichiro (Way of Tomoe) added to the Isshin fight, move-level sources
  • A cross-wiki move mapping for every boss in research/ground_truth/ as the starting point for V4
  • CI also checks that data survives a Docker restart

Upgrading a local install

docker compose up -d --build applies the new migrations. Existing Isshin attempts move up one phase, because the fight now starts with Genichiro. After registering, claim older attempts with docker compose exec backend python -m scripts.claim_attempts <username>.

🤖 Generated with Claude Code

CanYouTeachMeHowToCode and others added 24 commits September 22, 2026 23:23
@CanYouTeachMeHowToCode @claude
Plan V3: accounts, public deployment and practice recommendations
95b69e4 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Add accounts and authentication (V3 Milestone 1)
8cd1217 
- users and user_sessions tables (reviewed Alembic migration)
- argon2 password hashing; server-side sessions in an httpOnly,
  SameSite=Lax cookie, stored only as a SHA-256 hash
- register / login / logout / me endpoints; attempts and analytics
  now require login, boss data stays public
- frontend: nav bar, login and register pages with a show-password
  toggle, welcome page with the boss list for visitors, login prompt
  on boss pages
- tests for auth, access control, the auth UI, and the integration
  workflow; CI smoke test logs in through nginx

Attempts are still shared by all logged-in users until Milestones 2-3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode
Merge pull request #19 from CanYouTeachMeHowToCode/feature/accounts
e969122 
Add accounts and authentication (V3 Milestone 1)
@CanYouTeachMeHowToCode @claude
Give attempts an owner and scope analytics per user (V3 Milestones 2-3)
6018b24 
- attempts.user_id (nullable FK) plus a (user_id, boss_id) index, in a
  reviewed migration that keeps existing attempts as ownerless
- every attempt read and write, boss analytics, progression and the
  Sekiro dashboard queries are scoped to the logged-in user
- ownerless pre-account attempts are hidden from everyone until
  `python -m scripts.claim_attempts <username>` assigns them
- isolation tests at API and service level, claim script tests, a
  migration test on a database with existing attempts, and a second
  user in the integration workflow
- README: how to claim V1/V2 attempts after upgrading; CLAUDE.md: make
  user_id NOT NULL in Milestone 4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode
Merge pull request #20 from CanYouTeachMeHowToCode/feature/user-attempts
76d1865 
Give attempts an owner and scope analytics per user (V3 Milestones 2-3)
@CanYouTeachMeHowToCode @claude
Record V3 Milestones 1-3 as completed in CLAUDE.md and ROADMAP
843841f 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Plan V3 content completion before public deployment
c04234a 
Insert Milestone 4 (all main bosses, Chinese move names from a Chinese
wiki or marked as translations) before public deployment, which becomes
Milestone 5. Move video references are a deferred Milestone 8.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Plan V3 bilingual interface and moveset review
f8deb6e 
Milestone 4 becomes the English/Chinese interface (language saved in the
account, or the browser for visitors; each language shows only its own
text). Milestone 5 is content completion plus a review of existing
movesets. Deployment, recommendations, release and video references move
to Milestones 6-9.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Store Chinese move names with their source (V3 Milestone 4, part 1)
fb8af26 
- moves.name_zh / name_zh_source ('wiki' | 'translation') /
  name_zh_source_url, with check constraints added by hand to the
  reviewed migration (autogenerate misses them)
- seed validation requires a Chinese name for every move; 102 existing
  moves named: 6 from BWIKI combat-art pages, 96 translations
- API returns the Chinese names; interim frontend display to be replaced
  by the language switch

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode
Merge remote-tracking branch 'origin/dev' into feature/bilingual
4391467
@CanYouTeachMeHowToCode @claude
Add an English/Chinese interface (V3 Milestone 4, part 2)
bdd6d55 
- language switch in the nav bar; saved on the account
  (users.preferred_language, PATCH /api/auth/me) or in the browser for
  visitors, defaulting to the browser language
- every interface string in both languages via a small in-house
  dictionary and t(); each language shows only its own text
- Chinese boss content for the 8 existing bosses: locations, phase names,
  and all 234 move text fields, translated from the sourced English;
  the seed requires a Chinese version for every English field
- Chinese moveset shows one note about translations; wiki-sourced names
  link to their page
- reviewed migration with a hand-added check constraint

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Describe moves while choosing what ended an attempt
5e343c5 
Each move option carries its description as a hover tooltip, and the
chosen move's description is shown under the select (phones have no
hover). Both follow the interface language.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Record Milestone 4 progress and add the Chinese content review file
0eff37a 
The review file is committed temporarily so the review can continue on
another machine; it must be deleted before the pull request.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Re-scope the roadmap around combat ground truth
e895f8d 
V3 becomes the multi-user product foundation (bilingual interface,
existing-content cleanup, release). V4 adds combat ground truth from
runtime and engine evidence, plus public deployment; V5 is gameplay
video analysis and practice recommendations; V6 is multi-game.

- READMEs: add the V3 status section, replace the roadmap overview with
  V1-V6, and update the public deployment note and tech stack
- CLAUDE.md / ROADMAP: make attempts.user_id NOT NULL before V4 public
  deployment; fill telegraph / common_mistakes only when the source
  states them

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode
Merge remote-tracking branch 'origin/dev' into feature/bilingual
bcf1a51 
# Conflicts:
#	CLAUDE.md
@CanYouTeachMeHowToCode @claude
Settle two Chinese naming decisions
6fd960b 
- Owl (Father)'s Shadowfall becomes the translation 巨型忍者落杀 rather
  than the combat art 秘传·巨型忍者落杀, since no authoritative source
  ties the two together; descriptions that mention it follow
- Corrupted Monk (Mibu Village) is 破戒僧; True Corrupted Monk stays
  宫内破戒僧
- regenerate the review file with these marked as decided

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Mark V3 Milestone 4 completed and remove the review file
4f17423 
The Chinese content review is done, so the temporary review file is
removed and the bilingual interface is recorded as delivered in
CLAUDE.md, ROADMAP and both READMEs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode
Merge pull request #21 from CanYouTeachMeHowToCode/feature/bilingual
425a046 
Add an English / Chinese interface (V3 Milestone 4)
@CanYouTeachMeHowToCode @claude
Add a Chinese ROADMAP
5ed730e 
ROADMAP.zh-CN.md mirrors ROADMAP.md section by section, using the same
Chinese terms as the app and README. The English and Chinese roadmaps
link to each other, and the Chinese README links to the Chinese roadmap.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Clean up existing boss content, part 1 (V3 Milestone 5)
fbd19ab 
From the two-wiki review (Fextralife and Fandom):
- True Corrupted Monk: phase 2 keeps every phase-1 move alongside the
  illusion summoning; the illusion text no longer gives a shadow count
  or the misleading Bite Down tip, and adds the tree aerial-Deathblow
- Guardian Ape: add the phase-2 Jumping Sweep from the Fextralife
  attack table; the rolling body slam can be blocked
- Owl (Father): Shadowfall is the Mushin combat art 秘传·巨型忍者落杀
  (both wikis say so); the firecracker dodge mistake moves to the
  5-slash firecracker combo where the source puts it
- Isshin: deflecting Ichimonji Double leads into a force-wave follow-up

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Clean up existing boss content, part 2 (V3 Milestone 5)
1bc5564 
- Isshin: the fight now starts with a Genichiro, Way of Tomoe phase
  holding only the moves both wikis agree on (his lightning is left out:
  the wikis conflict). A data migration moves existing Isshin attempts
  up one phase.
- Optional move-level source fields (source_name / source_url, set
  together or not at all), used for moves taken from another page; the
  moveset shows them under the move.
- Both Owls gain Mikiri Counter (Fandom).
- Remove actions that cannot end an attempt: Owl's zig-zag, Guardian
  Ape's roar, Lady Butterfly's rafter jump, Great Shinobi Owl's charm.
- Guardian Ape's diving lunge loses its inferred telegraph; Isshin's
  phase-3 distance slash is no longer called a lightning variant.
- Consistent move types: backflips are combos, lightning attacks are
  lightning, deflectable moves are not marked unblockable.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Add the cross-wiki move mapping for every boss
e05296c 
research/ground_truth/semantic/wiki_mapping/ lines up each product move
with the Fextralife and Fandom entries that describe it and records how
they relate. Across 106 product moves, 52 match one-to-one between the
two wikis. scripts/wiki_mapping_report.py rebuilds the readable report
and checks that every product move is mapped exactly once.

CLAUDE.md and both ROADMAPs now state that the project owner decides
what counts as ground truth, and document move-level sources.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Check in CI that data survives a Docker restart
ca747ea 
The docker job now records an attempt, stops the stack without removing
volumes, starts it again, logs in with the same account and checks the
attempt is still there. This covers the last step of the V3 success
criteria, which nothing tested before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode @claude
Mark V3 completed in CLAUDE.md, ROADMAP and README
4dfcebc 
Milestones 5 and 6 are done: Lady Butterfly and Guardian Ape keep their
current move lists (the Fandom detail stays in the mapping for V4), and
CI now checks that data survives a Docker restart. CLAUDE.md's current
focus moves to V4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@CanYouTeachMeHowToCode
CanYouTeachMeHowToCode merged commit 58ff30c into main Oct 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@CanYouTeachMeHowToCode