Repository navigation
fix: resolve high-severity dependabot security alerts - #2198
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughBumps several indirect Go dependencies in Changes
Sequence Diagram(s)(omitted — changes are dependency/configuration updates without new multi-component runtime control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
wren-ui/package.json (1)
97-114: Post-merge validation: run the full test/build matrix to ensure the security updates don't break functionality.The resolved versions are correctly pinned in
yarn.lock(all 16 packages match their resolutions), but the security changes need functional validation. Lodash is extensively used across the codebase, and BigQuery/DuckDB data flows exist insrc/apollo/server/adaptorsandsrc/apollo/server/dataSource.tsthat depend on the updated packages.Recommended before merge completion:
- Run
yarn testandyarn buildto validate the security update doesn't break existing functionality- Smoke-test data-source flows (BigQuery/DuckDB/GCS) to ensure cloud SDK chains work with the updated dependencies
- If feasible, run
yarn test:e2eto catch any integration issues in end-to-end scenarios🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@wren-ui/package.json` around lines 97 - 114, Run the full post-merge validation: execute yarn test and yarn build, then smoke-test the BigQuery/DuckDB/GCS data flows implemented in src/apollo/server/adaptors and src/apollo/server/dataSource.ts (exercise the BigQuery and DuckDB adapters and any methods that fetch/stream data) and, if available, run yarn test:e2e to catch integration issues; report any failing tests or runtime errors and roll back or pin the specific dependency causing breakage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/wren-launcher-ci.yaml:
- Line 29: Update the GitHub Actions release workflow to use Go 1.25.x by
changing the setup-go step in create-rc-release.yaml: locate the step that uses
actions/setup-go@v4 and set the with.go-version value to "1.25" (replace the
current "1.23.0"), ensuring the release build matches wren-launcher/go.mod's
requirement for go >= 1.25.0.
In `@wren-launcher/go.mod`:
- Around line 146-151: The go.mod currently mixes OpenTelemetry SDK v1.43.0 with
OTLP exporters at v1.35.0 which is incompatible; update the versions so they
match by either downgrading go.opentelemetry.io/otel/sdk/metric (and any otel
core/modules) to v1.35.0 or upgrading all exporters and contrib instrumentation
to v1.43.0 — specifically adjust the module versions for
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc,
go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp,
go.opentelemetry.io/otel/exporters/otlp/otlptrace,
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc, add/align
otlptracehttp if present, and the contrib modules
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc and
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp so all otel
packages use the same coordinated version.
In `@wren-ui/package.json`:
- Line 109: Update the lodash dependency in package.json from "4.18.0" to
"4.18.1": open package.json, locate the "lodash" entry (currently "4.18.0") and
change the version string to "4.18.1", then run your package manager
(npm/yarn/pnpm) to reinstall/update lockfile so the project uses the fixed
lodash 4.18.1 release.
- Line 108: The resolutions entry forcing "fast-xml-parser": "5.5.6" causes a
breaking major upgrade for transitive consumers like `@google-cloud/storage` which
expects v4; change the resolutions value in package.json to pin fast-xml-parser
to a v4 security-patched release (e.g., "4.5.5" or latest 4.5.x) so the GHSA fix
is applied without crossing the major-version boundary; update the package.json
"resolutions" key for fast-xml-parser and run install/lockfile refresh to ensure
the v4 patch is used by the lockfile.
---
Nitpick comments:
In `@wren-ui/package.json`:
- Around line 97-114: Run the full post-merge validation: execute yarn test and
yarn build, then smoke-test the BigQuery/DuckDB/GCS data flows implemented in
src/apollo/server/adaptors and src/apollo/server/dataSource.ts (exercise the
BigQuery and DuckDB adapters and any methods that fetch/stream data) and, if
available, run yarn test:e2e to catch integration issues; report any failing
tests or runtime errors and roll back or pin the specific dependency causing
breakage.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5f72bb24-c95c-4eca-ae29-5ab2f1866ac0
⛔ Files ignored due to path filters (2)
wren-launcher/go.sumis excluded by!**/*.sumwren-ui/yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (3)
.github/workflows/wren-launcher-ci.yamlwren-launcher/go.modwren-ui/package.json
wren-ui: upgrade node-forge, lodash, fast-xml-parser, flatted, tar, immutable, picomatch via yarn resolutions wren-launcher: upgrade moby/spdystream v0.5.0 → v0.5.1, otel/sdk v1.39.0 → v1.43.0 via go mod Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6f88683 to
f933e43
Compare
- fast-xml-parser: use 4.5.5 instead of 5.5.6 (v4 has the security patch, avoids breaking major version change for @google-cloud/storage) - lodash: use 4.18.1 instead of 4.18.0 (fixes ReferenceError bug in 4.18.0) - create-rc-release.yaml: bump Go version 1.23.0 → 1.25 to match go.mod Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
…ompatibility vega-lite v6 uses package.json "exports" for type declarations, which the legacy "node" moduleResolution cannot resolve. Switching to "bundler" is the correct strategy for Next.js apps and fixes TS2307 errors. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Note: wren-launcher CI failure is pre-existing on
|
Summary
node-forge1.3.2 -> 1.4.0 (Dependabot alerts 274-277)lodash4.17.23 -> 4.18.0 (Dependabot alert 280)fast-xml-parser4.5.4 -> 5.5.6 (Dependabot alert 245)flatted3.3.1 -> 3.4.2 (Dependabot alerts 231, 239)tar7.5.7 -> 7.5.11 (Dependabot alerts 221, 223)immutable3.7.6 -> 3.8.3 (Dependabot alert 222)picomatch2.3.1 -> 2.3.2 (Dependabot alert from transitive deps)github.com/moby/spdystreamv0.5.0 -> v0.5.1 (Dependabot alert 292)go.opentelemetry.io/otel/sdkv1.36.0 -> v1.43.0 (Dependabot alerts 213, 273)Skipped:
next(requires major version upgrade 14 -> 15),docker/docker(no patch available), everything inwren-ai-service/.Test plan
wren-uibuilds successfully (yarn build)wren-launcherbuilds successfully (go build ./...)Generated with Claude Code
Summary by CodeRabbit