Skip to content

Prefer card printings in the selected language in Adventure Mode - #11736

Open
Nerdslayer wants to merge 1 commit into
Card-Forge:masterfrom
Nerdslayer:fix/adventure-prefer-english-printings
Open

Prefer card printings in the selected language in Adventure Mode#11736
Nerdslayer wants to merge 1 commit into
Card-Forge:masterfrom
Nerdslayer:fix/adventure-prefer-english-printings

Conversation

@Nerdslayer

Copy link
Copy Markdown

I noticed that in Adventure mode I would sometimes encounter cards that are in Japanese. This is especially an issue since no raw card text is available in this UI so I have no way of knowing what the card does.

To fix this I made it so automatic card selection now prefers printings matching Forge’s selected UI language if available, then English, then any available language. Explicit edition requests remain authoritative.

Adds regression coverage for selected-language preference, English fallback, any-language fallback, and explicit editions. Just let me know if you think the added regression tests are excessive and I can remove them.

Sol assisted in development.

@tool4ever

Copy link
Copy Markdown
Contributor

Seems redundant to #11709, just without logic to really support printings in multiple languages

@Nerdslayer

Copy link
Copy Markdown
Author

@tool4ever Thanks, I didn't know about that PR and there is some overlap. This PR only uses edition-level CardLang, so its multilingual support is incomplete.

The specific problem I was addressing is a foreign-only edition such as PMDA Earthquake being selected automatically while Forge is using English.

I do not believe the other PR will solve this issue because when English is selected:

  • Language-aware unique-card selection is disabled because buildPreferredLanguageAvailability() returns null.
  • The downloader uses each edition’s configured CardLang, rather than forcing "en".
  • Most normal editions already have CardLang=en, so they still download English images.
  • A Japanese-only edition such as PMDA has CardLang=ja, so it remains Japanese.

So #11709 supports choosing non-English languages and downloading multilingual variants, but English is treated as “use the edition default,” not “prefer an English printing.” Even enabling its “prefer language for unique cards” checkbox does not change that, because the predicate is explicitly disabled for English.

This is consistent with #11709’s stated goal of “no behavior change by default,” but it means it does not fix the issue I am trying to address.

If I'm incorrect in how it works and the other PR would result in English card art being preferred when English is selected, I would be happy to just close this PR. Otherwise, perhaps I could add this English preference functionality on top of #11709's new system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants