fix: lowercase the selector option keys for hassfest, keep the stored value

Hassfest rejects translation keys that are not [a-z0-9-_]+, and the protocol
selector used the option values as keys — one of which is XMPP, uppercase
because it comes from bosch_thermostat_client.const.

The selector now emits "xmpp" and the step maps it back to XMPP before storing.
entry.data[CONF_PROTOCOL] keeps the exact value it has always held, so existing
entries still match and no migration is needed. Pinned that invariant with a
test, since it is the kind of thing a future rename would quietly break.

Author: CaseyRo

custom_components/bosch/config_flow.py

@@ -70,7 +70,10 @@ async def async_step_easycontrol_protocol(self, user_input=None):
         """Handle EasyControl protocol choice: XMPP or POINTTAPI."""
         errors = {}
         if user_input is not None:
-            self._protocol = user_input[CONF_PROTOCOL]
+            # The selector's option values are the translation keys, which
+            # hassfest requires to be lowercase — but XMPP is stored uppercase
+            # in entry.data, so map rather than change what is persisted.
+            self._protocol = XMPP if user_input[CONF_PROTOCOL] == "xmpp" else POINTTAPI
             if self._protocol == XMPP:
                 return self._show_xmpp_form(errors)
             # OAuth-first: the authorize URL is device-independent, and the
@@ -82,7 +85,7 @@ async def async_step_easycontrol_protocol(self, user_input=None):
                 {
                     vol.Required(CONF_PROTOCOL): SelectSelector(
                         SelectSelectorConfig(
-                            options=[XMPP, POINTTAPI],
+                            options=["xmpp", POINTTAPI],
                             mode=SelectSelectorMode.LIST,
                             translation_key="protocol",
                         )

custom_components/bosch/strings.json

@@ -519,8 +519,8 @@
   "selector": {
     "protocol": {
       "options": {
-        "XMPP": "Local connection (XMPP)",
-        "pointtapi": "Cloud / Bosch account"
+        "pointtapi": "Cloud / Bosch account",
+        "xmpp": "Local connection (XMPP)"
       }
     }
   }

custom_components/bosch/translations/de.json

@@ -498,8 +498,8 @@
   "selector": {
     "protocol": {
       "options": {
-        "XMPP": "Lokale Verbindung (XMPP)",
-        "pointtapi": "Cloud / Bosch-Konto"
+        "pointtapi": "Cloud / Bosch-Konto",
+        "xmpp": "Lokale Verbindung (XMPP)"
       }
     }
   }

custom_components/bosch/translations/en.json

@@ -519,8 +519,8 @@
   "selector": {
     "protocol": {
       "options": {
-        "XMPP": "Local connection (XMPP)",
-        "pointtapi": "Cloud / Bosch account"
+        "pointtapi": "Cloud / Bosch account",
+        "xmpp": "Local connection (XMPP)"
       }
     }
   }

custom_components/bosch/translations/fr.json

@@ -498,8 +498,8 @@
   "selector": {
     "protocol": {
       "options": {
-        "XMPP": "Connexion locale (XMPP)",
-        "pointtapi": "Cloud / compte Bosch"
+        "pointtapi": "Cloud / compte Bosch",
+        "xmpp": "Connexion locale (XMPP)"
       }
     }
   }

custom_components/bosch/translations/it.json

@@ -498,8 +498,8 @@
   "selector": {
     "protocol": {
       "options": {
-        "XMPP": "Connessione locale (XMPP)",
-        "pointtapi": "Cloud / account Bosch"
+        "pointtapi": "Cloud / account Bosch",
+        "xmpp": "Connessione locale (XMPP)"
       }
     }
   }

custom_components/bosch/translations/nl.json

@@ -498,8 +498,8 @@
   "selector": {
     "protocol": {
       "options": {
-        "XMPP": "Lokale verbinding (XMPP)",
-        "pointtapi": "Cloud / Bosch-account"
+        "pointtapi": "Cloud / Bosch-account",
+        "xmpp": "Lokale verbinding (XMPP)"
       }
     }
   }

custom_components/bosch/translations/pl.json

@@ -498,8 +498,8 @@
   "selector": {
     "protocol": {
       "options": {
-        "XMPP": "Połączenie lokalne (XMPP)",
-        "pointtapi": "Chmura / konto Bosch"
+        "pointtapi": "Chmura / konto Bosch",
+        "xmpp": "Połączenie lokalne (XMPP)"
       }
     }
   }

custom_components/bosch/translations/sk.json

@@ -498,8 +498,8 @@
   "selector": {
     "protocol": {
       "options": {
-        "XMPP": "Lokálne pripojenie (XMPP)",
-        "pointtapi": "Cloud / účet Bosch"
+        "pointtapi": "Cloud / účet Bosch",
+        "xmpp": "Lokálne pripojenie (XMPP)"
       }
     }
   }

unittests/test_config_flow.py

@@ -59,12 +59,23 @@ async def test_xmpp_protocol_shows_xmpp_config(mock_hass):
     flow = _make_flow(mock_hass)
     flow._choose_type = "EASYCONTROL"
     result = await flow.async_step_easycontrol_protocol(
-        {CONF_PROTOCOL: "XMPP"}
+        {CONF_PROTOCOL: "xmpp"}
     )
     assert result["type"] == "form"
     assert result["step_id"] == "xmpp_config"
 
 
+@pytest.mark.asyncio
+async def test_selector_value_is_lowercase_but_stored_protocol_is_not(mock_hass):
+    """hassfest requires lowercase translation keys, so the selector emits
+    "xmpp" — but entry.data has always held "XMPP" and existing entries are
+    matched against it, so the stored value must not change."""
+    flow = _make_flow(mock_hass)
+    flow._choose_type = "EASYCONTROL"
+    await flow.async_step_easycontrol_protocol({CONF_PROTOCOL: "xmpp"})
+    assert flow._protocol == "XMPP"
+
+
 def _prime_tokens(flow):
     """Give a flow OAuth tokens + entry-creation mocks (post-OAuth state)."""
     flow._tokens = {