Remove unused POINTTAPI persistent cache

Author: jfhautenauven

custom_components/bosch/__init__.py

@@ -371,7 +371,6 @@ async def async_init(self) -> bool:
                 self.hass, self.config_entry, self.gateway
             )
             self._data.coordinator = coordinator
-            await coordinator.async_load_persistent_cache()
             device_registry = dr.async_get(self.hass)
             device_registry.async_get_or_create(
                 config_entry_id=self.config_entry.entry_id,

custom_components/bosch/pointtapi_coordinator.py

@@ -16,7 +16,6 @@
 from homeassistant.config_entries import ConfigEntry
 from homeassistant.core import HomeAssistant
 from homeassistant.exceptions import ConfigEntryAuthFailed
-from homeassistant.helpers.storage import Store
 from homeassistant.helpers.update_coordinator import DataUpdateCoordinator, UpdateFailed
 
 from .pointtapi_client import PoinTTAPIClient
@@ -56,9 +55,6 @@
 # Configuration, diagnostics, energy and device inventories change less often
 # than temperatures and operating modes.
 SLOW_RESOURCE_REFRESH_INTERVAL = 5 * 60
-PERSISTENT_CACHE_VERSION = 1
-PERSISTENT_CACHE_MAX_AGE = 7 * 24 * 3600
-PERSISTENT_CACHE_SAVE_DELAY = 60
 SLOW_RESOURCE_PREFIXES = (
     "/gateway",
     "/energy",
@@ -67,28 +63,6 @@
     "/programs",
     "/system/appliance",
 )
-PERSISTENT_CACHE_PREFIXES = (
-    "/solarCircuits",
-    "/system/appliance",
-)
-PERSISTENT_GATEWAY_PATHS = frozenset(
-    {
-        "/gateway/brand",
-        "/gateway/displayType",
-        "/gateway/hmip/versionApplication",
-        "/gateway/hmip/versionOS",
-        "/gateway/productID",
-        "/gateway/productType",
-        "/gateway/update/lastCheck",
-        "/gateway/update/lastUpdate",
-        "/gateway/versionFirmware",
-        "/gateway/versionFirmwareBuild",
-        "/gateway/versionHardware",
-        "/gateway/wifi/versionFirmware",
-        "/gateway/wifi/versionFirmwareBuild",
-        "/gateway/zigbee/versionFirmware",
-    }
-)
 FAST_DEVICE_RESOURCE_MARKERS = (
     "/devices/list",
     "/etrv/",
@@ -110,13 +84,6 @@ def _is_slow_resource(path: str) -> bool:
     return path == "/notifications" or path.startswith(SLOW_RESOURCE_PREFIXES)
 
 
-def _is_persistent_cache_resource(path: str) -> bool:
-    """Return whether a resource is explicitly safe to persist."""
-    return path in PERSISTENT_GATEWAY_PATHS or path.startswith(
-        PERSISTENT_CACHE_PREFIXES
-    )
-
-
 async def _fetch_history_hourly_all(client: PoinTTAPIClient) -> dict[str, Any] | None:
     """Walk /energy/historyHourly pagination forward to collect every entry.
 
@@ -310,48 +277,6 @@ def __init__(
         self._fast_bulk_paths: list[str] = []
         self._slow_data: dict[str, Any] = {}
         self._last_slow_fetch: float = 0.0
-        self._persistent_store = Store(
-            hass, PERSISTENT_CACHE_VERSION, f"bosch.pointtapi.{entry.entry_id}"
-        )
-
-    async def async_load_persistent_cache(self) -> dict[str, Any] | None:
-        """Load the last non-secret resource snapshot for immediate startup state."""
-        try:
-            stored = await self._persistent_store.async_load()
-        except Exception as err:
-            _LOGGER.debug("POINTTAPI persistent cache unavailable: %s", err)
-            return None
-        if not isinstance(stored, dict):
-            return None
-        saved_at = stored.get("saved_at")
-        snapshot = stored.get("data")
-        if (
-            not isinstance(saved_at, (int, float))
-            or time.time() - saved_at > PERSISTENT_CACHE_MAX_AGE
-            or not isinstance(snapshot, dict)
-        ):
-            return None
-        self._slow_data = {
-            path: value
-            for path, value in snapshot.items()
-            if isinstance(path, str) and _is_persistent_cache_resource(path)
-        }
-        return self._slow_data
-
-    async def _async_save_persistent_cache(self, data: dict[str, Any]) -> None:
-        """Schedule persistence of explicitly allowlisted resource data."""
-        snapshot = {
-            path: value
-            for path, value in data.items()
-            if _is_persistent_cache_resource(path)
-        }
-        try:
-            self._persistent_store.async_delay_save(
-                lambda: {"saved_at": time.time(), "data": snapshot},
-                PERSISTENT_CACHE_SAVE_DELAY,
-            )
-        except Exception as err:
-            _LOGGER.debug("POINTTAPI persistent cache write failed: %s", err)
 
     @property
     def client(self) -> PoinTTAPIClient:
@@ -397,7 +322,6 @@ async def _fetch(self) -> dict[str, Any]:
             if isinstance(history, dict):
                 self._history_hourly_data = history
                 self._last_history_hourly_fetch = now
-            await self._async_save_persistent_cache(data)
             return data
 
         slow_due = (

unittests/test_pointtapi_coordinator.py

@@ -1,6 +1,7 @@
 """Tests for pointtapi_coordinator.py."""
 from __future__ import annotations
 
+import time
 from unittest.mock import AsyncMock, patch
 
 import pytest
@@ -425,13 +426,9 @@ async def mock_get(path):
 # ── Bulk steady state (discovery-then-bulk, fallback, rediscovery) ──────────
 
 
-import time
-
 from custom_components.bosch.pointtapi_coordinator import (
     HISTORY_HOURLY_PATH,
     HISTORY_HOURLY_REFRESH_INTERVAL,
-    PERSISTENT_CACHE_MAX_AGE,
-    PERSISTENT_CACHE_SAVE_DELAY,
     SLOW_RESOURCE_REFRESH_INTERVAL,
     REDISCOVERY_INTERVAL,
     PoinTTAPIDataUpdateCoordinator,
@@ -471,66 +468,6 @@ async def mock_get(path):
 
 
 class TestBulkSteadyState:
-    @pytest.mark.asyncio
-    async def test_persistent_cache_loads_only_fresh_slow_resources(self):
-        coord = _bare_coordinator(AsyncMock())
-        store = AsyncMock()
-        store.async_load.return_value = {
-            "saved_at": time.time(),
-            "data": {
-                "/gateway/versionFirmware": {"value": "1.2.3"},
-                "/gateway/identificationKey": {"value": "secret"},
-                "/system/appliance/status": {"value": "ready"},
-                "/zones/zn1/status": {"value": "idle"},
-            },
-        }
-        coord._persistent_store = store
-
-        snapshot = await coord.async_load_persistent_cache()
-
-        assert snapshot is not None
-        assert "/gateway/versionFirmware" in coord._slow_data
-        assert "/gateway/identificationKey" not in coord._slow_data
-        assert "/system/appliance/status" in coord._slow_data
-        assert "/zones/zn1/status" not in coord._slow_data
-
-    @pytest.mark.asyncio
-    async def test_expired_persistent_cache_is_ignored(self):
-        coord = _bare_coordinator(AsyncMock())
-        store = AsyncMock()
-        store.async_load.return_value = {
-            "saved_at": time.time() - PERSISTENT_CACHE_MAX_AGE - 1,
-            "data": {"/gateway/versionFirmware": {"value": "old"}},
-        }
-        coord._persistent_store = store
-
-        assert await coord.async_load_persistent_cache() is None
-        assert coord._slow_data == {}
-
-    @pytest.mark.asyncio
-    async def test_persistent_cache_save_is_delayed_and_allowlisted(self):
-        coord = _bare_coordinator(AsyncMock())
-        store = AsyncMock()
-        coord._persistent_store = store
-
-        await coord._async_save_persistent_cache(
-            {
-                "/gateway/versionFirmware": {"value": "1.2.3"},
-                "/gateway/identificationKey": {"value": "secret"},
-                "/system/appliance/status": {"value": "ready"},
-                HISTORY_HOURLY_PATH: {"value": []},
-            }
-        )
-
-        store.async_delay_save.assert_called_once()
-        data_func, delay = store.async_delay_save.call_args.args
-        saved = data_func()
-        assert delay == PERSISTENT_CACHE_SAVE_DELAY
-        assert "/gateway/versionFirmware" in saved["data"]
-        assert "/gateway/identificationKey" not in saved["data"]
-        assert HISTORY_HOURLY_PATH not in saved["data"]
-        assert "/system/appliance/status" in saved["data"]
-
     def test_bulk_failure_logging_is_throttled(self):
         coord = _bare_coordinator(AsyncMock())
         coord._bulk_warned_at = 100.0