Merge branch 'master' into pr18

Author: CaseyRo

CHANGELOG.md

@@ -4,8 +4,24 @@ All notable changes to this Bosch Home Assistant custom component will be docume
 
 ## [Unreleased]
 
-Collected for 1.3.0 (pre-released as 1.3.0-beta.1). Held out of 1.2.0 because
-none of it has been confirmed on real multi-zone hardware yet.
+## [1.3.1] — 2026-08-17 — Quiet teardown on cloud entries
+
+### Fixed
+- **No more hourly "Unable to remove unknown service bosch/debug_scan"** —
+  `debug_scan` only registers on the XMPP/HTTP path, but every unload removed
+  it unconditionally, so a POINTTAPI (cloud) entry asked Home Assistant to
+  remove a service it never had. Harmless, but it shouted about it in
+  @altugyurtbasi's log every reload since April. Both services are now guarded
+  on `has_service` rather than special-casing the debug one, since
+  `bosch.update` has the same exposure when setup fails before registration
+  (#7).
+
+## [1.3.0] — 2026-08-12 — Per-valve telemetry, assigned program, schedule/manual climate
+
+Pre-released as 1.3.0-beta.1 and held back from 1.2.0 until someone could run
+it on real multi-zone hardware. @LukyHurdy1 did, on a 12-zone Czech install,
+and reported battery `ok`, signal 69%, protocol `homematicip` and a working
+warning sensor — the confirmation this release ships on (#16).
 
 ### Added
 - **Per-thermostat-valve telemetry** — each ETRV from `/devices/list` becomes

custom_components/bosch/manifest.json

@@ -11,6 +11,6 @@
   "issue_tracker": "https://github.com/CaseyRo/ha_bosch/issues",
   "loggers": ["custom_components.bosch", "bosch_thermostat_client"],
   "requirements": ["bosch-thermostat-client==0.28.2"],
-  "version": "1.3.0-beta.1",
+  "version": "1.3.1",
   "zeroconf": ["_buderus._tcp.local."]
 }

custom_components/bosch/services.py

@@ -192,6 +192,13 @@ async def async_handle_put(service_call: ServiceCall) -> ServiceResponse:
 
 
 def async_remove_services(hass: HomeAssistant, config_entry: ConfigEntry) -> None:
-    """Remove services."""
-    hass.services.async_remove(DOMAIN, SERVICE_DEBUG)
-    hass.services.async_remove(DOMAIN, SERVICE_UPDATE)
+    """Remove services that this integration actually registered.
+
+    debug_scan only registers on the XMPP/HTTP path — a POINTTAPI entry returns
+    from async_init() long before that call — so removing it unconditionally
+    asks HA to drop a service that was never there and logs "Unable to remove
+    unknown service bosch/debug_scan" on every unload and reload (#7).
+    """
+    for service in (SERVICE_DEBUG, SERVICE_UPDATE):
+        if hass.services.has_service(DOMAIN, service):
+            hass.services.async_remove(DOMAIN, service)

unittests/test_services_removal.py

@@ -0,0 +1,38 @@
+"""Service teardown must not remove services it never registered (#7)."""
+from __future__ import annotations
+
+from unittest.mock import MagicMock
+
+from custom_components.bosch.const import DOMAIN, SERVICE_DEBUG, SERVICE_UPDATE
+from custom_components.bosch.services import async_remove_services
+
+
+def _hass(registered: set[str]) -> MagicMock:
+    hass = MagicMock()
+    hass.services.has_service.side_effect = (
+        lambda domain, service: domain == DOMAIN and service in registered
+    )
+    return hass
+
+
+def test_unregistered_debug_scan_is_not_removed():
+    """POINTTAPI entries never register debug_scan.
+
+    Removing it anyway makes HA log "Unable to remove unknown service
+    bosch/debug_scan" on every unload and reload.
+    """
+    hass = _hass({SERVICE_UPDATE})
+
+    async_remove_services(hass, MagicMock())
+
+    removed = {call.args[1] for call in hass.services.async_remove.call_args_list}
+    assert removed == {SERVICE_UPDATE}
+
+
+def test_registered_services_are_still_removed():
+    hass = _hass({SERVICE_DEBUG, SERVICE_UPDATE})
+
+    async_remove_services(hass, MagicMock())
+
+    removed = {call.args[1] for call in hass.services.async_remove.call_args_list}
+    assert removed == {SERVICE_DEBUG, SERVICE_UPDATE}