feat: upgrade to v1.7.0-alpha.11 spec - #9541
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements EIP-8282 (Builder deposits and exits) for the Gloas fork, extending ExecutionRequests with builder deposits and exits, updating serialization/deserialization logic, and adding corresponding block processing handlers. It also refactors voluntary exits to be validator-only post-Gloas. The review feedback highlights a critical bug where validator deposit appending logic was accidentally deleted in processDepositRequest.ts for Gloas, and points out a compilation error in types.ts due to missing imports of ForkName and ForkSeq.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
nflaig
marked this pull request as draft
June 21, 2026 10:05
5 tasks
Contributor
Performance Report✔️ no performance regression detected Full benchmark results
|
nazarhussain
self-requested a review
June 22, 2026 05:10
ensi321
reviewed
Jun 22, 2026
ensi321
left a comment
ensi321
left a comment
Member
There was a problem hiding this comment.
We need to remove all references to the builder voluntary exit mechanism that is now removed. Eg. remove getBuilderVoluntaryExitSignatureSet and merge getVoluntaryExitsSignatureSets and getVoluntaryExitSignatureSet into one.
Could be a future refactoring opportunity
Member
Author
yes there is more stuff we might wanna clean up, eg. there is no need to validate pending deposits anymore so we can probably remove the cache or at least keep it only for the fork transition, this branch still needs to be cleaned up carefully |
This was referenced Jun 24, 2026
ensi321
marked this pull request as ready for review
June 26, 2026 05:34
Member
|
@lodekeeper review plz |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92e099ad51
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Contributor
|
@ensi321 reviewed 👍 — focused on the EIP-8282 core + the flagged findings (not an exhaustive pass over all 45 files, and I see it's still WIP per @nflaig's note). Both Gemini "blocking" findings are already resolved on current HEAD (flagged on an earlier commit):
New builder-request processors look correct & spec-aligned:
On your cleanup point (builder voluntary exit refs): agreed — |
Member
|
@lodekeeper no you need to review the entire PR, which covers all alpha.11 changes. This PR is ready for review. Clean ups will be done in a follow up PR |
ensi321
enabled auto-merge (squash)
June 26, 2026 06:17
Contributor
|
@ensi321 done — full review of all 45 alpha.11 files (reviewed at HEAD Verdict: solid, spec-faithful alpha.11 upgrade. No blocking correctness issues beyond the one already flagged (the Clean (cross-checked against consensus-specs v1.7.0-alpha.11)
Low / non-blocking
Info (pre-existing, out of scope)
Plus the already-resolved items for the record: Gemini's two "blocking" findings were false positives on an earlier commit (replied r3479378162 / r3479378249), and the codex Nothing here blocks from my side — the voluntary-exit and pending-deposit-cache cleanups are fine as the follow-up you described. Nice work. 👍 |
nflaig
pushed a commit
to ChainSafe/lodestar-z
that referenced
this pull request
Jun 27, 2026
Bumps the consensus spec tests from `v1.7.0-alpha.10` to `v1.7.0-alpha.11`. Closes #443. ### Changes - `build.zig.zon`: bump `spec_test_version` default to `v1.7.0-alpha.11` - `test/spec/version.txt`: updated version (changed by the spec-test download step, not hand edited) ### Notes - Unblocked by ChainSafe/lodestar#9541 (alpha.11 spec upgrade), now merged — lodestar and lodestar-z are aligned on the same spec test version. - All spec tests pass locally against alpha.11. - The pre-gloas spec refactors @ensi321 flagged in [#441 (comment)](#441 (review)) don't surface as test failures. Leaving those alignments as a separate follow-up rather than folding them into this bump though I can also fold them in here if needed.
Member
|
🎉 This PR is included in v1.44.0 🎉 |
nflaig
added a commit
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements the following spec changes required to pass
v1.7.0-alpha.11spec testsPAYLOAD_BUILDER_VERSIONethereum/consensus-specs#5377process_execution_payload_bidethereum/consensus-specs#5364get_beacon_proposer_indexethereum/consensus-specs#5368