feature: gr import list refresh interval - #122
Open
benjitobz wants to merge 3 commits into
Open
Conversation
The configurable interval defaults to 720 minutes, the same 12 hours the hard-coded MinRefreshInterval used, so existing lists and new ones behave exactly as before until a user chooses a shorter interval.
benjitobz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Goodreads bookshelf import lists were pinned to a hard-coded MinRefreshInterval of 12 hours, which is a little extreme — a book added to a shelf could sit unnoticed for half a day, with no way to change it short of a rebuild. This makes the interval a per-list setting ("Refresh Interval (Minutes)", advanced) so users can pick a cadence that meets their needs. The default stays at 720 minutes (12 hours), so existing and new lists behave exactly as before unless a user opts into a shorter interval. Validated at a minimum of 1 minute, with help text noting that short intervals mean more requests to Goodreads.
Fixes # - N/A
Database Migration
NO. The new RefreshIntervalMinutes field is stored in the import list's existing JSON settings blob; no schema change.
How was this tested?
Docker (linux/amd64) on an Ubuntu server host, image built with Dockerfile.build, against live Goodreads shelves.
Screenshots (UI changes only) - screenshot with and without the error helper message
A note on AI: We know AI/agentic coding is everywhere and only getting
more popular. We won't insist that you disclose whether you used it or which
models you used, but in the same spirit, please don't take offense if your PR
is scrutinized and changes are requested.
Review time: The longer the PR and the more lines changed, the longer the
review will take. Small, focused PRs merge fastest. If yours is big, please be
patient.