fix: restrict Express static middleware to known public directories - #1251
Open
vp916 wants to merge 1 commit into
Open
fix: restrict Express static middleware to known public directories#1251vp916 wants to merge 1 commit into
vp916 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1032
Closes #1030
Closes #388
(These three issues are duplicates of each other, same root cause.)
Summary
app.use(express.static(__dirname))served the entire project root as static files, meaning anyone could directly request internal files over HTTP - e.g./server.js,/database.js,/package.json- exposing backend source code and configuration.Changes Made
express.static(__dirname)mount./css,/js,/public,/support-page./logo.pngand/(index.html).Testing
Ran a minimal Express instance with the new route configuration and verified via curl:
/,/logo.png,/css/index.css,/public/favicon.ico,/support-page/support.html-> 200 (all real frontend assets still served correctly)/server.js,/database.js,/package.json-> 404 (previously these returned 200, exposing source/config)Screenshots
N/A (backend-only change, no UI impact).
Checklist