Add Qodana code quality scanning workflow #3
ChaseDRedmonAnnotations
63 warnings and 12 notices
|
Access to disposed captured variable:
src/Scufpad/Program.cs#L39
Captured variable is disposed in the outer scope
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L280
Name 'ABS_HAT0X' does not match rule 'Constant fields (not private)'. Suggested name is 'AbsHat0X'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L283
Name 'ABS_HAT0Y' does not match rule 'Constant fields (not private)'. Suggested name is 'AbsHat0Y'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L271
Name 'ABS_RX' does not match rule 'Constant fields (not private)'. Suggested name is 'AbsRx'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L274
Name 'ABS_RY' does not match rule 'Constant fields (not private)'. Suggested name is 'AbsRy'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L277
Name 'ABS_RZ' does not match rule 'Constant fields (not private)'. Suggested name is 'AbsRz'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L262
Name 'ABS_X' does not match rule 'Constant fields (not private)'. Suggested name is 'AbsX'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L265
Name 'ABS_Y' does not match rule 'Constant fields (not private)'. Suggested name is 'AbsY'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L268
Name 'ABS_Z' does not match rule 'Constant fields (not private)'. Suggested name is 'AbsZ'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L185
Name 'BTN_A' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnA'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L191
Name 'BTN_B' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnB'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L194
Name 'BTN_C' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnC'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L188
Name 'BTN_EAST' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnEast'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L179
Name 'BTN_GAMEPAD' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnGamepad'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L176
Name 'BTN_MISC' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnMisc'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L230
Name 'BTN_MODE' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnMode'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L197
Name 'BTN_NORTH' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnNorth'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L224
Name 'BTN_SELECT' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnSelect'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L182
Name 'BTN_SOUTH' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnSouth'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L227
Name 'BTN_START' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnStart'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L233
Name 'BTN_THUMBL' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnThumbl'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L236
Name 'BTN_THUMBR' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnThumbr'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L212
Name 'BTN_TL' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnTl'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L218
Name 'BTN_TL2' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnTl2'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L215
Name 'BTN_TR' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnTr'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L221
Name 'BTN_TR2' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnTr2'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L239
Name 'BTN_TRIGGER_HAPPY1' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnTriggerHappy1'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L242
Name 'BTN_TRIGGER_HAPPY2' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnTriggerHappy2'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L245
Name 'BTN_TRIGGER_HAPPY3' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnTriggerHappy3'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L248
Name 'BTN_TRIGGER_HAPPY4' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnTriggerHappy4'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L203
Name 'BTN_WEST' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnWest'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L200
Name 'BTN_X' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnX'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L206
Name 'BTN_Y' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnY'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L209
Name 'BTN_Z' does not match rule 'Constant fields (not private)'. Suggested name is 'BtnZ'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Uinput.cs#L178
Name 'BUS_USB' does not match rule 'Constant fields (not private)'. Suggested name is 'BusUsb'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Uinput.cs#L181
Name 'BUS_VIRTUAL' does not match rule 'Constant fields (not private)'. Suggested name is 'BusVirtual'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Libc.cs#L139
Name 'EAGAIN' does not match rule 'Constant fields (not private)'. Suggested name is 'Eagain'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Libc.cs#L136
Name 'EINTR' does not match rule 'Constant fields (not private)'. Suggested name is 'Eintr'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L299
Name 'EVIOCGRAB' does not match rule 'Constant fields (not private)'. Suggested name is 'Eviocgrab'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L147
Name 'EV_ABS' does not match rule 'Constant fields (not private)'. Suggested name is 'EvAbs'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L150
Name 'EV_FF' does not match rule 'Constant fields (not private)'. Suggested name is 'EvFf'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L144
Name 'EV_KEY' does not match rule 'Constant fields (not private)'. Suggested name is 'EvKey'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L141
Name 'EV_SYN' does not match rule 'Constant fields (not private)'. Suggested name is 'EvSyn'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Hidraw.cs#L59
Name 'HIDIOCGRAWINFO' does not match rule 'Constant fields (not private)'. Suggested name is 'Hidiocgrawinfo'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Hidraw.cs#L65
Name 'HIDIOCGRAWNAME_256' does not match rule 'Constant fields (not private)'. Suggested name is 'Hidiocgrawname256'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Libc.cs#L121
Name 'O_NONBLOCK' does not match rule 'Constant fields (not private)'. Suggested name is 'ONonblock'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Libc.cs#L112
Name 'O_RDONLY' does not match rule 'Constant fields (not private)'. Suggested name is 'ORdonly'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Libc.cs#L118
Name 'O_RDWR' does not match rule 'Constant fields (not private)'. Suggested name is 'ORdwr'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Libc.cs#L115
Name 'O_WRONLY' does not match rule 'Constant fields (not private)'. Suggested name is 'OWronly'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Libc.cs#L130
Name 'POLLERR' does not match rule 'Constant fields (not private)'. Suggested name is 'Pollerr'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Libc.cs#L133
Name 'POLLHUP' does not match rule 'Constant fields (not private)'. Suggested name is 'Pollhup'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Libc.cs#L124
Name 'POLLIN' does not match rule 'Constant fields (not private)'. Suggested name is 'Pollin'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Libc.cs#L127
Name 'POLLOUT' does not match rule 'Constant fields (not private)'. Suggested name is 'Pollout'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/LinuxInput.cs#L162
Name 'SYN_REPORT' does not match rule 'Constant fields (not private)'. Suggested name is 'SynReport'.
|
|
Inconsistent Naming:
src/Scufpad/Input/HidrawReader.cs#L96
Name 'ScufProductId' does not match rule 'Local constants'. Suggested name is 'scufProductId'.
|
|
Inconsistent Naming:
src/Scufpad/Input/HidrawReader.cs#L95
Name 'ScufVendorId' does not match rule 'Local constants'. Suggested name is 'scufVendorId'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Uinput.cs#L151
Name 'UI_ABS_SETUP' does not match rule 'Constant fields (not private)'. Suggested name is 'UiAbsSetup'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Uinput.cs#L160
Name 'UI_DEV_CREATE' does not match rule 'Constant fields (not private)'. Suggested name is 'UiDevCreate'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Uinput.cs#L169
Name 'UI_DEV_DESTROY' does not match rule 'Constant fields (not private)'. Suggested name is 'UiDevDestroy'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Uinput.cs#L141
Name 'UI_DEV_SETUP' does not match rule 'Constant fields (not private)'. Suggested name is 'UiDevSetup'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Uinput.cs#L132
Name 'UI_SET_ABSBIT' does not match rule 'Constant fields (not private)'. Suggested name is 'UiSetAbsbit'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Uinput.cs#L111
Name 'UI_SET_EVBIT' does not match rule 'Constant fields (not private)'. Suggested name is 'UiSetEvbit'.
|
|
Inconsistent Naming:
src/Scufpad/Interop/Uinput.cs#L121
Name 'UI_SET_KEYBIT' does not match rule 'Constant fields (not private)'. Suggested name is 'UiSetKeybit'.
|
|
Class is never instantiated: Private accessibility:
tests/scufpad.Tests.Unit/Services/BridgeServiceLogicTests.cs#L212
Class 'HidrawReaderMock' is never instantiated
|
|
Convert lambda expression into method group:
tests/scufpad.Tests.Unit/Interop/LinuxInputTests.cs#L55
Convert into method group
|
|
Convert lambda expression into method group:
tests/scufpad.Tests.Unit/Interop/UinputTests.cs#L116
Convert into method group
|
|
Convert constructor into primary constructor:
tests/scufpad.Tests.Unit/Interop/HidrawTests.cs#L65
Convert into primary constructor
|
|
Convert constructor into primary constructor:
tests/scufpad.Tests.Unit/Interop/LinuxInputTests.cs#L93
Convert into primary constructor
|
|
Convert constructor into primary constructor:
tests/scufpad.Tests.Unit/Interop/LinuxInputTests.cs#L149
Convert into primary constructor
|
|
Convert constructor into primary constructor:
tests/scufpad.Tests.Unit/Interop/UinputTests.cs#L106
Convert into primary constructor
|
|
For-loop can be converted into foreach-loop:
tests/scufpad.Tests.Integration/MappingIntegrationTests.cs#L46
For-loop can be converted into foreach-loop
|
|
Redundant type declaration body:
tests/scufpad.Tests.Unit/Services/BridgeServiceLogicTests.cs#L213
Redundant empty class declaration body
|
|
Type member is never used: Non-private accessibility:
src/Scufpad/Input/HidrawReader.cs#L111
Method 'ReadReport' is never used
|
|
Method return value is never used: Non-private accessibility:
src/Scufpad/Interop/Libc.cs#L34
Method 'Close' return value is never used
|
|
|