feat(ads): split analytics dashboard by channel and reuse shared date filter

Replace the single Ads analytics menu item with one per ads-eligible channel
(Click-to-WhatsApp/Messenger/Instagram). Each lands on /dashboard/ads/<channel>,
validated against adsEligibleChannelTypes (404 on anything else) and superAdmin-
guarded; the channel-less route redirects to the requested channel when a stale
?channel= bookmark names a valid one, else the default. Per-channel integration
resolution is a compile-time-exhaustive Record<AdsEligibleChannelType, ...> map,
so adding a channel breaks the build rather than silently missing a case.

Swap the ads-only date-range controls for the shared DateRangePresetFilter
(refresh + preset dropdown + custom calendar), same position as Contacts/
Conversations, defaulting to Last 7 days. A URL bridge (useAdsRangeUrl) formats
the picked local calendar day into the ?from=&to= keys and restores the active
preset on load; the interim local-key-over-UTC-pipeline seam is documented, with
the full timezone migration tracked in docs/plans.

Fix an over-cap range (the Lifetime preset on an old workspace, or a manipulated
URL) silently collapsing to 7 days: parseAnalyticsDateRange now clamps to the
last 366 days, and workspaceCreatedAt floors Lifetime at workspace birth so its
range stays under the cap and the preset label resolves correctly.

Author: viethungpv91

…lytics-channel-filter-component.test.tsx …er/__tests__/ads-account-filter.test.tsxapps/builder/__tests__/ads-analytics-channel-filter-component.test.tsx renamed to apps/builder/__tests__/ads-account-filter.test.tsx apps/builder/__tests__/ads-analytics-channel-filter-component.test.tsx renamed to apps/builder/__tests__/ads-account-filter.test.tsx

@@ -3,11 +3,11 @@
 import { act, type ReactNode } from "react"
 import { createRoot, type Root } from "react-dom/client"
 import { afterEach, beforeEach, describe, expect, test, vi } from "vitest"
-import { ChannelFilter } from "@/features/ads/components/channel-filter"
+import { AdsAccountFilter } from "@/features/ads/components/ads-account-filter"
 import type { AdsAnalyticsSearchParams } from "@/features/ads/schemas/analytics"
 
 vi.mock("next/navigation", () => ({
-  usePathname: () => "/space/ws-1/dashboard/ads",
+  usePathname: () => "/space/ws-1/dashboard/ads/messenger",
   useRouter: () => ({ push: vi.fn() }),
   useSearchParams: () => new URLSearchParams(),
 }))
@@ -34,9 +34,10 @@ const baseRange = {
   account: "",
   channelAccount: "",
   adAccount: "",
-} as Omit<AdsAnalyticsSearchParams, "channel">
+  channel: "messenger",
+} as AdsAnalyticsSearchParams
 
-describe("ChannelFilter — 'All channels' option and integration-select visibility", () => {
+describe("AdsAccountFilter — integration/account select only, no channel select", () => {
   let container: HTMLDivElement
   let root: Root
 
@@ -54,31 +55,36 @@ describe("ChannelFilter — 'All channels' option and integration-select visibil
     container.remove()
   })
 
-  test("renders an 'All channels' option via the special label branch, not a fake tabs.all key", async () => {
+  test("renders no channel select — the channel select trigger id is absent", async () => {
     await act(async () => {
       root.render(
-        <ChannelFilter
-          channelIntegrations={[]}
-          range={{ ...baseRange, channel: "all" }}
-          selectedIntegrationId={null}
+        <AdsAccountFilter
+          channelIntegrations={[{ id: "msg-1", name: "My Page" }]}
+          range={baseRange}
+          selectedIntegrationId="msg-1"
         />,
       )
       await Promise.resolve()
     })
 
-    expect(container.textContent).toContain(
+    expect(
+      container.querySelector('[data-select-trigger="ads-analytics-channel"]'),
+    ).toBeNull()
+    expect(container.textContent).not.toContain(
       "ads.analytics.channelFilter.allChannels",
     )
-    expect(container.textContent).not.toContain("ads.conversionEvents.tabs.all")
+    expect(container.textContent).not.toContain(
+      "ads.analytics.channelFilter.label",
+    )
   })
 
-  test("hides the integration select entirely when channel is 'all'", async () => {
+  test("renders the integration/account select with the current channel's integrations", async () => {
     await act(async () => {
       root.render(
-        <ChannelFilter
+        <AdsAccountFilter
           channelIntegrations={[{ id: "msg-1", name: "My Page" }]}
-          range={{ ...baseRange, channel: "all" }}
-          selectedIntegrationId={null}
+          range={baseRange}
+          selectedIntegrationId="msg-1"
         />,
       )
       await Promise.resolve()
@@ -88,16 +94,20 @@ describe("ChannelFilter — 'All channels' option and integration-select visibil
       container.querySelector(
         '[data-select-trigger="ads-analytics-channel-account"]',
       ),
-    ).toBeNull()
+    ).not.toBeNull()
+    expect(container.textContent).toContain("My Page")
+    expect(container.textContent).toContain(
+      "ads.analytics.channelFilter.allAccounts",
+    )
   })
 
-  test("shows the integration select for a concrete channel", async () => {
+  test("shows the integration select even with an empty integrations list (no 'all channels' hide branch anymore)", async () => {
     await act(async () => {
       root.render(
-        <ChannelFilter
-          channelIntegrations={[{ id: "msg-1", name: "My Page" }]}
-          range={{ ...baseRange, channel: "messenger" }}
-          selectedIntegrationId="msg-1"
+        <AdsAccountFilter
+          channelIntegrations={[]}
+          range={baseRange}
+          selectedIntegrationId={null}
         />,
       )
       await Promise.resolve()

apps/builder/__tests__/ads-analytics-date-range-presets.test.ts

@@ -4,6 +4,26 @@ import {
   parseAnalyticsDateRange,
 } from "@/features/ads/schemas/analytics"
 
+describe("getDefaultAdsAnalyticsRange", () => {
+  test("returns a 7-day window (today back 6 days, UTC) matching the Last 7 days preset default", () => {
+    const now = new Date("2026-08-11T15:30:00.000Z")
+
+    expect(getDefaultAdsAnalyticsRange(now)).toEqual({
+      from: "2026-08-05",
+      to: "2026-08-11",
+    })
+  })
+
+  test("anchors to UTC midnight, ignoring the time-of-day component", () => {
+    const earlyMorning = new Date("2026-08-11T00:00:01.000Z")
+    const lateNight = new Date("2026-08-11T23:59:59.000Z")
+
+    expect(getDefaultAdsAnalyticsRange(earlyMorning)).toEqual(
+      getDefaultAdsAnalyticsRange(lateNight),
+    )
+  })
+})
+
 describe("parseAnalyticsDateRange", () => {
   test("keeps a normal 30-day range unchanged", () => {
     const result = parseAnalyticsDateRange({
@@ -25,16 +45,21 @@ describe("parseAnalyticsDateRange", () => {
     expect(result.to).toBe("2026-08-11")
   })
 
-  test("falls back to the default range for a 40-year span (HIGH-5)", () => {
-    const fallback = getDefaultAdsAnalyticsRange()
-
+  test("clamps an over-cap span to the last 366 days ending at `to` (HIGH-5)", () => {
+    // A 40-year span (or the "Lifetime" preset on an old workspace) must stay
+    // bounded by the scan guard, but the user should see the most recent year
+    // under their chosen label — not a silent collapse to the 7-day default.
     const result = parseAnalyticsDateRange({
       from: "1986-08-11",
       to: "2026-08-11",
     })
 
-    expect(result.from).toBe(fallback.from)
-    expect(result.to).toBe(fallback.to)
+    expect(result.from).toBe("2025-08-11")
+    expect(result.to).toBe("2026-08-11")
+    // The clamped window is exactly at the cap boundary (still accepted).
+    const spanDays =
+      (result.until.getTime() - result.since.getTime()) / (24 * 60 * 60 * 1000)
+    expect(spanDays).toBeLessThanOrEqual(366)
   })
 
   test("falls back to the default range when since > until (existing behavior, unchanged)", () => {