fix: review

Author: realcodesiman

apps/builder/src/features/flows/react-flow/steps/generate-code/editor.tsx

@@ -52,13 +52,13 @@ const GenerateCodeDialog = ({ parentName }: { parentName: string }) => {
     Resolver<GenerateCodeStepInput, object, GenerateCodeStepSchema>
   >(
     async (values, context, options) => {
-      const zodResolve = zodResolver(generateCodeStepSchema) as Resolver<
+      const base = zodResolver(generateCodeStepSchema) as Resolver<
         GenerateCodeStepInput,
         object,
         GenerateCodeStepSchema
       >
-      const result = await zodResolve(values, context, options)
-      if (Number(values.min) > Number(values.max)) {
+      const result = await base(values, context, options)
+      if (result.errors.max?.type === "custom") {
         result.errors.max = {
           type: "manual",
           message: t("validation.maxMustBeGreaterThanMin", {

packages/flow-config/src/steps/generate-code.ts

@@ -8,18 +8,23 @@ export const GenerateCodeType = {
   ALPHANUMERIC_LENGTH: "ALPHANUMERIC_LENGTH",
 } as const
 
-export const generateCodeStepSchema = z.object({
-  id: zodBigintAsString(),
-  stepType: z.literal(stepTypes.enum.generateCode),
-  type: z.enum(GenerateCodeType),
-  min: z.coerce
-    .number()
-    .int()
-    .min(0)
-    .max(Number.MAX_SAFE_INTEGER - 1),
-  max: z.coerce.number().int().min(0).max(Number.MAX_SAFE_INTEGER),
-  outputFieldId: z.string().trim().min(1),
-})
+export const generateCodeStepSchema = z
+  .object({
+    id: zodBigintAsString(),
+    stepType: z.literal(stepTypes.enum.generateCode),
+    type: z.enum(GenerateCodeType),
+    min: z.coerce
+      .number()
+      .int()
+      .min(0)
+      .max(Number.MAX_SAFE_INTEGER - 1),
+    max: z.coerce.number().int().min(0).max(Number.MAX_SAFE_INTEGER),
+    outputFieldId: z.string().trim().min(1),
+  })
+  .refine((data) => data.min <= data.max, {
+    message: "Max must be greater than or equal to Min",
+    path: ["max"],
+  })
 export type GenerateCodeStepSchema = z.infer<typeof generateCodeStepSchema>
 export type GenerateCodeStepInput = z.input<typeof generateCodeStepSchema>