revert(analytics): hide disconnected inboxes on the dashboard cards again (#1117)

Author: viethung0o0

apps/builder/src/app/space/[workspaceId]/dashboard/layout.tsx

@@ -38,15 +38,7 @@ export default async function DashboardLayout({
   const cloud = isCloud()
   const { targetWorkspace } = userAndWorkspace
   const [inboxesResult, { blocked, blockReason }] = await Promise.all([
-    // Disconnected inboxes stay listed: Settings -> Channels shows an
-    // integration whether or not its inbox is still connected, so hiding them
-    // here made a channel silently disappear from one surface while remaining
-    // on the other, with nothing on screen explaining the difference.
-    listInboxes({
-      workspaceId,
-      includes: ["integration"],
-      statuses: ["connected", "disconnected"],
-    }),
+    listInboxes({ workspaceId, includes: ["integration"] }),
     resolveWorkspaceBlockState(targetWorkspace.ownerId),
   ])
   const inboxes = inboxesResult.data.filter((inbox) => inbox.channel !== "smtp")

apps/builder/src/features/inboxes/queries/index.ts

@@ -1,8 +1,8 @@
 import type { ListInboxesResponse } from "@chatbotx.io/business"
-import { inboxService, type ListInboxesInput } from "@chatbotx.io/business"
+import { inboxService, type ListInboxesRequest } from "@chatbotx.io/business"
 
 export async function listInboxes(
-  input: ListInboxesInput,
+  input: ListInboxesRequest,
 ): Promise<ListInboxesResponse> {
   return await inboxService.list(input)
 }

packages/business/__tests__/inbox-service-list-status.test.ts

@@ -1,4 +1,3 @@
-import type { InboxStatus } from "@chatbotx.io/database/partials"
 import { createSelectSchema, inboxModel } from "@chatbotx.io/database/schema"
 import { zodBigintAsString } from "@chatbotx.io/utils"
 import { z } from "zod"
@@ -18,26 +17,6 @@ export const listInboxesRequest = z.object({
 })
 export type ListInboxesRequest = z.infer<typeof listInboxesRequest>
 
-/**
- * Server-side input for `inboxService.list`, deliberately NOT part of
- * `listInboxesRequest`.
- *
- * `publishInboxesRequest` is `listInboxesRequest.omit({ workspaceId: true })`,
- * so anything added to that schema immediately becomes a documented parameter
- * of the public `/v1/inboxes` and `/v1/channels` endpoints. `statuses` is an
- * internal rendering concern, so it rides alongside the schema instead: every
- * oRPC handler passes only the zod-parsed request and therefore keeps the
- * connected-only default, while a server component that needs the wider list
- * asks for it explicitly.
- */
-export type ListInboxesInput = ListInboxesRequest & {
-  /**
-   * Inbox statuses to include. Omitted means `["connected"]` — the
-   * long-standing behaviour every existing caller relies on.
-   */
-  statuses?: readonly InboxStatus[]
-}
-
 export const inboxResource = createSelectSchema(inboxModel, {
   id: zodBigintAsString(),
   workspaceId: zodBigintAsString(),

packages/business/src/inbox/schema.ts

@@ -24,7 +24,7 @@ import { channelLimitReachedException } from "../errors"
 import { logger } from "../logger"
 import { quotaEnforcementService } from "../quota-enforcement/service"
 import { workspaceUsageService } from "../workspace-usage/service"
-import type { ListInboxesInput, ListInboxesResponse } from "./schema"
+import type { ListInboxesRequest, ListInboxesResponse } from "./schema"
 
 type InboxWhere = Partial<{ id: string; workspaceId: string }>
 
@@ -40,16 +40,12 @@ class InboxService extends BaseService {
     integrationTiktok: true,
   }
 
-  async list(input: ListInboxesInput): Promise<ListInboxesResponse> {
+  async list(input: ListInboxesRequest): Promise<ListInboxesResponse> {
     // One `where`, shared by the page query and the count, so the two can
     // never drift (they previously repeated the same literal side by side).
-    // `statuses` omitted keeps the connected-only default every existing
-    // caller — including the public `/v1/inboxes` endpoint — depends on.
     const where = {
       workspaceId: input.workspaceId,
-      status: input.statuses
-        ? { in: [...input.statuses] }
-        : inboxStatuses.enum.connected,
+      status: inboxStatuses.enum.connected,
     }
 
     const pagination = getPaginationWithDefaults(input)