Skip to content

Commit db08c36

Browse files
docs: set ignore-on-exit in the config file SARIF example
1 parent d59a19c commit db08c36

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

‎README.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,7 @@ jobs:
424424
{
425425
"exclude-categories": "Encryption",
426426
"exclude-paths": "terraform/gcp/big_data.tf,terraform/gcp/gcs.tf",
427+
"ignore-on-exit": "results",
427428
"log-file": true,
428429
"minimal-ui": false,
429430
"no-color": false,

‎test/e2e/repository-contract.test.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const test = require('node:test')
44
const assert = require('node:assert/strict')
55
const fs = require('node:fs')
66
const path = require('node:path')
7-
const { knownBug } = require('../helpers/known-bug')
87
const { ROOT, loadManifest } = require('../helpers/action-manifest')
98

109
const read = (file) => fs.readFileSync(path.join(ROOT, file), 'utf8')
@@ -54,7 +53,6 @@ test('README', async (t) => {
5453
await t.test('has SARIF upload examples', () => assert.ok(sarifExamples.length > 0))
5554

5655
for (const [i, block] of sarifExamples.entries()) {
57-
const options = block.includes('config_path') ? knownBug('the config file example sets neither ignore_on_exit nor ignore-on-exit, so the job fails before the SARIF upload (#76)') : {}
58-
await t.test(`SARIF upload example ${i + 1} does not fail before the upload`, options, () => assert.match(block, /ignore[_-]on[_-]exit/))
56+
await t.test(`SARIF upload example ${i + 1} does not fail before the upload`, () => assert.match(block, /ignore[_-]on[_-]exit/))
5957
}
6058
})

0 commit comments

Comments
 (0)