Repository navigation
Add custom NAT rules to the legacy client - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds custom NAT rules (DNAT, MASQUERADE, SNAT) to
UnifiLegacyClientthrough the v2 site API (/proxy/network/v2/api/site/<site>/nat), so Homelab can declare them (Homelab#678).UnifiNatRuleSpec/UnifiNatFilter:Nameis the rule'sdescription(rules have no name), networks by name, one address/range/CIDR per filter withInvertAddressfor "except". Record equality is the drift check.UnifiNatRuleJson:ToJson/FromJson.FromJsonrefuses whatToJsoncan't write back (non-IPv4,exclude,pppoe_use_base_interface, non-manualsetting_preference, filter types other than ADDRESS_AND_PORT).GetNatNamesAsync(network name to_id). Create takes the next freerule_index(the controller rejects a duplicate); update keeps the live index when the spec has none. Update and delete refuse predefined rules and ids not on the controller.Shape taken from the two live rules on the UCG (Network 10.6.106), supplied by the Homelab Blocky session; not yet checked by a read of my own. 143 passed, 7 skipped, 0 failed.
The throwaway container has no gateway and answers a NAT POST with 500, so there is no container create/delete test: writes are unit-tested against that shape, and one container test covers list and the name lookup.