Tan 8492 pending review approved when project is published - #14648
Open
Stef-Rousset wants to merge 11 commits into
Open
Tan 8492 pending review approved when project is published#14648Stef-Rousset wants to merge 11 commits into
Stef-Rousset wants to merge 11 commits into
Conversation
Collaborator
|
Stef-Rousset
marked this pull request as ready for review
August 24, 2026 09:44
Stef-Rousset
requested review from
jinjagit
and removed request for
AchrafGoVocal
August 24, 2026 14:44
jinjagit
reviewed
Aug 25, 2026
jinjagit
reviewed
Aug 25, 2026
jinjagit
reviewed
Aug 25, 2026
jinjagit
approved these changes
Aug 25, 2026
Contributor
There was a problem hiding this comment.
LGTM.
I have raised a question , however, about the remaining mechanism that can maybe produce more of such 'published and awaiting review' projects, even after you run the rake task to clean them up.
jinjagit
reviewed
Aug 27, 2026
jinjagit
reviewed
Aug 27, 2026
jinjagit
reviewed
Aug 27, 2026
jinjagit
requested changes
Aug 27, 2026
Stef-Rousset
force-pushed
the
TAN-8492-pending-review-approved-when-project-is-published
branch
from
August 28, 2026 15:00
39c1af8 to
83fc237
Compare
Contributor
Author
Hello @jinjagit , no pb, thx for your check ! I made the necessary changes 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When the admin directly published the project, the project_manager still sees 'waiting approval' in the back office of the project, even though the project has already been published.
Now the pending review if ti exists is approved in this case.
Published button is also displayed for the project manager when an admin publishes a project for which no review was ever requested.
This PR also contains a new method in project_review model, approvable_by?, to refactor the code.
✅ Tasks
Changelog
Fixed