Skip to content

fix(parser): detach diagnostic locations from source - #32

Merged
ClaudiuCeia merged 1 commit into
fix/location-backward-scansfrom
fix/location-source-retention
Sep 6, 2026
Merged

fix(parser): detach diagnostic locations from source#32
ClaudiuCeia merged 1 commit into
fix/location-backward-scansfrom
fix/location-source-retention

Conversation

@ClaudiuCeia

Copy link
Copy Markdown
Owner

Depends on #31.

  • Replaces source-retaining lazy getters for oversized unscoped parses with eager location snapshots.
  • Preserves the existing plain data shape and keeps session-backed parsing lazy.
  • Documents the direct parser invocation cost and recommends runParser or parseAll for large inputs.

Validation: bun run check, deno task check, bun run build, and bun run package:check.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

CI results

Check Result
Formatting Passed
Lint Passed
Types Passed
Tests Passed
Benchmark correctness Passed
Package Passed
Bun runtime Passed
Node 20/26 Passed
Deno / JSR Passed
Performance Passed

Performance

Passed: no benchmark exceeded the 15% regression threshold.

Results use the median p50 from 3 base and 3 head runs on the same runner.

Benchmark Base Head Change Result
construct/grammar 961.00 ns 932.00 ns -3.0% Pass
construct/grammar-and-first-parse 18.55 us 18.11 us -2.4% Pass
expression/invalid-late 341.36 us 335.46 us -1.7% Pass
expression/large 2.83 ms 2.77 ms -2.4% Pass
expression/medium 357.67 us 353.31 us -1.2% Pass
expression/small 17.61 us 18.24 us +3.6% Pass

@ClaudiuCeia
ClaudiuCeia marked this pull request as ready for review September 6, 2026 17:55
@ClaudiuCeia

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-06T17:58:34.401197Z 1c4b4f4 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 1c4b4f4e7e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ClaudiuCeia
ClaudiuCeia merged commit e246dcc into main Sep 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant