Skip to content

Commit 7fddfbc

Browse files
authored
Merge pull request #69 from CodandoTV/fix/tasks-list-render-issue
Fix tasks list rendering issue by wrapping TasksListWidget in Expande…
2 parents 6b33a78 + da4a3d0 commit 7fddfbc

3 files changed

Lines changed: 22 additions & 22 deletions

File tree

‎lib/ui/components/widgets/checklist/checklist_full_widget.dart‎

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -99,25 +99,28 @@ class ChecklistsListFullWidgetState extends State<ChecklistsListFullWidget> {
9999
itemCount: widget.checklists.length,
100100
),
101101
),
102-
TasksListWidget(
102+
Expanded(
103103
flex: 6,
104-
progress: progress,
105-
status: status,
106-
tasks: tasks == null ? [] : tasks!,
107-
onCompleteTask: _tasksViewModel.onCompleteTask,
108-
onRemoveTask: (task) => _showConfirmationDialogToRemoveTask(
109-
context,
110-
task,
111-
),
112-
onReorder: _tasksViewModel.reorder,
113-
onTap: (task) => _navigateToTaskScreen(
114-
context,
115-
checklistId: selected?.id,
116-
task: task,
104+
child: TasksListWidget(
105+
flex: 6,
106+
progress: progress,
107+
status: status,
108+
tasks: tasks == null ? [] : tasks!,
109+
onCompleteTask: _tasksViewModel.onCompleteTask,
110+
onRemoveTask: (task) => _showConfirmationDialogToRemoveTask(
111+
context,
112+
task,
113+
),
114+
onReorder: _tasksViewModel.reorder,
115+
onTap: (task) => _navigateToTaskScreen(
116+
context,
117+
checklistId: selected?.id,
118+
task: task,
119+
),
120+
onCompleteButtonAction: () {
121+
_tasksViewModel.onCompleteButtonAction(selected?.id);
122+
},
117123
),
118-
onCompleteButtonAction: () {
119-
_tasksViewModel.onCompleteButtonAction(selected?.id);
120-
},
121124
),
122125
],
123126
);

‎lib/ui/components/widgets/task/taskslist/tasks_list_widget.dart‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,7 @@ class TasksListWidget extends StatelessWidget {
7777
);
7878
}
7979

80-
return Expanded(
81-
flex: flex ?? 1,
82-
child: child,
83-
);
80+
return child;
8481
}
8582

8683
TaskCellWidget _buildTaskCellWidget(Task task) {

‎pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
1616
# https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
1717
# In Windows, build-name is used as the major, minor, and patch parts
1818
# of the product and file versions while build-number is used as the build suffix.
19-
version: 1.2.1
19+
version: 1.2.2
2020

2121
environment:
2222
sdk: ^3.5.0

0 commit comments

Comments
 (0)