Fix update install feedback

Author: rodion-m

AGENTS.md

@@ -8,7 +8,7 @@ This file is for coding agents and maintainers working in this repository. Keep
 
 The macOS engineering skills used by this repository are vendored in `.agents/skills/` and are tracked as project files. When the runtime lists those skills with the `r7` root, expand `r7` to this repository's `.agents/skills` directory. Do not look for these project-local skills under Codex plugin cache paths such as `~/.codex/plugins/cache/openai-primary-runtime`.
 
-Current release metadata: `0.1.4`. This is a pre-stable product; breaking changes to local install state, registry format, CLI UX, and trust policy are acceptable when they improve security or clarity.
+Current release metadata: `0.1.5`. This is a pre-stable product; breaking changes to local install state, registry format, CLI UX, and trust policy are acceptable when they improve security or clarity.
 
 ## Product Boundary
 

Sources/App/Services/AppUpdateInstaller.swift

@@ -1,13 +1,27 @@
 import Foundation
 
+struct AppUpdateProgress: Equatable, Sendable {
+    var step: Int
+    var totalSteps: Int
+    var title: String
+    var detail: String
+
+    var fractionCompleted: Double {
+        guard totalSteps > 0 else { return 0 }
+        return min(max(Double(step) / Double(totalSteps), 0), 1)
+    }
+}
+
+typealias AppUpdateProgressHandler = @MainActor @Sendable (AppUpdateProgress) -> Void
+
 protocol AppUpdateInstalling: Sendable {
-    func install(update: AppUpdateRelease) async throws
+    func install(update: AppUpdateRelease, onProgress: AppUpdateProgressHandler?) async throws
 }
 
 struct SourceArchiveAppUpdateInstaller: AppUpdateInstalling {
     var session: URLSession = .shared
 
-    func install(update: AppUpdateRelease) async throws {
+    func install(update: AppUpdateRelease, onProgress: AppUpdateProgressHandler? = nil) async throws {
         guard let archiveURL = update.sourceArchiveURL else {
             throw AppUpdateInstallError.missingArchive
         }
@@ -21,31 +35,75 @@ struct SourceArchiveAppUpdateInstaller: AppUpdateInstalling {
 
         try fileManager.createDirectory(at: extractDirectory, withIntermediateDirectories: true)
         do {
+            await report(
+                step: 1,
+                title: "Downloading update",
+                detail: "Downloading \(update.displayName) from GitHub.",
+                onProgress: onProgress
+            )
             let (downloadedURL, response) = try await session.download(from: archiveURL)
             if let http = response as? HTTPURLResponse, !(200..<300).contains(http.statusCode) {
                 throw AppUpdateInstallError.downloadHTTPStatus(http.statusCode)
             }
             try fileManager.moveItem(at: downloadedURL, to: archive)
+            await report(
+                step: 2,
+                title: "Unpacking update",
+                detail: "Preparing the downloaded source archive.",
+                onProgress: onProgress
+            )
             try await runProcess(
                 executable: URL(fileURLWithPath: "/usr/bin/ditto"),
                 arguments: ["-x", "-k", archive.path, extractDirectory.path],
                 currentDirectory: nil,
                 logURL: logURL
             )
             let sourceRoot = try findSourceRoot(in: extractDirectory)
+            await report(
+                step: 3,
+                title: "Verifying update",
+                detail: "Checking that the archive matches version \(update.versionLabel).",
+                onProgress: onProgress
+            )
             try validateVersion(update: update, sourceRoot: sourceRoot)
+            await report(
+                step: 4,
+                title: "Installing local build",
+                detail: "Running scripts/install_local.sh --load. The app may reopen when this finishes.",
+                onProgress: onProgress
+            )
             try await runProcess(
                 executable: sourceRoot.appendingPathComponent("scripts/install_local.sh"),
                 arguments: ["--load", "--cleanup-path", workDirectory.path],
                 currentDirectory: sourceRoot,
                 logURL: logURL
             )
+            await report(
+                step: 5,
+                title: "Cleaning up",
+                detail: "Removing the temporary downloaded files.",
+                onProgress: onProgress
+            )
             try? fileManager.removeItem(at: workDirectory)
         } catch {
             throw AppUpdateInstallError.failed(error, logURL: logURL)
         }
     }
 
+    private func report(
+        step: Int,
+        title: String,
+        detail: String,
+        onProgress: AppUpdateProgressHandler?
+    ) async {
+        await onProgress?(AppUpdateProgress(
+            step: step,
+            totalSteps: 5,
+            title: title,
+            detail: detail
+        ))
+    }
+
     private func findSourceRoot(in directory: URL) throws -> URL {
         let fileManager = FileManager.default
         let contents = try fileManager.contentsOfDirectory(

Sources/App/Services/UISmokeRunner.swift

@@ -1058,6 +1058,7 @@ enum UISmokeRunner {
         try expect(store.successMessage == "Agentic Secrets 9.0.0 is available", "manual update check reports available release")
         await store.installUpdate(latest)
         try expect(store.availableUpdate == nil, "successful update install clears available release")
+        try expect(store.updateInstallProgress == nil, "successful update install clears progress feedback")
         try expect(store.successMessage == "Agentic Secrets 9.0.0 installed", "successful update install reports installed release")
         store.availableUpdate = latest
         try verifyHostingLayout(
@@ -1550,7 +1551,14 @@ private struct StubAppUpdateChecker: AppUpdateChecking {
 }
 
 private struct StubAppUpdateInstaller: AppUpdateInstalling {
-    func install(update: AppUpdateRelease) async throws {}
+    func install(update: AppUpdateRelease, onProgress: AppUpdateProgressHandler?) async throws {
+        await onProgress?(AppUpdateProgress(
+            step: 1,
+            totalSteps: 1,
+            title: "Installing local build",
+            detail: "Running synthetic update installer."
+        ))
+    }
 }
 
 private enum UISmokeRunnerSnapshotFactory {

Sources/App/Stores/ControlPlaneStore.swift

@@ -132,6 +132,7 @@ final class ControlPlaneStore {
     var availableUpdate: AppUpdateRelease?
     var isCheckingForUpdates = false
     var isInstallingUpdate = false
+    var updateInstallProgress: AppUpdateProgress?
     var lastUpdateCheck: Date?
 
     private let client: any ControlPlaneClient
@@ -374,6 +375,9 @@ final class ControlPlaneStore {
     func clearFeedback() {
         errorMessage = nil
         successMessage = nil
+        if !isInstallingUpdate {
+            updateInstallProgress = nil
+        }
     }
 
     func clearSuccessIfCurrent(_ message: String) {
@@ -434,16 +438,30 @@ final class ControlPlaneStore {
     func installUpdate(_ update: AppUpdateRelease) async {
         guard !isInstallingUpdate else { return }
         isInstallingUpdate = true
-        successMessage = "Installing \(update.displayName)"
+        updateInstallProgress = AppUpdateProgress(
+            step: 0,
+            totalSteps: 5,
+            title: "Starting update",
+            detail: "Preparing to install \(update.displayName)."
+        )
+        successMessage = nil
         errorMessage = nil
-        defer { isInstallingUpdate = false }
+        defer {
+            isInstallingUpdate = false
+        }
         do {
-            try await updateInstaller.install(update: update)
+            try await updateInstaller.install(update: update) { [weak self] progress in
+                self?.updateInstallProgress = progress
+                self?.successMessage = nil
+                self?.errorMessage = nil
+            }
             availableUpdate = nil
+            updateInstallProgress = nil
             successMessage = "\(update.displayName) installed"
             errorMessage = nil
             await refresh()
         } catch {
+            updateInstallProgress = nil
             successMessage = nil
             errorMessage = "Could not install update: \(userFacingError(error))"
         }

Sources/App/Views/ContentView.swift

@@ -307,7 +307,9 @@ private struct SidebarReleaseFooter: View {
                 .font(.caption2)
                 .foregroundStyle(.secondary)
                 .lineLimit(1)
-            if let update = store.availableUpdate {
+            if let progress = store.updateInstallProgress {
+                SidebarUpdateProgress(progress: progress)
+            } else if let update = store.availableUpdate {
                 SidebarUpdateButton(store: store, update: update)
             } else {
                 HStack(spacing: 8) {
@@ -371,6 +373,33 @@ private struct SidebarUpdateButton: View {
     }
 }
 
+private struct SidebarUpdateProgress: View {
+    var progress: AppUpdateProgress
+
+    var body: some View {
+        VStack(alignment: .leading, spacing: 5) {
+            HStack(spacing: 6) {
+                ProgressView(value: progress.fractionCompleted)
+                    .frame(maxWidth: 74)
+                Text("\(progress.step)/\(progress.totalSteps)")
+                    .font(.caption2.monospacedDigit())
+                    .foregroundStyle(.secondary)
+            }
+            Text(progress.title)
+                .font(.caption.weight(.semibold))
+                .lineLimit(1)
+            Text(progress.detail)
+                .font(.caption2)
+                .foregroundStyle(.secondary)
+                .lineLimit(2)
+        }
+        .padding(.top, 2)
+        .accessibilityElement(children: .combine)
+        .accessibilityLabel("Installing update, step \(progress.step) of \(progress.totalSteps), \(progress.title)")
+        .accessibilityValue(progress.detail)
+    }
+}
+
 private struct SidebarTextLink: View {
     var store: ControlPlaneStore
     var title: String
@@ -490,6 +519,9 @@ struct DetailView: View {
                         .padding(10)
                         .background(.regularMaterial, in: RoundedRectangle(cornerRadius: 8))
                 }
+                if let progress = store.updateInstallProgress {
+                    UpdateProgressBanner(progress: progress)
+                }
                 if store.successMessage != nil || store.errorMessage != nil {
                     FeedbackBanner(store: store)
                 }
@@ -499,6 +531,38 @@ struct DetailView: View {
     }
 }
 
+private struct UpdateProgressBanner: View {
+    var progress: AppUpdateProgress
+
+    var body: some View {
+        VStack(alignment: .leading, spacing: 7) {
+            HStack(spacing: 10) {
+                ProgressView()
+                    .controlSize(.small)
+                    .accessibilityHidden(true)
+                Text(progress.title)
+                    .font(.callout.weight(.semibold))
+                Spacer(minLength: 12)
+                Text("Step \(progress.step) of \(progress.totalSteps)")
+                    .font(.caption.monospacedDigit())
+                    .foregroundStyle(.secondary)
+            }
+            ProgressView(value: progress.fractionCompleted)
+            Text(progress.detail)
+                .font(.caption)
+                .foregroundStyle(.secondary)
+                .fixedSize(horizontal: false, vertical: true)
+        }
+        .padding(.horizontal, 12)
+        .padding(.vertical, 10)
+        .frame(maxWidth: 520, alignment: .leading)
+        .background(.regularMaterial, in: RoundedRectangle(cornerRadius: 8))
+        .accessibilityElement(children: .combine)
+        .accessibilityLabel("Installing update, \(progress.title)")
+        .accessibilityValue("Step \(progress.step) of \(progress.totalSteps). \(progress.detail)")
+    }
+}
+
 private struct FeedbackBanner: View {
     @Bindable var store: ControlPlaneStore
 

Sources/CommandShim/main.swift

@@ -71,8 +71,10 @@ struct AgenticSecretsCommandShim {
 
     private static func runIPCHealth(_ args: [String]) throws {
         let socket = try requiredValue(after: "--socket", in: args)
-        _ = try requiredValue(after: "--manifest", in: args)
-        let version = value(after: "--version", in: args) ?? bundleShortVersion()
+        let manifestPath = try requiredValue(after: "--manifest", in: args)
+        let version = value(after: "--version", in: args)
+            ?? versionFromInstallManifest(path: manifestPath)
+            ?? bundleShortVersion()
         let path = CommandLine.arguments.first ?? "agentic-secrets-shim"
         let peer = try SelfBuildPeerValidator.identity(helperName: "agentic-secrets-shim", path: path, version: version)
         let request = BrokerIPCRequest(requestID: "req_" + shortDigest(UUID().uuidString, length: 12), operation: .health, peer: peer)
@@ -96,7 +98,14 @@ struct AgenticSecretsCommandShim {
 
     private static func bundleShortVersion() -> String {
         let version = Bundle.main.object(forInfoDictionaryKey: "CFBundleShortVersionString") as? String
-        return version?.isEmpty == false ? version! : "0.1.3"
+        return version?.isEmpty == false ? version! : "0.1.5"
+    }
+
+    private static func versionFromInstallManifest(path: String) -> String? {
+        guard let manifest = try? InstallManifestStore.load(path: path) else {
+            return nil
+        }
+        return manifest.requirement(for: "agentic-secrets-shim")?.minimumVersion
     }
 
     private static func coreDaemonPath() throws -> String {

version.env

@@ -2,7 +2,7 @@ APP_NAME=AgenticSecrets
 APP_DISPLAY_NAME="Agentic Secrets"
 APP_EXECUTABLE_NAME=AgenticSecrets
 BUNDLE_ID=com.agenticsecrets.AgenticSecrets
-MARKETING_VERSION=0.1.4
+MARKETING_VERSION=0.1.5
 RELEASE_CHANNEL=
-BUILD_NUMBER=6
+BUILD_NUMBER=7
 MENU_BAR_APP=0