Restart app after self-build updates

Author: rodion-m

AGENTS.md

@@ -8,7 +8,7 @@ This file is for coding agents and maintainers working in this repository. Keep
 
 The macOS engineering skills used by this repository are vendored in `.agents/skills/` and are tracked as project files. When the runtime lists those skills with the `r7` root, expand `r7` to this repository's `.agents/skills` directory. Do not look for these project-local skills under Codex plugin cache paths such as `~/.codex/plugins/cache/openai-primary-runtime`.
 
-Current release metadata: `0.1.5`. This is a pre-stable product; breaking changes to local install state, registry format, CLI UX, and trust policy are acceptable when they improve security or clarity.
+Current release metadata: `0.1.6`. This is a pre-stable product; breaking changes to local install state, registry format, CLI UX, and trust policy are acceptable when they improve security or clarity.
 
 ## Product Boundary
 

Sources/App/Services/AppUpdateInstaller.swift

@@ -69,12 +69,12 @@ struct SourceArchiveAppUpdateInstaller: AppUpdateInstalling {
             await report(
                 step: 4,
                 title: "Installing local build",
-                detail: "Running scripts/install_local.sh --load. The app may reopen when this finishes.",
+                detail: "Running scripts/install_local.sh --load. Agentic Secrets will restart after this finishes.",
                 onProgress: onProgress
             )
             try await runProcess(
                 executable: sourceRoot.appendingPathComponent("scripts/install_local.sh"),
-                arguments: ["--load", "--cleanup-path", workDirectory.path],
+                arguments: ["--load", "--no-open", "--cleanup-path", workDirectory.path],
                 currentDirectory: sourceRoot,
                 logURL: logURL
             )
@@ -98,7 +98,7 @@ struct SourceArchiveAppUpdateInstaller: AppUpdateInstalling {
     ) async {
         await onProgress?(AppUpdateProgress(
             step: step,
-            totalSteps: 5,
+            totalSteps: 6,
             title: title,
             detail: detail
         ))

Sources/App/Services/UISmokeRunner.swift

@@ -1044,11 +1044,13 @@ enum UISmokeRunner {
         let ignoredDefaultsSuite = "com.agenticsecrets.ui-smoke.updater.\(UUID().uuidString)"
         let ignoredDefaults = UserDefaults(suiteName: ignoredDefaultsSuite)!
         ignoredDefaults.removePersistentDomain(forName: ignoredDefaultsSuite)
+        let relauncher = StubAppUpdateRelauncher()
         let store = ControlPlaneStore(
             client: SequenceControlPlaneClient(snapshots: [emptySnapshot()]),
             brokerController: StubBrokerStatusController(statusValue: healthyBrokerStatus()),
             updateChecker: StubAppUpdateChecker(update: latest),
             updateInstaller: StubAppUpdateInstaller(),
+            updateRelauncher: relauncher,
             updateIgnoreDefaults: ignoredDefaults
         )
         await store.refresh()
@@ -1058,8 +1060,9 @@ enum UISmokeRunner {
         try expect(store.successMessage == "Agentic Secrets 9.0.0 is available", "manual update check reports available release")
         await store.installUpdate(latest)
         try expect(store.availableUpdate == nil, "successful update install clears available release")
-        try expect(store.updateInstallProgress == nil, "successful update install clears progress feedback")
-        try expect(store.successMessage == "Agentic Secrets 9.0.0 installed", "successful update install reports installed release")
+        try expect(store.updateInstallProgress?.title == "Restarting app", "successful update install moves to relaunch feedback")
+        try expect(store.successMessage == nil, "successful update install does not show stale success in the old app process")
+        try expect(relauncher.scheduledAppURL != nil && relauncher.terminateCalled, "successful update install schedules relaunch and terminates old app")
         store.availableUpdate = latest
         try verifyHostingLayout(
             DetailView(store: store),
@@ -1554,13 +1557,27 @@ private struct StubAppUpdateInstaller: AppUpdateInstalling {
     func install(update: AppUpdateRelease, onProgress: AppUpdateProgressHandler?) async throws {
         await onProgress?(AppUpdateProgress(
             step: 1,
-            totalSteps: 1,
+            totalSteps: 6,
             title: "Installing local build",
             detail: "Running synthetic update installer."
         ))
     }
 }
 
+@MainActor
+private final class StubAppUpdateRelauncher: AppUpdateRelaunching {
+    private(set) var scheduledAppURL: URL?
+    private(set) var terminateCalled = false
+
+    func scheduleRelaunch(appURL: URL) throws {
+        scheduledAppURL = appURL
+    }
+
+    func terminateCurrentApp() {
+        terminateCalled = true
+    }
+}
+
 private enum UISmokeRunnerSnapshotFactory {
     static func empty() -> ControlPlaneSnapshot {
         ControlPlaneSnapshot(

Sources/App/Stores/ControlPlaneStore.swift

@@ -139,6 +139,7 @@ final class ControlPlaneStore {
     private let brokerController: any BrokerStatusControlling
     private let updateChecker: any AppUpdateChecking
     private let updateInstaller: any AppUpdateInstalling
+    private let updateRelauncher: any AppUpdateRelaunching
     private let updateIgnoreDefaults: UserDefaults
     private static let snapshotLoadRetryDelays: [Duration] = [
         .milliseconds(120),
@@ -152,12 +153,14 @@ final class ControlPlaneStore {
         brokerController: (any BrokerStatusControlling)? = nil,
         updateChecker: any AppUpdateChecking = GitHubAppUpdateChecker(),
         updateInstaller: any AppUpdateInstalling = SourceArchiveAppUpdateInstaller(),
+        updateRelauncher: any AppUpdateRelaunching = ProcessAppUpdateRelauncher(),
         updateIgnoreDefaults: UserDefaults = UserDefaults(suiteName: "com.agenticsecrets.updater.ignorelist") ?? .standard
     ) {
         self.client = client
         self.brokerController = brokerController ?? LocalBrokerStatusController(client: client)
         self.updateChecker = updateChecker
         self.updateInstaller = updateInstaller
+        self.updateRelauncher = updateRelauncher
         self.updateIgnoreDefaults = updateIgnoreDefaults
     }
 
@@ -440,7 +443,7 @@ final class ControlPlaneStore {
         isInstallingUpdate = true
         updateInstallProgress = AppUpdateProgress(
             step: 0,
-            totalSteps: 5,
+            totalSteps: 6,
             title: "Starting update",
             detail: "Preparing to install \(update.displayName)."
         )
@@ -456,17 +459,37 @@ final class ControlPlaneStore {
                 self?.errorMessage = nil
             }
             availableUpdate = nil
-            updateInstallProgress = nil
-            successMessage = "\(update.displayName) installed"
-            errorMessage = nil
-            await refresh()
+            updateInstallProgress = AppUpdateProgress(
+                step: 6,
+                totalSteps: 6,
+                title: "Restarting app",
+                detail: "Opening the updated Agentic Secrets app bundle."
+            )
+            do {
+                try updateRelauncher.scheduleRelaunch(appURL: installedAppURLForUpdateRestart())
+                updateRelauncher.terminateCurrentApp()
+                return
+            } catch {
+                updateInstallProgress = nil
+                successMessage = "\(update.displayName) installed. Quit and reopen Agentic Secrets to finish."
+                errorMessage = "Could not restart Agentic Secrets automatically: \(userFacingError(error))"
+                await refresh()
+            }
         } catch {
             updateInstallProgress = nil
             successMessage = nil
             errorMessage = "Could not install update: \(userFacingError(error))"
         }
     }
 
+    private func installedAppURLForUpdateRestart() -> URL {
+        if let path = brokerInstallPlan?.appDestinationPath {
+            return URL(fileURLWithPath: path, isDirectory: true)
+        }
+        let defaultPath = NSHomeDirectory() + "/Applications/AgenticSecrets.app"
+        return URL(fileURLWithPath: defaultPath, isDirectory: true)
+    }
+
     func refresh() async {
         isLoading = true
         defer { isLoading = false }

Sources/App/Support/AppUpdateRelauncher.swift

@@ -0,0 +1,47 @@
+import AppKit
+import Foundation
+
+@MainActor
+protocol AppUpdateRelaunching {
+    func scheduleRelaunch(appURL: URL) throws
+    func terminateCurrentApp()
+}
+
+struct ProcessAppUpdateRelauncher: AppUpdateRelaunching {
+    func scheduleRelaunch(appURL: URL) throws {
+        let script = """
+        pid="$1"
+        app="$2"
+        for _ in 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15; do
+          kill -0 "$pid" 2>/dev/null || break
+          sleep 0.2
+        done
+        if kill -0 "$pid" 2>/dev/null; then
+          kill -TERM "$pid" 2>/dev/null || true
+        fi
+        for _ in 1 2 3 4 5 6 7 8 9 10; do
+          kill -0 "$pid" 2>/dev/null || break
+          sleep 0.2
+        done
+        if kill -0 "$pid" 2>/dev/null; then
+          kill -KILL "$pid" 2>/dev/null || true
+        fi
+        /usr/bin/open -n "$app"
+        """
+
+        let process = Process()
+        process.executableURL = URL(fileURLWithPath: "/bin/sh")
+        process.arguments = [
+            "-c",
+            script,
+            "agentic-secrets-relaunch",
+            String(ProcessInfo.processInfo.processIdentifier),
+            appURL.path
+        ]
+        try process.run()
+    }
+
+    func terminateCurrentApp() {
+        NSApp.terminate(nil)
+    }
+}

Sources/App/Support/UpdatePromptPresenter.swift

@@ -11,7 +11,7 @@ enum UpdatePromptPresenter {
     static func prompt(for update: AppUpdateRelease) -> Action {
         let alert = NSAlert()
         alert.messageText = "\(update.displayName) is available"
-        alert.informativeText = "Review the release notes or install the update now. Agentic Secrets will download the release source to a temporary folder, run the local installer, reopen the installed app, and clean up the download after a successful install."
+        alert.informativeText = "Review the release notes or install the update now. Agentic Secrets will download the release source to a temporary folder, run the local installer, restart from the updated app bundle, and clean up the download after a successful install."
         alert.alertStyle = update.critical ? .critical : .informational
         alert.addButton(withTitle: "Update Now")
         alert.addButton(withTitle: "Open Release Page")

version.env

@@ -2,7 +2,7 @@ APP_NAME=AgenticSecrets
 APP_DISPLAY_NAME="Agentic Secrets"
 APP_EXECUTABLE_NAME=AgenticSecrets
 BUNDLE_ID=com.agenticsecrets.AgenticSecrets
-MARKETING_VERSION=0.1.5
+MARKETING_VERSION=0.1.6
 RELEASE_CHANNEL=
-BUILD_NUMBER=7
+BUILD_NUMBER=8
 MENU_BAR_APP=0