Apply CodeAnt review fixes for PR #13

- Fix NaN sort comparator in listRepos when pushed_at is missing
- Preserve multi-line file_line_range in fetchAdvancedScanResults
- Add item.check_name to dead-code normalization fallback chain
- Fix confidence_score type error with String() coercion before toLowerCase
- Strip all scan-result suffixes in fetchDismissedAlerts (not just security_issues)
- Add optional chaining on dismissInfo to prevent null crash
- Fall back to input repo param when backend omits it in getScanHistory
- Add dismissed-finding display fallbacks in ScanCenter
- Use full_name || name fallback in handleSelectRepo to avoid undefined API call
- Gate debug stderr logging behind CODEANT_DEBUG_SCAN_HISTORY=1
- Guard paginate offset/limit against NaN with Number.isFinite
- Fix dismissMatch line-number comparison with null check and Number() coercion

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: pranavcodeant

src/commands/scans/lib/dismissMatch.js

@@ -20,7 +20,7 @@ export function findDismissMatch(finding, dismissedAlerts) {
     if (d.test_id && finding.check_id && d.test_id !== finding.check_id) continue;
 
     // Line number match when available (secrets format uses line_number as part1)
-    if (d.line_number && finding.line_number && d.line_number !== finding.line_number) continue;
+    if (d.line_number != null && finding.line_number != null && Number(d.line_number) !== Number(finding.line_number)) continue;
 
     return d;
   }

src/commands/scans/lib/paginate.js

@@ -6,8 +6,8 @@
  */
 export function paginate(findings, { limit = 100, offset = 0 } = {}) {
   const total = findings.length;
-  const safeOffset = Math.max(0, offset);
-  const safeLimit = limit > 0 ? limit : total;
+  const safeOffset = Number.isFinite(offset) ? Math.max(0, Math.trunc(offset)) : 0;
+  const safeLimit = Number.isFinite(limit) && limit > 0 ? Math.trunc(limit) : 100;
   const items = findings.slice(safeOffset, safeOffset + safeLimit);
   return {
     items,

src/components/ScanCenter.js

@@ -112,7 +112,7 @@ function ResultsView({ issues, resultTypeLabel, breadcrumbParts, onBack }) {
             ce(Text, { color: 'gray' },
               (issue.file_path || 'unknown') + (issue.line_number ? `:${issue.line_number}` : '')),
             ce(Text, null,
-              issue.check_name || issue.issue_text || issue.message || '')
+              issue.check_name || issue.issue_text || issue.message || issue.test_id || issue.type || issue.reason_for_dismiss || 'Dismissed finding')
           )
         ),
       ];

src/scanCenter/handleSelectRepo.js

@@ -3,14 +3,17 @@ import { getScanHistory } from '../scans/getScanHistory.js';
 export async function handleSelectRepo({ STEPS, item, setSelectedRepo, setStep, setLoadingMsg, setError, setScanHistory }) {
   setSelectedRepo(item.value);
   setStep(STEPS.LOADING);
-  setLoadingMsg(`Loading scan history for ${item.value.full_name}…`);
-  const res = await getScanHistory(item.value.full_name);
+  const repoFullName = item.value.full_name || item.value.name;
+  setLoadingMsg(`Loading scan history for ${repoFullName}…`);
+  const res = await getScanHistory(repoFullName);
   if (!res.success) {
     setError(res.error || 'Failed to fetch scan history', STEPS.SELECT_REPO);
     return;
   }
   const history = res.scanHistory || [];
-  process.stderr.write('SCAN_HISTORY_SAMPLE: ' + JSON.stringify(history.slice(0, 15), null, 2) + '\n');
+  if (process.env.CODEANT_DEBUG_SCAN_HISTORY === '1') {
+    process.stderr.write('SCAN_HISTORY_SAMPLE: ' + JSON.stringify(history.slice(0, 15), null, 2) + '\n');
+  }
   setScanHistory(history);
   setStep(STEPS.SELECT_SCAN);
 }

src/scans/fetchAdvancedScanResults.js

@@ -152,7 +152,10 @@ function normalizeAdvancedIssue(item, resultType) {
   const normalized = { ...item };
   normalized.file_path = extractRelativeFilePath(item.file_path || item.path || item.filename || 'unknown');
   normalized.line_number = item.line_number || item.start_line || item.line || 1;
-  normalized.file_line_range = [normalized.line_number];
+  normalized.file_line_range =
+    Array.isArray(item.file_line_range) && item.file_line_range.length > 0
+      ? item.file_line_range
+      : [normalized.line_number];
 
   switch (resultType) {
     case ADVANCED_RESULT_TYPES.SCA:
@@ -181,7 +184,7 @@ function normalizeAdvancedIssue(item, resultType) {
       break;
     case ADVANCED_RESULT_TYPES.DEAD_CODE:
       normalized.check_name =
-        item.name || item.function_name || item.symbol_name || item.description || 'Unused code detected';
+        item.check_name || item.name || item.function_name || item.symbol_name || item.description || 'Unused code detected';
       normalized.severity = item.severity || 'low';
       break;
     default:
@@ -293,7 +296,7 @@ export async function fetchAdvancedScanResults(repo, commitId, resultType) {
 
     // Filter secrets false positives
     if (resultType === ADVANCED_RESULT_TYPES.SECRETS) {
-      issues = issues.filter((issue) => issue.confidence_score?.toLowerCase() !== 'false_positive');
+      issues = issues.filter((issue) => String(issue.confidence_score || '').toLowerCase() !== 'false_positive');
     }
 
     if (resultType === ADVANCED_RESULT_TYPES.SCA) {

src/scans/fetchDismissedAlerts.js

@@ -36,9 +36,7 @@ export async function fetchDismissedAlerts(repo, analysisType = 'security') {
       const part1 = parts[1] || '';
       const part2 = parts[2] || '';
 
-      if (file_path.endsWith('/security_issues.json')) {
-        file_path = file_path.replace('/security_issues.json', '');
-      }
+      file_path = file_path.replace(/\/(security_issues|anti_patterns|docstring|complex_functions)\.json$/, '');
 
       dismissedAlerts.push({
         file_path,
@@ -47,8 +45,8 @@ export async function fetchDismissedAlerts(repo, analysisType = 'security') {
         line_number: parseInt(part1, 10) || 0,
         type: part2,
         issue_key: issueKey,
-        reason_for_dismiss: dismissInfo.reason_for_dismiss || '',
-        comment_for_dismiss: dismissInfo.comment_for_dismiss || '',
+        reason_for_dismiss: dismissInfo?.reason_for_dismiss || '',
+        comment_for_dismiss: dismissInfo?.comment_for_dismiss || '',
       });
     }
 

src/scans/getScanHistory.js

@@ -22,7 +22,7 @@ export async function getScanHistory(repo) {
     if (response.last_analysis_results !== undefined) {
       return {
         success: true,
-        repo: response.repo,
+        repo: response.repo || repo,
         scanHistory: response.last_analysis_results || [],
       };
     }

src/scans/listRepos.js

@@ -22,7 +22,7 @@ export async function listRepos(organizationName) {
 
     if (response.repos) {
       const sortedRepos = (response.repos || []).sort(
-        (a, b) => new Date(b.pushed_at) - new Date(a.pushed_at)
+        (a, b) => (Date.parse(b.pushed_at) || 0) - (Date.parse(a.pushed_at) || 0)
       );
       return { success: true, repos: sortedRepos };
     }