Skip to content

Commit c309449

Browse files
committed
Fix copy-paste bug, wrong comparison, and async void safety
1 parent 3eb498f commit c309449

4 files changed

Lines changed: 137 additions & 4 deletions

File tree

.codeboarding/.codeboardingignore

Lines changed: 130 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,130 @@
1+
# CodeBoarding Ignore File
2+
# Add patterns here for files and directories that should be excluded from CodeBoarding analysis.
3+
# Use the same format as .gitignore (gitignore syntax / gitwildmatch patterns).
4+
#
5+
# To stop ignoring a pattern, prefix it with ! (e.g., !important_file.txt)
6+
#
7+
# NOTE: The following are ALWAYS excluded (not configurable):
8+
# - Hidden directories (starting with .)
9+
# - .git/, .codeboarding/, node_modules/, __pycache__/
10+
# - Build output: build/, dist/, coverage/
11+
#
12+
# This file is automatically loaded by CodeBoarding analysis tools to exclude
13+
# specified paths from code analysis, architecture generation, and other processing.
14+
15+
# ============================================================================
16+
# Ignored directories (customizable — remove lines to include them)
17+
# ============================================================================
18+
19+
# Python virtual environments
20+
venv/
21+
env/
22+
*.egg-info/
23+
24+
# Java (Maven/Gradle) and Rust (Cargo) build output. Both ecosystems
25+
# produce a top-level ``target/`` directory full of compiled artifacts —
26+
# kept here as well as in ``_ALWAYS_IGNORED_DIRS`` so users who customize
27+
# their ``.codeboardingignore`` continue to skip it even after edits.
28+
target/
29+
bin/
30+
out/
31+
32+
# .NET / C# build output
33+
obj/
34+
35+
# Go
36+
vendor/
37+
testdata/
38+
39+
# PHP
40+
cache/
41+
42+
# Custom
43+
temp/
44+
repos/
45+
runs/
46+
47+
# ============================================================================
48+
# Test and infrastructure files
49+
# ============================================================================
50+
51+
# Test directories
52+
**/__tests__/**
53+
**/tests/**
54+
**/test/**
55+
**/__test__/**
56+
**/testing/**
57+
**/testutil/**
58+
59+
# Java/Kotlin test directories (Maven/Gradle structure)
60+
**/src/test/**
61+
**/src/testFixtures/**
62+
**/src/integration-test/**
63+
**/src/jmh/**
64+
**/src/contractTest/**
65+
**/osgi-tests/**
66+
67+
# Test files by naming convention
68+
*.test.*
69+
*.spec.*
70+
*_test.*
71+
*test_*.py
72+
test_*.py
73+
*Test.java
74+
*IT.java
75+
*Test.kt
76+
*IT.kt
77+
*Tests.java
78+
79+
# Mock, fixture, and stub directories
80+
**/__mocks__/**
81+
**/mocks/**
82+
**/fixtures/**
83+
**/fixture/**
84+
**/stubs/**
85+
**/stub/**
86+
**/fakes/**
87+
**/fake/**
88+
89+
# E2E and integration test directories
90+
**/e2e/**
91+
**/integration-tests/**
92+
**/integration_test*/**
93+
94+
# ============================================================================
95+
# Non-production code
96+
# ============================================================================
97+
98+
# Example and documentation code
99+
**/examples/**
100+
**/documentation/examples/**
101+
102+
# Generated code
103+
*.pb.go
104+
**/generated_parser*
105+
106+
# Java/Kotlin metadata files
107+
module-info.java
108+
109+
# ============================================================================
110+
# Build artifacts and minified files
111+
# ============================================================================
112+
113+
*.bundle.js
114+
*.bundle.js.map
115+
*.min.js
116+
*.min.css
117+
*.chunk.js
118+
*.chunk.js.map
119+
120+
# ============================================================================
121+
# Build tool configs and infrastructure
122+
# ============================================================================
123+
124+
esbuild*
125+
webpack*
126+
rollup*
127+
vite.config.*
128+
gulpfile*
129+
gruntfile*
130+
*.config.*

Bloxstrap/Bootstrapper.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1222,7 +1222,7 @@ private async Task UpgradeRoblox()
12221222

12231223
AppData.DistributionState.Size = distributionSize;
12241224

1225-
int totalSize = App.PlayerState.Prop.Size + App.PlayerState.Prop.Size;
1225+
int totalSize = App.PlayerState.Prop.Size + App.StudioState.Prop.Size;
12261226

12271227
using (var uninstallKey = Registry.CurrentUser.CreateSubKey(App.UninstallKey))
12281228
{

Bloxstrap/FastFlagManager.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ public void SetValue(string key, object? value)
6060
{
6161
if (Prop.ContainsKey(key))
6262
{
63-
if (key == Prop[key].ToString())
63+
if (value.ToString() == Prop[key].ToString())
6464
return;
6565

6666
App.Logger.WriteLine(LOG_IDENT, $"Changing of '{key}' from '{Prop[key]}' to '{value}' is pending");

Bloxstrap/Logger.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,11 @@ private async void WriteToLog(string message)
136136
{
137137
await _semaphore.WaitAsync();
138138
await _filestream!.WriteAsync(Encoding.UTF8.GetBytes($"{message}\r\n"));
139-
140-
_ = _filestream.FlushAsync();
139+
await _filestream.FlushAsync();
140+
}
141+
catch (Exception ex)
142+
{
143+
System.Diagnostics.Debug.WriteLine($"WriteToLog failed: {ex.Message}");
141144
}
142145
finally
143146
{

0 commit comments

Comments
 (0)