Skip to content

keepalive and reconnects #8

Description

@wmertens
  1. It leaks, because of the keepalive setInterval never being cancelled on socket close
  2. Why is the keepalive needed?
  3. Why do you close the subscription when the socket closes? When the browser reconnects, the subscription won't exist any more
  4. Perhaps the client should send a random token and that gets used for all subsequent connections, so that multiple subscription calls all happen on the same SSE stream
  5. Perhaps the subscribed queries should be stored with that client token, and then unsub all on connection drop + re-subscribe when the connection is re-established
  6. Or maybe the client needs to store all active queries, and when the SSE drops close it, and re-subscribe all

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions