[prestoncabe]

Follow-up to #586 (part of #585), from a /code-review of that PR.

Summary

Loading during the wait. An edit outdates the evaluation in flight. Until now loading stayed true through the 500ms wait, although the session's interface says it is true "only while the latest answers are being evaluated, not while waiting to send them".

 on form-js "changed"
   latestEvaluation++
   setStale(true)
+  setLoading(false)      // nothing is evaluating the new answers yet
   debouncedSubmit(answers)

In Preview, the Results panel keeps showing the last results without a loading state until the new evaluation actually starts.

Test helpers (src/testing/formJs.ts):

-export const settle = () => new Promise((resolve) => setTimeout(resolve, 100));
-export function type(label, value) { … }
+export function answer(label, value) { … }   // input + focusout

• settle() was a fixed 100ms sleep meant to outlast form-js's redraw about 60ms after an import. On a slow runner the redraw could land later and make tests flaky. The focusout that answer() already sends hands the answer to form-js at once, so the redraw keeps it and no wait is needed.
• type read like TypeScript's inline type-import keyword in import { …, type, until }.

Leftovers from #586:

• NextStepsProvider is deleted; nothing used it once the session started projecting next steps.
• Preview's Results types its answers as ScreeningAnswers. The two duplicate PreviewFormData declarations and preview/types.ts are removed.
• screenerName is destructured with the session's other options.
• The type-check baseline drops the entry for the deleted preview FormRenderer (151 → 150).

Evidence

• Before: no test checked loading after an edit while an evaluation was in flight.
  After: screeningSession.test.tsx, "outdates an evaluation in flight as soon as an answer changes":

  answer("Answer", "first")  -> evaluate called, loading() === true
  answer("Answer", "second") -> loading() === false
  older evaluation resolves  -> results() undefined, loading() === false
  

• To justify removing settle(), I ran a throwaway test 5 times. It typed into a form-js textfield right after importSchema, sent focusout, and checked 200ms later. Both the form state and the input kept "typed" every time. The session, Screener and Preview tests then passed 3 runs in a row with no wait.
• devbox run test -- builder-frontend, run on each commit:

  Tests  389 passed (389)
  All matched files use Prettier code style!
  Type check passed: 150 type errors, none beyond the baseline.
  

Merge Danger

Door: two-way

Small, and reverts cleanly.

Blast Radius: Preview results

The only runtime change is that Preview's Results panel doesn't show loading between an edit and the evaluation it triggers. Published screeners don't read loading.

🤖 Generated with Claude Code