You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 4536eaa
Browse filesBrowse the repository at this point in the historyBrowse files
fix(api): build SAML entityID and SSO endpoints from our own settings
getSamlContext derived the IdP entity ID and both SingleSignOnService
Locations from SLACK_TEAM_HOST, so the live metadata advertised
https://codeforphilly.slack.com/api/saml/slack/... — Slack's host, not
ours. Per specs/api/saml.md#idp-identity-and-hosts:
- entityId (metadata entityID + assertion Issuer, one value flowing
through SlackSamlEntities.entityId → issuerEntityId) now comes from the
new SAML_ENTITY_ID env var, defaulting to
https://codeforphilly.org/api/saml/slack/metadata. It is a stable
logical identifier and intentionally does not follow CFP_SITE_HOST, so
the next.codeforphilly.org → codeforphilly.org flip at cutover leaves
the issuer Slack stored at setup untouched.
- ssoLoginPostUrl / ssoLoginRedirectUrl are built on CFP_SITE_HOST so
the metadata points Slack at the host actually serving the API.
- SLACK_TEAM_HOST keeps only its Slack-side roles (ACS URL, NameID
NameQualifier, launch redirect).
Tests assert the default entityID, the CFP_SITE_HOST-driven Locations,
Issuer == entityID on both Response and Assertion, that
CFP_SITE_HOST=next.example.org moves the Locations without moving the
entityID, and that an explicit SAML_ENTITY_ID flows to both.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RdRwHvDupRLV8GuJpYKzEr
0 commit comments