Merge pull request #226 from CodeForPhilly/chore/close-sheet-contracts

chore(plans): close out the gitsheets adoption plans

Author: themightychris

plans/person-evaluations-contract.md

@@ -1,5 +1,5 @@
 ---
-status: in-progress
+status: done
 depends: [gitsheets-freshness]
 specs:
   - specs/behaviors/spam-exclusion.md
@@ -43,11 +43,11 @@ path templates, so they would not have caught the slug-history bug.
 
 ## Validation
 
-- [ ] Contract present on all data-repo branches; `git sheet contracts
+- [x] Contract present on all data-repo branches; `git sheet contracts
       verify` clean
 - [x] cfp boot fails with a clear error against a deliberately drifted
       config (test)
-- [ ] Spam pipeline opens against the contract
+- [x] Spam pipeline opens against the contract
 - [x] `type-check` + `lint` + full api suite green
 
 ## Risks / unknowns
@@ -70,4 +70,15 @@ path templates, so they would not have caught the slug-history bug.
 - The contract keeps the old sheet-local schema's exact constraints, adding
   only `$id`, `title` and `description` annotations.
 
+- Superseded in scope by [`sheet-contracts`](sheet-contracts.md), which
+  generalized this to every sheet with this repo as the publisher. The
+  hand-authored `v1` was published as `contracts/…/person-evaluations/v1.json`
+  and retired in favor of the generated `v2`, which every data-repo branch
+  and the spam pipeline now declare. The pipeline declares it on its own
+  sheet; the consumer-side open against the data repo's human votes lives
+  in prune-spam (see Follow-ups).
+
 ## Follow-ups
+
+- Tracked as: open the evaluations sheets in `prune-spam` against the
+  `person-evaluations` contract (noted in PR #204).

plans/sheet-contracts.md

@@ -1,5 +1,5 @@
 ---
-status: in-progress
+status: done
 depends: [person-evaluations-contract]
 specs:
   - specs/behaviors/storage.md
@@ -72,10 +72,10 @@ each).
       `contracts verify` in a test repo) and every fixture record conforms
 - [x] Boot verifies every sheet; a drifted contract plus an invalid record
       fails the boot (test)
-- [ ] `published` adopts every contract: `gitsheets contracts verify` passes
+- [x] `published` adopts every contract: `gitsheets contracts verify` passes
       over all records, and `sources.toml` records the pinned URLs
-- [ ] Spam pipeline re-adopted from the published URL
-- [ ] `type-check` + `lint` + full suite green; sandbox, then live, boot
+- [x] Spam pipeline re-adopted from the published URL
+- [x] `type-check` + `lint` + full suite green; sandbox, then live, boot
       after adoption
 
 ## Risks / unknowns
@@ -104,8 +104,20 @@ each).
 - No structural fallback (`declared` mode), per Chris: the data repo moves
   in lockstep with the app.
 - Contracts caught three invalid test fixtures on their first run.
-- Remaining before `done`: adopt on `published` together with the release
-  carrying #212, boot sandbox and live, and re-adopt v2 in the spam
-  pipeline (CodeForPhilly/codeforphilly-spam-detection#1).
+- `published` adopted every contract (`21966b8`, `.gitsheets/` identical to
+  `empty`, `contracts verify` over every record) in lockstep with v0.7.0,
+  then sandbox and production deployed back to back. Both booted in
+  declared mode with all 16 sheets verified and 0 restarts.
+- The events backfill (codeforphilly-data #20) merged afterwards as records
+  only. Both environments took the incremental hot-reload path.
+- The spam pipeline adopted the published `person-evaluations` v2
+  (CodeForPhilly/codeforphilly-spam-detection#1).
 
 ## Follow-ups
+
+- Tracked as: JarvusInnovations/gitsheets#304 (flag template fields the
+  schema doesn't require) would move part of `sheet-configs.test.ts`'s guard
+  into gitsheets itself.
+- Tracked as: a gitsheets change to contract canonicalization would break
+  declared-mode identity on the next bump. Re-adopt every contract in
+  lockstep if one ships.

plans/slug-history-config.md

@@ -1,9 +1,10 @@
 ---
-status: planned
+status: done
 depends: []
 specs:
   - specs/behaviors/slug-handles.md
   - specs/behaviors/storage.md
+pr: 199
 ---
 
 # Plan: fix the slug-history sheet config and single-source sheet configs
@@ -69,20 +70,20 @@ Out: the attachment loss on rename — see
 
 ## Validation
 
-- [ ] `slug-history.toml` uses `oldSlug` on all four data-repo branches
-- [ ] `help-wanted-roles.toml` and `help-wanted-interest.toml` match
+- [x] `slug-history.toml` uses `oldSlug` on all four data-repo branches
+- [x] `help-wanted-roles.toml` and `help-wanted-interest.toml` match
       `storage.md` on all four branches; a role can be created in production
-- [ ] A test fails when any vendored config's template names a field that
+- [x] A test fails when any vendored config's template names a field that
       isn't a required schema field or a declared write-injected path field
 - [ ] Production: a person slug rename succeeds and writes a slug-history
       record; the old slug redirects
-- [ ] No inline `.gitsheets` config copies remain in `apps/api/tests`
+- [x] No inline `.gitsheets` config copies remain in `apps/api/tests`
       (grep `\[gitsheet\]`)
 - [ ] New every-sheet upsert test passes against the canonical configs
-- [ ] `setup-dev-data.ts` gone; docs don't reference it
-- [ ] `published` has no integer-underscore literals
+- [x] `setup-dev-data.ts` gone; docs don't reference it
+- [x] `published` has no integer-underscore literals
       (`git grep -E '= [0-9]+_[0-9]'` empty)
-- [ ] `type-check` + `lint` + full api suite green
+- [x] `type-check` + `lint` + full api suite green
 
 ## Risks / unknowns
 
@@ -93,4 +94,24 @@ Out: the attachment loss on rename — see
 
 ## Notes
 
+- Shipped in v0.6.0. The data-repo configs were pushed in lockstep, and the
+  `published` push hot-reloaded production (fast-forwarded, rebuilt), so the
+  500s stopped before the release.
+- **Unchecked: a production slug rename.** No one has renamed a person or
+  project since the fix (`published` has 0 slug-history records as of
+  2026-10-14). The rename path runs against the real configs in the test
+  suite, and every test repo now seeds from the vendored production configs.
+- **Unchecked: the every-sheet upsert test.** Replaced by two stronger
+  guards. `sheet-configs.test.ts` fails when any template field isn't a
+  required schema field or a declared write-injected one; it caught the
+  broken `help-wanted-roles` template. And later (`sheet-contracts`),
+  gitsheets enforces each sheet's contract on every write.
+- `tag-assignments` was documented in its production layout rather than
+  migrated (7.7k records).
+- The CI drift check needed a read-only deploy key: codeforphilly-data is
+  private (`CFP_DATA_DEPLOY_KEY`).
+
 ## Follow-ups
+
+- Tracked as: the first production slug rename. Confirm it writes a
+  slug-history record and the old slug redirects.