Repository navigation
Expand file tree
/
Copy pathCommandInspectorTest.php
More file actions
372 lines (312 loc) · 12.7 KB
/
Copy pathCommandInspectorTest.php
File metadata and controls
372 lines (312 loc) · 12.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
<?php
namespace CodeInstinct\ArtisanDocs\Tests\Unit;
use CodeInstinct\ArtisanDocs\CommandInspector;
use CodeInstinct\ArtisanDocs\Tests\TestCase;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Test;
use Symfony\Component\Console\Application as SymfonyApplication;
use Symfony\Component\Console\Command\Command as SymfonyCommand;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputOption;
class CommandInspectorTest extends TestCase
{
private CommandInspector $inspector;
protected function setUp(): void
{
parent::setUp();
$this->inspector = new CommandInspector;
}
#[Test]
public function it_extracts_basic_metadata_from_a_command(): void
{
$command = new class extends SymfonyCommand
{
protected function configure(): void
{
$this->setName('test:command')
->setDescription('A test command')
->setHelp('Detailed help text for the test command.')
->setAliases(['test:cmd']);
}
protected function execute($input, $output): int
{
return 0;
}
};
$meta = $this->inspector->inspect($command);
$this->assertSame('test:command', $meta['name']);
$this->assertSame('A test command', $meta['description']);
$this->assertSame('Detailed help text for the test command.', $meta['help']);
$this->assertFalse($meta['hidden']);
$this->assertSame(['test:cmd'], $meta['aliases']);
$this->assertSame('test', $meta['namespace']);
}
#[Test]
public function it_extracts_arguments_correctly(): void
{
$command = new class extends SymfonyCommand
{
protected function configure(): void
{
$this->setName('test:args')
->addArgument('name', InputArgument::REQUIRED, 'The name argument')
->addArgument('type', InputArgument::OPTIONAL, 'An optional type', 'default-type');
}
protected function execute($input, $output): int
{
return 0;
}
};
$meta = $this->inspector->inspect($command);
$this->assertCount(2, $meta['arguments']);
$this->assertSame('name', $meta['arguments'][0]['name']);
$this->assertTrue($meta['arguments'][0]['required']);
$this->assertSame('The name argument', $meta['arguments'][0]['description']);
$this->assertNull($meta['arguments'][0]['default']);
$this->assertSame('type', $meta['arguments'][1]['name']);
$this->assertFalse($meta['arguments'][1]['required']);
$this->assertSame('default-type', $meta['arguments'][1]['default']);
}
#[Test]
public function it_extracts_options_and_filters_internal_options(): void
{
$command = new class extends SymfonyCommand
{
protected function configure(): void
{
$this->setName('test:options')
->addOption('force', 'f', InputOption::VALUE_NONE, 'Force the operation')
->addOption('limit', 'l', InputOption::VALUE_REQUIRED, 'Result limit', 10);
}
protected function execute($input, $output): int
{
return 0;
}
};
$meta = $this->inspector->inspect($command);
// Internal options are stripped using the fallback list when no Symfony
// Application is bound (the anonymous class above has none).
$optionNames = array_column($meta['options'], 'name');
$this->assertContains('--force', $optionNames);
$this->assertContains('--limit', $optionNames);
$this->assertNotContains('--help', $optionNames);
$this->assertNotContains('--verbose', $optionNames);
$limitOpt = collect($meta['options'])->firstWhere('name', '--limit');
$this->assertSame('-l', $limitOpt['shortcut']);
$this->assertSame(10, $limitOpt['default']);
$this->assertTrue($limitOpt['required']);
}
// -------------------------------------------------------------------------
// Sensitive-default redaction
// -------------------------------------------------------------------------
/**
* @return array<string, array{string}>
*/
public static function sensitiveOptionNameProvider(): array
{
return [
'password' => ['password'],
'passwd' => ['passwd'],
'secret' => ['secret'],
'token' => ['token'],
'api_key' => ['api_key'],
'api-key' => ['api-key'],
'apikey' => ['apikey'],
'auth_key' => ['auth_key'],
'private_key' => ['private_key'],
'credential' => ['credential'],
'db_password' => ['db_password'],
'api_token' => ['api_token'],
];
}
#[Test]
#[DataProvider('sensitiveOptionNameProvider')]
public function it_redacts_sensitive_defaults_in_options(string $optionName): void
{
$command = new class($optionName) extends SymfonyCommand
{
public function __construct(private string $optName)
{
parent::__construct();
}
protected function configure(): void
{
$this->setName('test:sensitive')
->addOption($this->optName, null, InputOption::VALUE_OPTIONAL, 'Sensitive', 'super-secret-value');
}
protected function execute($input, $output): int
{
return 0;
}
};
$meta = $this->inspector->inspect($command);
$opt = collect($meta['options'])->firstWhere('name', "--{$optionName}");
$this->assertNotNull($opt, "Option --{$optionName} should be present in metadata");
$this->assertSame(CommandInspector::REDACTED_VALUE, $opt['default']);
}
#[Test]
public function it_redacts_sensitive_defaults_in_arguments(): void
{
$command = new class extends SymfonyCommand
{
protected function configure(): void
{
$this->setName('test:args-sensitive')
->addArgument('password', InputArgument::OPTIONAL, 'A password arg', 'hunter2');
}
protected function execute($input, $output): int
{
return 0;
}
};
$meta = $this->inspector->inspect($command);
$arg = collect($meta['arguments'])->firstWhere('name', 'password');
$this->assertNotNull($arg);
$this->assertSame(CommandInspector::REDACTED_VALUE, $arg['default']);
}
#[Test]
public function it_does_not_redact_non_sensitive_defaults(): void
{
$command = new class extends SymfonyCommand
{
protected function configure(): void
{
$this->setName('test:safe-defaults')
->addOption('limit', null, InputOption::VALUE_OPTIONAL, 'Limit', 100)
->addArgument('environment', InputArgument::OPTIONAL, 'Env', 'production');
}
protected function execute($input, $output): int
{
return 0;
}
};
$meta = $this->inspector->inspect($command);
$opt = collect($meta['options'])->firstWhere('name', '--limit');
$this->assertSame(100, $opt['default']);
$arg = collect($meta['arguments'])->firstWhere('name', 'environment');
$this->assertSame('production', $arg['default']);
}
#[Test]
public function it_does_not_redact_null_or_false_defaults_even_for_sensitive_names(): void
{
$command = new class extends SymfonyCommand
{
protected function configure(): void
{
$this->setName('test:null-sensitive')
->addOption('password', null, InputOption::VALUE_NONE, 'Flag only');
}
protected function execute($input, $output): int
{
return 0;
}
};
$meta = $this->inspector->inspect($command);
$opt = collect($meta['options'])->firstWhere('name', '--password');
$this->assertNotNull($opt);
// VALUE_NONE options have default === false; false should NOT be redacted.
$this->assertFalse($opt['default']);
}
// -------------------------------------------------------------------------
// Dynamic internal-option resolution
// -------------------------------------------------------------------------
#[Test]
public function it_resolves_internal_options_dynamically_from_a_bound_application(): void
{
$application = new SymfonyApplication('Test', '1.0');
// Add a non-standard global option – simulates a future Symfony/Artisan addition.
$application->getDefinition()->addOption(
new InputOption('profile', null, InputOption::VALUE_NONE, 'Enable profiling')
);
$command = new class extends SymfonyCommand
{
protected function configure(): void
{
$this->setName('test:dynamic-opts')
->addOption('force', null, InputOption::VALUE_NONE, 'Force')
->addOption('profile', null, InputOption::VALUE_NONE, 'Profile');
}
protected function execute($input, $output): int
{
return 0;
}
};
// Application::add() was removed in Symfony Console 8 (Laravel 13);
// setApplication() binds the command on every supported version.
$command->setApplication($application);
$meta = $this->inspector->inspect($command);
$optionNames = array_column($meta['options'], 'name');
// --force is a command-specific option → must appear.
$this->assertContains('--force', $optionNames);
// --profile is in the application's definition → must be filtered out.
$this->assertNotContains('--profile', $optionNames);
// Standard global options are also filtered.
$this->assertNotContains('--help', $optionNames);
}
// -------------------------------------------------------------------------
// isVendorCommand – absolute path-prefix matching
// -------------------------------------------------------------------------
#[Test]
public function it_identifies_vendor_commands_by_absolute_path_prefix(): void
{
$appCommand = new class extends SymfonyCommand
{
protected function configure(): void
{
$this->setName('app:test');
}
protected function execute($input, $output): int
{
return 0;
}
};
// Anonymous classes defined in the test suite are not inside the
// vendor directory, so isVendorCommand() must return false.
$this->assertFalse($this->inspector->isVendorCommand($appCommand));
}
#[Test]
public function it_returns_null_namespace_for_top_level_commands(): void
{
$this->assertNull($this->inspector->extractNamespace('list'));
$this->assertNull($this->inspector->extractNamespace(''));
$this->assertNull($this->inspector->extractNamespace(null));
$this->assertSame('make', $this->inspector->extractNamespace('make:model'));
$this->assertSame('queue', $this->inspector->extractNamespace('queue:work'));
}
#[Test]
public function it_identifies_application_commands_by_namespace(): void
{
$appCommand = new class extends SymfonyCommand
{
protected function configure(): void
{
$this->setName('app:hello');
}
protected function execute($input, $output): int
{
return 0;
}
};
// The anonymous class won't match App\Console\Commands\, so this is false.
$this->assertFalse($this->inspector->isApplicationCommand($appCommand, ['App\\Console\\Commands\\']));
}
#[Test]
public function it_does_not_duplicate_help_when_equal_to_description(): void
{
$command = new class extends SymfonyCommand
{
protected function configure(): void
{
$this->setName('test:nodupe')
->setDescription('Same text')
->setHelp('Same text');
}
protected function execute($input, $output): int
{
return 0;
}
};
$meta = $this->inspector->inspect($command);
$this->assertSame('', $meta['help']);
}
}