Repository navigation
Commit 47f046d
authored
Fix unsafe copies in EXIR and permute transforms (pytorch#19873)
Replace deepcopy-based copies of shape lists with shallow container
copies in paths that can carry torch.SymInt values from fake tensor
metadata. This is safe as torch.Size is immutable, so creating a shallow
list copy of it is safe: we can insert/delete elements in the new list
without affecting the original shape.
This fixes symbolic-shape failures in
exir.tensor.stride_from_dim_order() and in
PostponePermuteOpBelowSqueezeOrUnsqueezeLikeView, where deepcopy() could
crash while handling SymInt-backed shapes. The error that was produced:
"RuntimeError: Cannot access data pointer of Tensor (e.g. FakeTensor,
FunctionalTensor). If you're using torch.compile/export/fx, it is likely
that we are erroneously tracing into a custom kernel. To fix this,
please wrap the custom kernel into an opaque custom op. Please see the
following for details:
https://pytorch.org/tutorials/advanced/custom_ops_landing_page.html"
Add focused regression coverage for both cases: one test for stride
computation with symbolic sizes, and one dynamic-shape edge-graph test
for the permute/view transform pass.
cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson
@robell @rascani
Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>1 parent 2d9e5b9 commit 47f046d
4 files changed
Lines changed: 59 additions & 6 deletions
File tree
- backends/transforms
- test
- exir
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
9 | | - | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
| 111 | + | |
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| |||
132 | 132 | | |
133 | 133 | | |
134 | 134 | | |
135 | | - | |
| 135 | + | |
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| 29 | + | |
| 30 | + | |
28 | 31 | | |
29 | 32 | | |
30 | 33 | | |
| |||
477 | 480 | | |
478 | 481 | | |
479 | 482 | | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
480 | 515 | | |
481 | 516 | | |
482 | 517 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | 13 | | |
16 | 14 | | |
17 | 15 | | |
| |||
112 | 110 | | |
113 | 111 | | |
114 | 112 | | |
115 | | - | |
| 113 | + | |
116 | 114 | | |
117 | 115 | | |
118 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
388 | 388 | | |
389 | 389 | | |
390 | 390 | | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
391 | 411 | | |
392 | 412 | | |
393 | 413 | | |
| |||
0 commit comments