Repository navigation
Commit 4b1d027
authored
Fix test-samsung-models-linux: accelerate dep and the datasets/torchvision collate (pytorch#22870)
Fixes `test-samsung-models-linux`, red on `main` since the job started
running on Sep 14.
## The bug
`test_mobilebert_qat_a8w8` constructs a `transformers`
`TrainingArguments`, which requires
`accelerate>=1.1.0`. The job installs only `evaluate`, so:
```
ImportError: Using the `Trainer` with `PyTorch` requires `accelerate>=1.1.0`
```
It is the **sole** error in the suite, identically, on every affected
commit:
| Commit | Result |
|---|---|
| `f3c08fcf35` | `Ran 12 tests ... FAILED (errors=1)` |
| `4798a676c3` | `Ran 12 tests ... FAILED (errors=1)` |
| `500849ba5b` | `Ran 12 tests ... FAILED (errors=1)` |
| `cfc96cc0e2` | `Ran 12 tests ... FAILED (errors=1)` |
| `026ca3fff3` | `Ran 12 tests ... FAILED (errors=1)` |
`accelerate` appears nowhere in the job logs, so it is absent rather
than stale — but the pin is
still the right form, because `transformers` raises the same error for a
too-old version.
## Why it matters beyond the test
The non-zero exit propagates: `unittest` exits 1 → the script runs under
`set -ex` →
`run_with_env_secrets.py` raises → the job fails → the `trunk` workflow
concludes failure. `trunk`
is in `update-viablestrict`'s `requires` list, so the commit is
disqualified and `viable/strict` has
not advanced since Sep 14. This is one of two blockers; the other is the
`parallel_for` empty-range
bug, fixed separately in pytorch#22869. Both are needed — each independently
reddens `trunk`.
## Verification
Honest scope: I verified the **diagnosis**, not the fix. The sole error
is identical across five
commits and `accelerate` is never installed in the job. I cannot run
this job — it needs the
Samsung device and `SAMSUNG_AI_LITECORE_KEY` — so the one-liner itself
is untested. `trunk.yml`
parses and `lintrunner` is clean.
One note for reviewers: the `[CDI: ERROR] only support axis as 1` / `OP
LOGSOFTMAX` lines in the log
appear *after* `FAILED (errors=1)`. They are teardown noise from a
passing test, not a second
failure.
cc @digantdesai
---
Authored with Claude Code.1 parent d93e1f7 commit 4b1d027
3 files changed
Lines changed: 32 additions & 2 deletions
File tree
- .github/workflows
- backends/samsung/test/models
- examples/samsung/scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1133 | 1133 | | |
1134 | 1134 | | |
1135 | 1135 | | |
1136 | | - | |
| 1136 | + | |
| 1137 | + | |
| 1138 | + | |
1137 | 1139 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| |||
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
32 | 51 | | |
33 | 52 | | |
34 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
17 | 19 | | |
18 | 20 | | |
19 | | - | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
140 | 141 | | |
141 | 142 | | |
142 | 143 | | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
143 | 152 | | |
144 | 153 | | |
145 | 154 | | |
| |||
0 commit comments