Repository navigation
Commit 4fc2acc
authored
Lower the CMake version floor so 3.26 through 3.28 can build again (pytorch#22570)
### Summary
You cannot build ExecuTorch from source unless you have CMake 3.29 or
newer.
CMake is the tool that drives the build. Every build file can name the
oldest CMake it
accepts, and if yours is older, CMake stops with an error instead of
building. Five files
in this repo named 3.29, and none of them uses anything that needs it.
This hurts most on small Arm computers such as developer boards. Those
ship CMake 3.28, and
3.28 is also the newest their system offers, so you cannot simply
upgrade. You have to go
and install a second, private copy of CMake before you can build at all.
Those five files now name 3.26 instead, so anyone on 3.26 or newer can
build. 3.26 rather
than something lower, because `kernels/optimized` uses CMake syntax that
only exists from
3.26 on Arm builds. Going lower means rewriting that file, which belongs
in its own change.
The docs and requirement files name a CMake version too, and some of
those numbers could
never have worked, so they are corrected here: the build requirements
said 3.24 and now say
3.26, the WebGPU docs said 3.19 and now say 3.24, and the Supertonic
example said 3.24 and
now says 3.26. Installing a prebuilt wheel is untouched and still works
on CMake 3.19.
One more file, `examples/models/phi-3-mini`, named 3.24 and then asked
CMake to turn on a
behaviour that only exists from 3.27. Asking for a behaviour CMake does
not have is a hard
error, so that file could never build on the version it advertised. It
now asks only when
the running CMake has it.1 parent bf88c64 commit 4fc2acc
13 files changed
Lines changed: 18 additions & 14 deletions
File tree
- backends
- apple/metal
- cuda
- webgpu
- docs/source
- backends/webgpu
- llm
- examples/models
- phi-3-mini
- supertonic
- whisper
- extension/wasm
- tokenizers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
218 | 218 | | |
219 | 219 | | |
220 | 220 | | |
221 | | - | |
| 221 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
18 | 22 | | |
19 | 23 | | |
20 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
113 | | - | |
| 113 | + | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
0 commit comments