Arm backend: Optimize public API manifest validation

Validate all public API manifests in one Python process to avoid
repeated Torch imports while preserving per-manifest reporting and
failure aggregation.

Authored with Codex.

Signed-off-by: Per Held <per.held@arm.com>
Change-Id: I6213188a92795ef4bdaab4dae0894bbfc207adf9

Author: perheld

backends/arm/scripts/public_api_manifest/validate_all_public_api_manifests.sh

@@ -4,33 +4,5 @@
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
 
-set -u
-
-echo "Validating Arm public API manifests"
-
-manifest_failures=0
-for manifest_path in backends/arm/public_api_manifests/api_manifest_*.toml; do
-    if [[ ! -f "${manifest_path}" ]]; then
-        continue
-    fi
-    manifest_name="${manifest_path##*/}"
-    echo
-    echo "=== ${manifest_name} ==="
-    validator_output=$(
-        python backends/arm/scripts/public_api_manifest/validate_public_api_manifest.py \
-            --manifest "${manifest_path}" 2>&1
-    )
-    validator_status=$?
-    printf '%s\n' "${validator_output}"
-    if [[ ${validator_status} -ne 0 ]]; then
-        manifest_failures=$((manifest_failures + 1))
-    fi
-done
-
-echo
-if [[ ${manifest_failures} -eq 0 ]]; then
-    echo "Arm public API manifests OK"
-else
-    echo "${manifest_failures} manifest(s) failed validation"
-    exit 1
-fi
+exec python backends/arm/scripts/public_api_manifest/validate_public_api_manifest.py \
+    --all-manifests

backends/arm/scripts/public_api_manifest/validate_public_api_manifest.py

@@ -4,7 +4,7 @@
 #
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
-"""Validate one Arm public API manifest against the current API."""
+"""Validate Arm public API manifests against the current API."""
 
 from __future__ import annotations
 
@@ -13,6 +13,7 @@
 import importlib.util
 import inspect
 from pathlib import Path
+from typing import Sequence
 
 try:
     import tomllib
@@ -357,19 +358,48 @@ def validate_manifest(manifest_path: Path) -> list[Issue]:
     return issues
 
 
+def validate_manifests(manifest_paths: Sequence[Path]) -> int:
+    failures = 0
+    for manifest_path in manifest_paths:
+        print()
+        print(f"=== {manifest_path.name} ===")
+        issues = validate_manifest(manifest_path)
+        print(format_validation_report(manifest_path, issues))
+        if issues:
+            failures += 1
+    return failures
+
+
 def parse_args() -> argparse.Namespace:
     parser = argparse.ArgumentParser()
-    parser.add_argument(
+    manifest_group = parser.add_mutually_exclusive_group()
+    manifest_group.add_argument(
         "--manifest",
         type=Path,
         default=MANIFEST_PATH,
         help="Path to the public API manifest TOML file.",
     )
+    manifest_group.add_argument(
+        "--all-manifests",
+        action="store_true",
+        help="Validate every public API manifest in one process.",
+    )
     return parser.parse_args()
 
 
 def main() -> None:
     args = parse_args()
+    if args.all_manifests:
+        print("Validating Arm public API manifests")
+        manifest_paths = sorted(MANIFEST_PATH.parent.glob("api_manifest_*.toml"))
+        failures = validate_manifests(manifest_paths)
+        print()
+        if failures:
+            print(f"{failures} manifest(s) failed validation")
+            raise SystemExit(1)
+        print("Arm public API manifests OK")
+        return
+
     issues = validate_manifest(args.manifest)
     print(format_validation_report(args.manifest, issues))
     if issues:

backends/arm/test/misc/test_validate_public_api_manifest.py

@@ -122,6 +122,30 @@ def test_running_manifest_validation_rejects_cmake_drift(tmp_path, monkeypatch):
     assert issues[0][1] == "signature changed"
 
 
+def test_validate_manifests_checks_every_manifest(monkeypatch, capsys):
+    manifest_paths = [
+        Path("api_manifest_1_4.toml"),
+        Path("api_manifest_running.toml"),
+    ]
+    validated_paths = []
+
+    def validate_manifest(manifest_path):
+        validated_paths.append(manifest_path)
+        if manifest_path.name == "api_manifest_running.toml":
+            return [("foo", "signature changed", "foo()", "foo(x)")]
+        return []
+
+    monkeypatch.setattr(vpam, "validate_manifest", validate_manifest)
+
+    failures = vpam.validate_manifests(manifest_paths)
+
+    assert failures == 1
+    assert validated_paths == manifest_paths
+    output = capsys.readouterr().out
+    assert "=== api_manifest_1_4.toml ===" in output
+    assert "=== api_manifest_running.toml ===" in output
+
+
 def test_nested_python_manifest_entries_are_validated():
     manifest_symbols = get_manifest_python_symbols(
         tomllib.loads(