Repository navigation
Commit 6faf63e
authored
Do not move a view's shape earlier than the nodes that compute it (pytorch#22403)
### Summary
`_merge_view_copy_chains` gives the first view in a chain the shape of
the last one:
```python
final_shape = view_nodes_to_remove[-1].args[1]
node.args = (node.args[0], final_shape)
```
Under dynamic shapes a view's shape is not a list of ints, it is a list
that can contain nodes computing symbolic sizes. Those nodes may be
defined anywhere between the first and the last view, so assigning the
later shape to the earlier node can make that node read a value that
does not exist yet.
The result is a graph that fails fx's own `lint()`, which the pass then
hits itself on the very next line via `eliminate_dead_code()`:
```
RuntimeError: Argument 'mul' of Node 'aten_view_copy_default_21' was used
before it has been defined! Please check that Nodes in the graph are
topologically ordered
```
I hit this lowering a TTS model to Vulkan. The chain ends on a
`view_copy(x, [2*s, 512])` whose `2*s` is produced exactly one node
after the first view of the chain, so the rewrite moves the shape one
position too far back. The submodule handed to the backend is correctly
ordered; this pass is what breaks it.
### Fix
Fuse the longest prefix of the chain whose shape is available where the
first view sits, and leave the rest alone. Chains with static shapes,
which is the common case, keep fusing exactly as before.
### Test plan
New `backends/transforms/test/test_fuse_view_copy.py`:
- a static view chain still collapses to a single view
- a chain whose final shape is computed after the first view leaves the
graph topologically ordered (asserted with `graph.lint()`)
The second test fails on the current pass and passes with this change;
the first passes either way, so the existing fusion is not narrowed for
static shapes.
cc @cccclai1 parent b0883bd commit 6faf63e
2 files changed
Lines changed: 118 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
93 | 113 | | |
94 | 114 | | |
95 | 115 | | |
| |||
110 | 130 | | |
111 | 131 | | |
112 | 132 | | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
113 | 136 | | |
114 | 137 | | |
115 | 138 | | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
116 | 147 | | |
117 | 148 | | |
118 | 149 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
0 commit comments