Skip to content

Commit 7f1d82b

Browse files
Arm backend: Run manifest checks in parallel with other checks (pytorch#22894)
Signed-off-by: Sebastian Larsson <sebastian.larsson@arm.com>
1 parent a1bd696 commit 7f1d82b

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

‎backends/arm/scripts/pre-push‎

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,8 @@ run_op_support_checks() {
106106
fi
107107
}
108108

109-
run_public_api_validator() {
110-
if ! backends/arm/scripts/public_api_manifest/validate_all_public_api_manifests.sh; then
109+
wait_public_api_validator() {
110+
if ! wait "${manifest_pid}"; then
111111
echo -e "${ERROR} Arm public API manifest validation failed"
112112
FAILED=1
113113
fi
@@ -126,7 +126,7 @@ VERBS="Add|Fix|Update|Refactor|Improve|Remove|Change|Implement|Create|Modify|"\
126126
"Profile|Recalculate|Reconstruct|Redefine|Redesign|Reevaluate|Relocate|Remap|"\
127127
"Render|Reposition|Request|Revert|Sanitize|Specify|Strengthen|Stub|Substitute|"\
128128
"Tag|Tweak|Unify|Unlock|Unset|Use|Validate|Verify|Rename|Relax|Format|Don't|"\
129-
"Consolidate|Review"
129+
"Consolidate|Review|Run"
130130

131131
# Remote branch
132132
REMOTE=$(git rev-parse --abbrev-ref --symbolic-full-name @{u} 2>/dev/null)
@@ -160,6 +160,12 @@ if [ -z "$COMMITS" ]; then
160160
exit 0
161161
fi
162162

163+
manifest_output=$(mktemp) || exit 1
164+
trap 'rm -f "${manifest_output}"' EXIT
165+
backends/arm/scripts/public_api_manifest/validate_all_public_api_manifests.sh \
166+
> "${manifest_output}" 2>&1 &
167+
manifest_pid=$!
168+
163169
for COMMIT in ${COMMITS}; do
164170
if [ -n "$REMOTE" ] && git merge-base --is-ancestor "$COMMIT" "$REMOTE"; then
165171
echo -e "${INFO} Skipping commit ${COMMIT} (already on $REMOTE)"
@@ -357,7 +363,8 @@ fi
357363
run_op_support_checks "vgf" "VGF" "$VGF_OP_SUPPORT_OUTPUT"
358364
run_op_support_checks "u55" "Ethos-U55" "$U55_OP_SUPPORT_OUTPUT"
359365
run_op_support_checks "u85" "Ethos-U85" "$U85_OP_SUPPORT_OUTPUT"
360-
run_public_api_validator
366+
wait_public_api_validator
367+
cat "${manifest_output}"
361368

362369
if [[ $FAILED ]]; then
363370
echo -e "${INFO} Fix your commit message errors with"\

0 commit comments

Comments
 (0)