Repository navigation
Commit 9017295
authored
Ship the Qualcomm delegate as a linkable component of the wheel (pytorch#21989)
The wheel already carried the Qualcomm delegate, but a C++ application
could not
link it. The package config published no target for it, so the only way
to use it
from C++ was to build ExecuTorch from source.
Publish it as `executorch::backend_qnn`, the same shape as the XNNPACK,
OpenVINO
and CUDA delegates. Two things had to change for that to need no special
case.
The shared build now names the output `libexecutorch_backend_qnn.so` and
installs it
into `lib/` beside the other delegates. Every other build keeps the
original name and
location, because the device tooling, the signing step and the
exporter's push list
all expect them there.
Without the rename the finder would have needed a per-component search
directory, and
the component would have been the one delegate that did not look like
the others. The
name was previously left alone on the belief that the exporter opens the
library from
a copy shipped by the vendor SDK. That is not so: the signing script
signs this
repository's own build output into the SDK tree, so the file under the
SDK is ours.
Both the name and the location are therefore ours to choose, and the
non-shared builds
that keep the old spelling are unaffected.
The ownership check gains the delegate, required on Linux x86_64 rather
than on Linux
generally, since the SDK it builds against is published only for that
architecture and
the aarch64 wheels ship no such library.
Verified against an installed wheel with the shipped config replaced and
the library
staged as the rename produces it: a consumer asking for the component
configures and
builds; a consumer asking only for the runtime and kernels is
unaffected; and with the
library removed the component is not defined and the request fails while
configuring
rather than at link time. The installed files were backed up first and
restored after.1 parent ac9857b commit 9017295
4 files changed
Lines changed: 56 additions & 9 deletions
File tree
- .ci/scripts/wheel
- backends/qualcomm
- tools/cmake
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
143 | 144 | | |
144 | 145 | | |
145 | 146 | | |
| 147 | + | |
146 | 148 | | |
147 | 149 | | |
148 | 150 | | |
| |||
859 | 861 | | |
860 | 862 | | |
861 | 863 | | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
862 | 869 | | |
863 | 870 | | |
864 | 871 | | |
| |||
867 | 874 | | |
868 | 875 | | |
869 | 876 | | |
| 877 | + | |
| 878 | + | |
870 | 879 | | |
871 | 880 | | |
872 | 881 | | |
| |||
994 | 1003 | | |
995 | 1004 | | |
996 | 1005 | | |
| 1006 | + | |
| 1007 | + | |
| 1008 | + | |
| 1009 | + | |
| 1010 | + | |
| 1011 | + | |
| 1012 | + | |
| 1013 | + | |
| 1014 | + | |
| 1015 | + | |
997 | 1016 | | |
998 | 1017 | | |
999 | 1018 | | |
| |||
2280 | 2299 | | |
2281 | 2300 | | |
2282 | 2301 | | |
| 2302 | + | |
2283 | 2303 | | |
2284 | 2304 | | |
2285 | 2305 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
262 | 262 | | |
263 | 263 | | |
264 | 264 | | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
265 | 272 | | |
266 | | - | |
267 | | - | |
| 273 | + | |
268 | 274 | | |
269 | 275 | | |
270 | 276 | | |
| |||
336 | 342 | | |
337 | 343 | | |
338 | 344 | | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
339 | 353 | | |
340 | 354 | | |
341 | 355 | | |
342 | | - | |
343 | | - | |
344 | | - | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
345 | 359 | | |
346 | 360 | | |
347 | 361 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2394 | 2394 | | |
2395 | 2395 | | |
2396 | 2396 | | |
| 2397 | + | |
| 2398 | + | |
| 2399 | + | |
| 2400 | + | |
| 2401 | + | |
2397 | 2402 | | |
2398 | 2403 | | |
2399 | | - | |
2400 | | - | |
2401 | | - | |
2402 | | - | |
| 2404 | + | |
| 2405 | + | |
| 2406 | + | |
| 2407 | + | |
| 2408 | + | |
| 2409 | + | |
2403 | 2410 | | |
2404 | 2411 | | |
2405 | 2412 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
650 | 650 | | |
651 | 651 | | |
652 | 652 | | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
| 656 | + | |
| 657 | + | |
| 658 | + | |
653 | 659 | | |
654 | 660 | | |
655 | 661 | | |
| |||
0 commit comments