@@ -398,6 +398,77 @@ std::vector<uint8_t> make_state_program(
398398 builder.GetBufferPointer () + builder.GetSize ()};
399399}
400400
401+ // relu_ mutates `input`, or with `from_sum` the intermediate input + input.
402+ // With `output_mutated`, the mutated tensor is also a graph output.
403+ std::vector<uint8_t > make_inplace_relu_program (
404+ bool from_sum = false ,
405+ bool output_mutated = false ) {
406+ flatbuffers::FlatBufferBuilder builder;
407+ const auto meta = create_tensor_meta (builder, fbs::ScalarType::FLOAT );
408+ const char * mutated = from_sum ? " sum" : " input" ;
409+ std::vector<flatbuffers::Offset<fbs::TensorValue>> tensor_values = {
410+ fbs::CreateTensorValueDirect (builder, " input" , meta),
411+ fbs::CreateTensorValueDirect (builder, " relu" , meta),
412+ };
413+ const std::vector<flatbuffers::Offset<fbs::Output>> input_outputs = {
414+ fbs::CreateOutputDirect (builder, " input" )};
415+ const std::vector<flatbuffers::Offset<fbs::Output>> sum_outputs = {
416+ fbs::CreateOutputDirect (builder, " sum" )};
417+ const std::vector<flatbuffers::Offset<fbs::Output>> relu_outputs = {
418+ fbs::CreateOutputDirect (builder, " relu" , mutated)};
419+ const std::vector<flatbuffers::Offset<fbs::NamedArgument>> add_inputs = {
420+ fbs::CreateNamedArgumentDirect (
421+ builder, " self" , create_tensor_arg (builder, " input" )),
422+ fbs::CreateNamedArgumentDirect (
423+ builder, " other" , create_tensor_arg (builder, " input" )),
424+ fbs::CreateNamedArgumentDirect (
425+ builder, " alpha" , create_int_arg (builder, 1 )),
426+ };
427+ const std::vector<flatbuffers::Offset<fbs::NamedArgument>> relu_inputs = {
428+ fbs::CreateNamedArgumentDirect (
429+ builder, " self" , create_tensor_arg (builder, mutated), true )};
430+ std::vector<flatbuffers::Offset<fbs::NamedArgument>> output_inputs = {
431+ fbs::CreateNamedArgumentDirect (
432+ builder, " " , create_tensor_arg (builder, " relu" ))};
433+ std::vector<std::string> graph_outputs = {" relu" };
434+ std::vector<flatbuffers::Offset<fbs::OutputSpec>> output_specs = {
435+ fbs::CreateOutputSpecDirect (builder, " relu" )};
436+ if (output_mutated) {
437+ output_inputs.push_back (fbs::CreateNamedArgumentDirect (
438+ builder, " " , create_tensor_arg (builder, mutated)));
439+ graph_outputs.emplace_back (mutated);
440+ output_specs.push_back (fbs::CreateOutputSpecDirect (builder, mutated));
441+ }
442+ std::vector<flatbuffers::Offset<fbs::Node>> nodes = {fbs::CreateNodeDirect (
443+ builder, " input" , fbs::OpKind::PLACEHOLDER , " " , nullptr , &input_outputs)};
444+ if (from_sum) {
445+ tensor_values.push_back (fbs::CreateTensorValueDirect (builder, " sum" , meta));
446+ nodes.push_back (fbs::CreateNodeDirect (
447+ builder,
448+ " sum" ,
449+ fbs::OpKind::CALL_FUNCTION ,
450+ " torch.ops.aten.add.Tensor" ,
451+ &add_inputs,
452+ &sum_outputs));
453+ }
454+ nodes.push_back (fbs::CreateNodeDirect (
455+ builder,
456+ " relu" ,
457+ fbs::OpKind::CALL_FUNCTION ,
458+ " torch.ops.aten.relu_.default" ,
459+ &relu_inputs,
460+ &relu_outputs));
461+ nodes.push_back (fbs::CreateNodeDirect (
462+ builder, " output" , fbs::OpKind::OUTPUT , " " , &output_inputs));
463+ const auto graph = fbs::CreateGraph (
464+ builder,
465+ builder.CreateVector (nodes),
466+ create_strings (builder, {" input" }),
467+ create_strings (builder, graph_outputs),
468+ builder.CreateVector (tensor_values));
469+ return finish_program (builder, graph, output_specs);
470+ }
471+
401472struct CompiledProgram {
402473 std::unique_ptr<VulkanEngineHost> host;
403474 std::shared_ptr<const Program> program;
@@ -623,6 +694,47 @@ TEST(VulkanEngineTest, RejectsMutationOutputNotWrittenInPlace) {
623694 << e.what ();
624695 }
625696}
697+
698+ TEST (VulkanEngineTest, ExecutesSerializedInPlaceRelu) {
699+ CompiledProgram compiled = compile_program (make_inplace_relu_program ());
700+ const std::vector<float > input = {-2 .0f , -0 .5f , 0 .0f , 3 .0f };
701+ compiled.executable ->set_input (
702+ 0 , input.data (), input.size (), ScalarType::Float);
703+ compiled.executable ->execute ();
704+
705+ std::vector<float > output (4 );
706+ compiled.executable ->get_output (
707+ 0 , output.data (), output.size (), ScalarType::Float);
708+ EXPECT_EQ (output, (std::vector<float >{0 .0f , 0 .0f , 0 .0f , 3 .0f }));
709+ }
710+
711+ TEST (VulkanEngineTest, ExecutesInPlaceReluOfIntermediate) {
712+ CompiledProgram compiled =
713+ compile_program (make_inplace_relu_program (/* from_sum=*/ true ));
714+ const std::vector<float > input = {-2 .0f , -0 .5f , 0 .0f , 3 .0f };
715+ compiled.executable ->set_input (
716+ 0 , input.data (), input.size (), ScalarType::Float);
717+ compiled.executable ->execute ();
718+
719+ std::vector<float > output (4 );
720+ compiled.executable ->get_output (
721+ 0 , output.data (), output.size (), ScalarType::Float);
722+ EXPECT_EQ (output, (std::vector<float >{0 .0f , 0 .0f , 0 .0f , 6 .0f }));
723+ }
724+
725+ TEST (VulkanEngineTest, RejectsInPlaceReluWhoseInputIsReadElsewhere) {
726+ try {
727+ compile_program (make_inplace_relu_program (
728+ /* from_sum=*/ true , /* output_mutated=*/ true ));
729+ FAIL () << " expected the observed in-place relu to be rejected" ;
730+ } catch (const std::runtime_error& e) {
731+ EXPECT_NE (
732+ std::string (e.what ()).find (
733+ " in-place update of 'sum' is read elsewhere" ),
734+ std::string::npos)
735+ << e.what ();
736+ }
737+ }
626738// cppcheck-suppress-end syntaxError
627739
628740} // namespace
0 commit comments