Repository navigation
Commit 96cf9c8
authored
Arm backend: Improve pre-push hook checks (pytorch#16777)
Update the pre-push hook:
- Only check if the 'Arm backend: ' prefix is present in case all file
modifications are in backends/arm or examples/arm; otherwise, skip the
check. However, missing this prefix when it should be in place is now
a fatal error for the pre-push hook.
- The imperative mood check is still in place but it is now able to
check patches no matter if they have the 'Arm backend: ' or not.
Effectively it is now independent from the prefix check. When the
imperative mood check fails, it is still just a warning.
- Add a non-zero exit code (1) in case parse_test_names.py finds any
test name violations. Otherwise the pre-push hook will not fail in
case the script finds any violations.
Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com>1 parent e5311bf commit 96cf9c8
2 files changed
Lines changed: 34 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
92 | 95 | | |
93 | 96 | | |
94 | 97 | | |
| |||
97 | 100 | | |
98 | 101 | | |
99 | 102 | | |
100 | | - | |
101 | | - | |
102 | 103 | | |
103 | 104 | | |
104 | 105 | | |
| |||
169 | 170 | | |
170 | 171 | | |
171 | 172 | | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
177 | 196 | | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
178 | 200 | | |
179 | 201 | | |
180 | 202 | | |
181 | 203 | | |
182 | 204 | | |
183 | 205 | | |
184 | | - | |
185 | 206 | | |
186 | 207 | | |
187 | 208 | | |
| |||
0 commit comments