Repository navigation
Commit b4c53c6
Move the NXP op alias table out of the test package (pytorch#22592)
The NXP backend keeps a table of short names for edge operators, for
example `AddTensor = exir_ops.edge.aten.add.Tensor`. It lives in the
backend's test package, but three modules that ship in the wheel read it
at import time:
- `backend/edge_helper.py`
- `backend/node_format_inference.py`
-
`edge_passes/move_auxiliary_operator_into_separate_qdq_cluster_pass.py`
Two dozen production files import those modules, so the backend cannot
load at all without a test package. The dependency points the wrong way:
the tests should depend on the backend, not the backend on the tests.
### What this does
The table has no test logic in it, so it moves to
`backend/ops_aliases.py`, next to the code that reads it. That follows
the shape the Arm backend already uses for shared operator constants in
`backends/arm/constants.py`.
The Buck target that published the table from the test package is
removed, since the backend library already globs the directory it moves
into.
No behavior changes. The names, values and every importer stay the same,
including the roughly fifty tests that use the table.
### Why the diff looks larger than it is
Most of it is one line per file. Every importer switches from
`nxp.tests.ops_aliases` to `nxp.backend.ops_aliases`, and because
`backend` sorts before `tests`, the import sorter then moves that line
to the top of the block. So a one line change shows up as several lines
moving in some files. No code changed in any of them.
### Test plan
Imported the moved module and every updated importer from an installed
wheel, and confirmed the table exposes the same names bound to the same
values as before the move. Compared the alias assignments before and
after by parsing both files: 56 aliases, no names added or removed, no
values changed.
Checked that every NXP test target can still reach the table, through
the backend library that already globs that directory, and that no
reference to the old Buck target or the old import path remains anywhere
in the tree.
Ran the formatter and linter over all changed files.
Co-authored-by: PyTorch Bot <pytorchbot@users.noreply.github.com>1 parent 9b3f660 commit b4c53c6
54 files changed
Lines changed: 206 additions & 214 deletions
File tree
- backends/nxp
- backend
- edge_passes
- tests
- generic_tests
- ir
- converter/node_converter
- edge_passes
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
72 | 71 | | |
73 | 72 | | |
74 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
| 6 | + | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
12 | | - | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | 7 | | |
19 | 8 | | |
20 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
18 | 25 | | |
19 | 26 | | |
20 | 27 | | |
| |||
28 | 35 | | |
29 | 36 | | |
30 | 37 | | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
25 | | - | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
34 | | - | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
24 | | - | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| |||
0 commit comments