Repository navigation
Commit fa03587
authored
Re-enable the yolo26 portable CI job by installing its requirements (pytorch#23449)
Fixes pytorch#21621.
The yolo26 portable job in the periodic model matrix was red from the
day it was added, so pytorch#21618 stopped gathering it. The cause turned out
to be simple: `.ci/scripts/test_model.sh` never installs the model's
Python requirements. The yolo26 wrapper imports `ultralytics`, so the
export stopped while loading the model, before the portable runner
started:
```
ModuleNotFoundError: No module named 'ultralytics'
```
Every scheduled run on main whose log is still available and that
reached the export step failed this way. The dim order error quoted in
pytorch#21621 came from a different job in the same run (`ds_cnn`). pytorch#21619
fixed that one the same day, and `ds_cnn` has passed on main since
August 7.
This change:
- installs `examples/models/yolo26/requirements.txt` before the export,
with the same command that `test_yolo26.sh` and the yolo26 README use
- adds a comment above the `ultralytics` pin, because the job now
depends on it
- removes the yolo26 skip from `gather_test_models.py`, so the job runs
again
The install step is the same as in pytorch#20841, which was approved in July
but never merged. In that PR's Linux run, the same command kept the
torch that CI already had and only added `ultralytics` and a few of its
dependencies.
The job only passes with the pinned `ultralytics==8.4.14`. Releases
8.4.133 to 8.4.139 switch the model to channels last on x86 Linux and
Windows, and the portable convolution kernel then rejects it. From
8.4.140, strict export fails. pytorch#23453 tracks both, so raising the pin is
left for a separate change.
### Test plan
- Ran `PYTHON_EXECUTABLE=python bash .ci/scripts/test_model.sh yolo26
cmake portable` on current main with this change, on macOS arm64 with
Python 3.10 and torch 2.14.0. It installed `ultralytics` 8.4.14,
exported `yolo26.pte`, and the portable `executor_runner` ran it
successfully.
- `gather_test_models.py` now emits `yolo26` on `portable` for the
scheduled matrix (59 to 60 records) and the push matrix used by release
branches (53 to 54). No other record changes.
- The yolo26 portable job passed on this PR on Linux x86, in both the
scheduled and the push matrix, through the `ciflow/periodic` label. It
installed `ultralytics` 8.4.14, kept the torch that CI already had,
exported the model, and the portable runner ran it.
- With `ultralytics` 8.4.140 and 8.4.173, the export fails as described
in pytorch#23453.1 parent c77d0ee commit fa03587
3 files changed
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | 116 | | |
122 | 117 | | |
123 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
111 | 116 | | |
112 | 117 | | |
113 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
0 commit comments