Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 1 | Module data groups sprint-1 by MattCarolus10 · Pull Request #1480 · CodeYourFuture/Module-Data-Groups

MattCarolus10 · 2026-10-27T17:26:52Z

No description provided.

… function

…r clarity

…ple numbers

…le item array

…umbers

…validation

…edian

…ates

cjyuan · 2026-10-31T21:51:36Z

-// Given an array with no duplicates
-// When passed to the dedupe function
-// Then it should return a copy of the original array


You missed implementing this test.

Please note that in this test, in addition to checking the returned array has the same elements, you should also test whether the returned array is a different array.

cjyuan · 2026-10-31T22:02:09Z

-// Given an array of strings or numbers
-// When passed to the dedupe function
-// Then it should return a new array with duplicates removed while preserving the 
-// first occurrence of each element from the original array.
+test("keeps the first occurrence order", () => {
+  expect(dedupe([5, 1, 1, 2, 3, 2, 5, 8])).toEqual([5, 1, 2, 3, 8]);
+});


The comment on line 25 suggests testing an array containing mixed types of values.

We could test multiple test cases in one test, and doing so gives us a better chance to catch bugs.

I would also suggest using AI to research what would make good test cases and, more importantly, why. There may be valuable reasoning and insights that we can learn from AI. In fact, understanding the "why" is more important than simply identifying the "what". (This applies to all tests in this exercise)

cjyuan · 2026-10-31T22:40:29Z

+  if (!Array.isArray(list)) {
+    throw new Error("sum requires an array of numbers");
+  }
+  if (!list.every((item) => typeof item === "number")) {


+/- Infinity and NaN are also of type "number". If it were up to you, how would you design the function to handle these values?

cjyuan · 2026-10-31T22:52:23Z

@@ -0,0 +1,16 @@
+const fs = require("fs");
+const changes = fs.readFileSync("input.txt", "utf8").trim().split("\n").map(Number);


Could you walk me through why trim() is needed before applying split("\n") on the input?

cjyuan · 2026-10-31T22:52:37Z

+  if (seen.has(frequency)) {
+    console.log(frequency);
+    break;
+}
+    seen.add(frequency)


Indentation is off.

cjyuan · 2026-10-31T22:56:47Z

Could you prepare and format the PR description following the same structure and style as the example in this PR?
Please use it as a reference for the layout, headings, and level of detail.

MattCarolus10 added 30 commits October 24, 2026 22:32

array of numbers fixed

13fca37

non empty array fixed

010e59e

non list of array fixed

a885859

all test function fixed

cd95950

empty array return infinity

3cc7cf4

empty array return infinity

79f3284

test given an array of one number

df508f3

test largest positive and negative numbers

523c22c

fix: correct syntax in test for largest of positive and negative numbers

92b41f3

closest to zero for all negative numbers

55446f7

closest to zero for all negative numbers

59800af

test for largest decimal numbers

01356bc

test containing non-numbers

8223706

test for not given an array

40ab195

fix not array test

f095dbf

length equals zero test fix

3660134

refactor error handling and formatting in findMax function

289a04c

fix: correct case of -Infinity in empty array test

d70f176

fix: correct case of -Infinity and fix type checks in findMax function

2163cf1

refactor: remove unnecessary comments and clean up max.test.js

0eb22a9

refactor: improve formatting and indentation in max.test.js

794f3b1

test: implement test case for empty array in sum function

8dc93ce

test: fix test case for returning a number from an array

87581d4

test: fix test case for adding negative numbers in sum function

6fb4efd

test: add test cases for decimal numbers and non-number inputs in sum…

cf80450

… function

test: add case to throw error when input is not an array in sum function

04f33f8

fix: correct variable name in array check for sum function

14a6f66

fix: correct variable name in array check for sum function

20c90a2

fix: correct variable name and implement summation logic in sum function

021392c

fix: correct formatting in sum function for consistency

bca8798

MattCarolus10 added 25 commits October 25, 2026 12:45

feat: implement dedupe function to remove duplicates from an array

586f2b0

fix: remove unnecessary comments and documentation in dedupe tests fo…

9fe1206

…r clarity

test: implement test for calculateMean function with sample input

9d715a4

test: update calculateMean test case to return correct mean for multi…

320a5fa

…ple numbers

test: add case to verify calculateMean returns correct value for sing…

d3d9156

…le item array

test: add case to verify calculateMean handles negative and decimal n…

7f9881d

…umbers

test: add case to verify calculateMean throws error for empty array

9ea6b81

test: add cases to verify calculateMean throws errors for invalid inputs

58bc16c

test: remove unnecessary comments and documentation from mean test file

44859cb

test: implement input validation for calculateMean function

c15204d

test: add validation for non-empty array in calculateMean function

e94100e

fix: ensure calculateMean validates input as an array of numbers

e912e06

fix: correct error message and test description for non-number array …

ab6b5a4

…validation

fix: correct typo in test for handling negative and decimal numbers

88a8db1

test: implement test for describeMedian function with valid input

da1d6fd

test: fix expected output for describeMedian function with valid input

edf099c

test: add missing test for non-array input in describeMedian function

2d2960d

fix: correct error messages in tests for describeMedian function

34a8196

feat: implement describeMedian function to calculate and return the m…

c60bbdf

…edian

fix: correct median test output and remove unnecessary comments

783f7e6

refactor: simplify includes function using for...of loop

611dd7f

fix: update input values in aoc-2018-day1 dataset for accuracy

9a34fb9

feat: implement frequency calculation from input file

7b077cf

feat: update frequency calculation to handle input parsing and duplic…

ec97a6d

…ates

remove prep from sprint branch

8a56804

MattCarolus10 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 27, 2026

cjyuan reviewed Oct 31, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 31, 2026

Navigation Menu

Repository navigation

Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 1 | Module data groups sprint-1 - #1480

Manchester | 26-ITP-Sep | Mathew Shaibu | Sprint 1 | Module data groups sprint-1#1480
MattCarolus10 wants to merge 63 commits into
CodeYourFuture:mainfrom
MattCarolus10:Module-Data-Groups-sprint-1

MattCarolus10 commented Oct 27, 2026

Uh oh!

cjyuan Oct 31, 2026

Uh oh!

cjyuan Oct 31, 2026

Uh oh!

cjyuan Oct 31, 2026

Uh oh!

cjyuan Oct 31, 2026

Uh oh!

cjyuan Oct 31, 2026

Uh oh!

cjyuan commented Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -0,0 +1,16 @@
		const fs = require("fs");
		const changes = fs.readFileSync("input.txt", "utf8").trim().split("\n").map(Number);

Conversation

MattCarolus10 commented Oct 27, 2026

Uh oh!

cjyuan Oct 31, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 31, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 31, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 31, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 31, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants