Manchester | 26-ITP-Sep | Precious Moses | Sprint 2 | Data Groups by moses77-boop · Pull Request #1497 · CodeYourFuture/Module-Data-Groups

moses77-boop · 2026-11-06T01:39:53Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1083

Changelist

In this PR, I debugged, interpreted codes, implemented tests and wrote functions to complete this coursework.

…handling

…or lookup

… parameter handling

… spaces

…th multiple key-value pairs

…h multiple key-value pairs

…t function

… the invert function

…st file

cjyuan · 2026-11-08T15:59:42Z

+test("contains throws an error for an array", () => {
+  expect(() => contains([1, 2, 3], "name")).toThrow(
+    "contains requires an object"
+  );
+});
+
+test("contains throws an error for a string", () => {
+  expect(() => contains("Manchester", "name")).toThrow(
+    "contains requires an object"
+  );
+});


Your current function implementation is good, but our tests (in practice) should not only verify our current implementation, but also ensure that future changes do not alter the function's expected behavior.

Arrays are objects, with their indices acting as keys.

Object.hasOwn([1, 2, 3], 'name') // evaluates to false Object.hasOwn([1, 2, 3], '0') // evaluates to true

A proper test should use a valid key to guarantee the function returns false specifically because the first argument is an array, not because the key is missing.

The same also apply to string.

Thank you for the feedback!

I have refactored my code.

cjyuan · 2026-11-08T16:19:44Z

+// Edge cases
+test("should not crash on malformed percent-encoding", () => {
+  expect(parseQueryString("a=%E0%A4%A")).toEqual({ a: "%E0%A4%A" });
+});


Nice edge case consideration.

Thank you for the feedback!

cjyuan · 2026-11-08T16:27:14Z

+  const counts = {};
+
+  for (const item of items) {
+    if (counts[item] === undefined) {
+      counts[item] = 1;
+    } else {
+      counts[item] += 1;
+    }
+  }


When using a regular object as a dictionary or map, we should consider whether a key might match the name of an inherited property.

For example, does the following function call returns the value you expect?

tally(["toString", "toString"]);

Suggestion:

Look up an approach to create an empty object with no inherited properties, or

use Object.hasOwn(), or

use a Map object

Thank you for the feedback!

I have refactored my code.

cjyuan · 2026-11-08T16:30:34Z

 // a) What is the current return value when invert is called with { a : 1 }
+// Current return value is 1.

 // b) What is the current return value when invert is called with { a: 1, b: 2 }
+// The current return value is 2.


I think the question is asking what the original function returns when the parameter is the specified object.
Does the function return a number or an object?

…s in tally function

cjyuan

Changes look good. Excellent work.

moses77-boop added 30 commits November 5, 2026 19:45

Fix console log to correctly display house number from address object

b88166f

Remove commented-out code and explanations from address.js

7158a9b

Add explanation for for...of loop issue in author.js

16a2b1a

Fix for...of loop to correctly iterate over author object properties

b124b4d

Remove unnecessary comments and explanations from author.js

fa4aee7

refactor console log to correctly display ingredients list in recipe.js

ee40cba

Remove unnecessary comments from recipe.js

f4617bf

Implement test for contains function on empty object

106c55f

Implement contains function to return false

9f62098

Add test for contains function with existing property

51be35c

Implement contains function to check for property existence in object

f2a26fc

Add tests for contains function with non-existent property and error …

96cdc69

…handling

Add test for contains function to throw error for string input

990790e

Add test for contains function to throw error for number input

8ea5fab

Add test for contains function to throw error for null input

e586a0b

Add test for contains function to throw error when no argument is given

9b77ec8

Remove unnecessary comments from contains test file

3ede084

Add validation to contains function to ensure input is an object

26939b1

Implement test for country-currency pairs

c6044d5

Implement createLookup function to map country codes to currency codes

8c357a8

Refactor createLookup function to use an object instead of an array f…

df599c5

…or lookup

Remove unnecessary comments from lookup test file

6440839

Implement test for tally function on an empty array

dc9fbcd

Implement return statement in tally function

cbe89f1

Add test for tally function to count duplicate items

0df2538

Add test for tally function to verify counts for unique items

c08d7ad

Implement tally function to count occurrences of items in an array

f82e064

Add test for tally function to handle invalid input

b6f88e8

Add input validation to tally function to ensure an array is provided

b8fe136

Remove unnecessary comments from tally test file for clarity

625a080

moses77-boop added 15 commits November 5, 2026 22:54

Enhance parseQueryString to decode keys and values for improved query…

53bcc81

… parameter handling

Refactor parseQueryString to support multiple values for the same key

40770d8

add edge case test for malformed percent-encoding

89aa7c8

Refactor decode function to handle errors and replace plus signs with…

55bcc8e

… spaces

Update comment to clarify current return value for invert function

01bf866

Update comment to clarify current return value for invert function wi…

3e4344a

…th multiple key-value pairs

Update comment to clarify target return value for invert function wit…

b3d7030

…h multiple key-value pairs

Update comments to clarify the purpose of Object.entries in the inver…

4ebef47

…t function

Update comments to clarify the reason for the current return value in…

cffb378

… the invert function

Fix invert function to correctly swap keys and values; add initial te…

f6adbf3

…st file

Add invert function and initial test case for key-value swapping

c5db3de

Add test case for multiple key-value pairs in invert function

f0daded

Update test case for multiple key-value pairs in invert function

a45c5ea

Add test case for returning an empty object in invert function

41a07a1

Remove unnecessary comments

1d46b22

moses77-boop added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Nov 6, 2026

cjyuan reviewed Nov 8, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 8, 2026

moses77-boop added 4 commits November 8, 2026 21:04

Update error message tests in contains function for consistency

69b6210

Add test case for handling items named like built-in object propertie…

78a1f82

…s in tally function

Refactor tally function to simplify item counting logic

12a783e

Update comments in invert function to clarify return values

6373435

moses77-boop added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 8, 2026

cjyuan reviewed Nov 8, 2026

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 8, 2026

Navigation Menu

Repository navigation

Manchester | 26-ITP-Sep | Precious Moses | Sprint 2 | Data Groups - #1497

Manchester | 26-ITP-Sep | Precious Moses | Sprint 2 | Data Groups#1497
moses77-boop wants to merge 52 commits into
CodeYourFuture:mainfrom
moses77-boop:Sprint-2

moses77-boop commented Nov 6, 2026

Uh oh!

cjyuan Nov 8, 2026

Uh oh!

moses77-boop Nov 8, 2026

Uh oh!

cjyuan Nov 8, 2026

Uh oh!

moses77-boop Nov 8, 2026

Uh oh!

cjyuan Nov 8, 2026

Uh oh!

moses77-boop Nov 8, 2026

Uh oh!

cjyuan Nov 8, 2026

Uh oh!

cjyuan left a comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

moses77-boop commented Nov 6, 2026

Task code

Changelist

Uh oh!

cjyuan Nov 8, 2026

Choose a reason for hiding this comment

Uh oh!

moses77-boop Nov 8, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 8, 2026

Choose a reason for hiding this comment

Uh oh!

moses77-boop Nov 8, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 8, 2026

Choose a reason for hiding this comment

Uh oh!

moses77-boop Nov 8, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 8, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants