Skip to content

Commit 3d0b447

Browse files
authored
Merge branch 'CodeYourFuture:main' into implement-shell-tools-in-python
2 parents 595e41e + bb71b06 commit 3d0b447

6 files changed

Lines changed: 13 additions & 4 deletions

File tree

‎.github/workflows/validate-pr-metadata.yml‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Validate PR Metadata and Check SDC-Tools Tasks
22
on:
3-
pull_request:
3+
pull_request_target:
44
types:
55
- labeled
66
- opened
@@ -24,7 +24,10 @@ jobs:
2424
if: ${{ github.event.label.name == 'Needs Review' }}
2525
steps:
2626
- name: checkout base branch
27-
uses: actions/checkout@v5
27+
uses: actions/checkout@v7
28+
with:
29+
allow-unsafe-pr-checkout: true
30+
ref: ${{ github.event.pull_request.head.sha }}
2831
- name: Get changed files
2932
id: changed-files
3033
uses: tj-actions/changed-files@v47.0.5

‎expect/individual-shell-tools/sed/script-04.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ This is a sample file for experimenting with sed.
22

33
It contains many lines, and there are some things you may want to do with each of them.
44

5-
We'll include some score information:
5+
We will include some score information:
66
37 Alisha
77
15 Jacob
88
7 Pietro

‎expect/jq/script-03.sh‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
Selma, Software Engineer
2-
Selma, Software Engineer

‎implement-shell-tools/ls/README.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ Your task is to implement your own version of `ls`.
66

77
It must act the same as `ls` would, if run from the directory containing this README.md file, for the following command lines:
88

9+
* `ls sample-files`
10+
* `ls sample-files/1.txt`
11+
* `ls sample-files/*`
912
* `ls -1`
1013
* `ls -1 sample-files`
1114
* `ls -1 -a sample-files`

‎implement-shell-tools/wc/README.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ It must act the same as `wc` would, if run from the directory containing this RE
1111
* `wc -w sample-files/3.txt`
1212
* `wc -c sample-files/3.txt`
1313
* `wc -l sample-files/*`
14+
* `wc -w -l sample-files/3.txt`
15+
* `wc -w -l sample-files/*`
1416

1517
Matching any additional behaviours or flags are optional stretch goals.
1618

‎test-sdc.sh‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,3 +180,5 @@ elif [[ "$1" == "implement-cowsay" ]]; then
180180
else
181181
echo "Please run this with a valid test directory name as argument"
182182
fi
183+
184+
echo "If you want to re-run the automated tests after changing some code, remove the 'Needs Review' label, wait a little, and then re-add the 'Needs Review' label on your PR." >> testoutput.txt

0 commit comments

Comments
 (0)