Keep tappables inside a tappable reachable to screen readers

A tappable node wrapped itself in MergeSemantics, which folded every
tappable inside it (pins on a floor plan, buttons on a card) into one
button, so they couldn't be reached or activated by assistive tech, and
a semantics click on any of them ran the outer node's action. A node
with tappable descendants now leaves its own tap out of the semantics
tree and lets the inner ones keep their nodes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012anUJ6o6K6kjUXur8Ak8XX

Author: claude

lib/src/transformers/widget_node_transformer_manager.dart

@@ -192,6 +192,12 @@ abstract class WidgetNodeTransformerManager
 
     collect(node);
 
+    // A tappable inside a tappable (a pin on a plan, a button on a card)
+    // would be merged into the outer button and become unreachable. The
+    // outer one then stays out of the semantics tree (see
+    // [hasTappableDescendant]) so the inner ones keep their own nodes.
+    if (descendants.any(_isTappable)) return widget;
+
     final bool hasText = descendants.any((child) => child is TextNode);
     final String label = hasText ? '' : semanticLabelFor(node, descendants);
     return MergeSemantics(
@@ -203,6 +209,29 @@ abstract class WidgetNodeTransformerManager
     );
   }
 
+  static bool _isTappable(BaseNode node) =>
+      node is ReactionMixin &&
+      (node as ReactionMixin).reactions.any(
+        (reaction) =>
+            reaction.trigger.type == TriggerType.click &&
+            reaction.action.enabled,
+      );
+
+  /// Whether a node inside [node] reacts to clicks itself. [node]'s own
+  /// tap then leaves the semantics tree to its descendants.
+  bool hasTappableDescendant(BaseNode node) {
+    bool visit(BaseNode parent) {
+      for (final String id in parent.childrenOrEmpty) {
+        final BaseNode? child = _tryGetNode(id);
+        if (child == null) continue;
+        if (_isTappable(child) || visit(child)) return true;
+      }
+      return false;
+    }
+
+    return visit(node);
+  }
+
   /// The name a screen reader announces for [node] when it has no text.
   static String semanticLabelFor(BaseNode node, List<BaseNode> descendants) {
     final String name = node.name.trim();
@@ -287,6 +316,7 @@ abstract class WidgetNodeTransformerManager
         type: MaterialType.transparency,
         child: Builder(
           builder: (tapContext) => InkWell(
+            excludeFromSemantics: hasTappableDescendant(node),
             onTapUp: (details) => recordTap(tapContext, details),
             onTap: click,
             onLongPress: onLongPressReactions.isEmpty
@@ -321,6 +351,7 @@ abstract class WidgetNodeTransformerManager
         child: Builder(
           builder: (tapContext) => GestureDetector(
             behavior: HitTestBehavior.opaque,
+            excludeFromSemantics: hasTappableDescendant(node),
             onTapUp: onClickReactions.isEmpty
                 ? null
                 : (details) => recordTap(tapContext, details),

test/semantics_test.dart

@@ -75,4 +75,56 @@ void main() {
       'Add to bag',
     );
   });
+
+  testWidgets('tappables inside a tappable keep their own buttons', (
+    tester,
+  ) async {
+    final SemanticsHandle handle = tester.ensureSemantics();
+    final FrameNode plan = FrameNode.fromJson({
+      ...FrameNode(
+        id: 'plan',
+        name: 'Plan',
+        basicBoxLocal: NodeBox(0, 0, 200, 100),
+        children: ['p1', 'p2'],
+      ).toJson(),
+      'reactions': [
+        Reaction(
+          action: LinkAction(url: ''),
+          trigger: TriggerModel(type: TriggerType.click),
+        ).toJson(),
+      ],
+    })..parentID = kRootNode;
+    final RectangleNode p1 = tappable('p1', 'Pin one')..parentID = 'plan';
+    final RectangleNode p2 = tappable('p2', 'Pin two')..parentID = 'plan';
+    final registry = NodeRegistry()
+      ..setNodes({for (final n in [plan, p1, p2]) n.id: n});
+    final manager = PassiveNodeTransformerManager(
+      registry.getNodeByID,
+      (context, bounds, pageID, layoutID, canvasID) => const SizedBox(),
+    );
+    await tester.pumpWidget(
+      ChangeNotifierProvider<CodelesslyContext>.value(
+        value: CodelesslyContext.empty(),
+        child: MaterialApp(
+          home: Align(
+            alignment: Alignment.topLeft,
+            child: Builder(
+              builder: (context) => manager.buildWidgetFromNode(
+                plan,
+                context,
+                settings: const WidgetBuildSettings(debugLabel: 'test'),
+              ),
+            ),
+          ),
+        ),
+      ),
+    );
+    for (final String name in ['Pin one', 'Pin two']) {
+      expect(
+        tester.getSemantics(find.bySemanticsLabel(name)),
+        matchesSemantics(label: name, isButton: true, hasTapAction: true),
+      );
+    }
+    handle.dispose();
+  });
 }