Merge main comment cleanup and format NAE-SAT reduction test

Author: GiggleLiu

docs/paper/reductions.typ

@@ -2228,7 +2228,7 @@ In all graph problems below, $G = (V, E)$ denotes an undirected graph with $|V|
           import draw: *
           let blue = graph-colors.at(0)
           let gray = luma(185)
-          // Layout for issue #813: path 0–1–3–2–4–5 with clear bends so $v_0,v_1,v_3$ are not collinear
+          // Bend the path so $v_0,v_1,v_3$ are not collinear.
           // (otherwise $(0,3)$ lies on the same geometric line as $0 arrow.r 1 arrow.r 3$).
           let verts = (
             (0, 0),
@@ -17156,7 +17156,7 @@ The following table shows concrete target-variable counts for example instances,
   _Solution extraction._ First $n$ variables (sign variables) give the source configuration.
 ]
 
-// === Non-ILP reduction rules (issue #974) ===
+// === Non-ILP reduction rules ===
 
 #reduction-rule("ILP", "ILP")[
   ILP variants convert between binary and bounded integer variable domains and between exact-integer and floating-point coefficients. The independent bounds dimension defaults to general; the bounded integer variant requires finite lower and upper endpoints for every variable. Binary variables embed into bounded integer ILP, which embeds into general integer ILP while retaining all stored bounds. A bounded integer variable is encoded by binary variables with truncated positional weights. Integer coefficients are embedded only when every stored coefficient and right-hand side has an exact `f64` representation.

problemreductions-cli/src/bin/pred_sym.rs

@@ -122,7 +122,6 @@ fn main() {
                 })
                 .collect();
 
-            // Check for unbound variables
             let expr_vars = parsed.variables();
             let bound_vars: std::collections::HashSet<&str> =
                 bindings.iter().map(|(name, _)| name.as_str()).collect();

problemreductions-cli/src/commands/create.rs

@@ -353,9 +353,7 @@ pub fn create(args: &CreateArgs, out: &OutputConfig) -> Result<()> {
         return create_registered_random(args, canonical, &resolved_variant, out);
     }
 
-    // ILP and CircuitSAT have complex input structures
-    // not suited for CLI flags. Check before the empty-flags help so they get a
-    // clear message.
+    // ILP and CircuitSAT have complex input structures not suited for CLI flags.
     if canonical == "ILP" || canonical == "CircuitSAT" {
         bail!(
             "CLI creation is not yet supported for {canonical}.\n\n\

problemreductions-cli/src/commands/create/tests.rs

@@ -778,7 +778,6 @@ fn test_create_staff_scheduling_reports_invalid_schedule_without_panic() {
     let result = std::panic::catch_unwind(|| create(&args, &out));
     assert!(result.is_ok(), "create should return an error, not panic");
     let err = result.unwrap().unwrap_err().to_string();
-    // parse_bool_rows catches ragged rows before validate_staff_scheduling_args
     assert!(
         err.contains("All rows") || err.contains("schedule 1 has 6 periods, expected 7"),
         "expected row-length validation error, got: {err}"

problemreductions-cli/src/commands/graph.rs

@@ -1259,7 +1259,6 @@ pub fn neighbors(
         TraversalFlow::Both => "both directions",
     };
 
-    // Build tree structure via BFS with parent tracking
     let tree = graph.k_neighbor_tree(&spec_name, &variant, max_hops, direction);
 
     out.emit(

problemreductions-cli/src/commands/inspect.rs

@@ -11,7 +11,6 @@ pub fn inspect(input: &Path, out: &OutputConfig) -> Result<()> {
     let content = read_input(input)?;
     let json: serde_json::Value = serde_json::from_str(&content)?;
 
-    // Detect if it's a bundle or a problem
     if json.get("source").is_some() && json.get("target").is_some() && json.get("path").is_some() {
         let bundle: ReductionBundle = serde_json::from_value(json)?;
         inspect_bundle(&bundle, out)

problemreductions-cli/src/mcp/tests.rs

@@ -473,7 +473,6 @@ fn deterministic_solver_dispatch_mcp_output_is_repeatable_for_each_solver_class(
 fn test_solve_bundle() {
     let server = McpServer::new();
     let problem_json = create_test_mis(&server);
-    // Reduce first, then solve the bundle
     let bundle_json = server
         .reduce_inner(
             &problem_json,

problemreductions-cli/src/mcp/tools.rs

@@ -314,7 +314,6 @@ impl McpServer {
                 )
             })?;
 
-        // Check for random generation
         let is_random = params
             .get("random")
             .and_then(|v| v.as_bool())
@@ -363,7 +362,6 @@ impl McpServer {
     pub fn inspect_problem_inner(&self, problem_json: &str) -> anyhow::Result<String> {
         let json: serde_json::Value = serde_json::from_str(problem_json)?;
 
-        // Detect if it's a bundle or a problem
         if json.get("source").is_some()
             && json.get("target").is_some()
             && json.get("path").is_some()
@@ -442,7 +440,6 @@ impl McpServer {
         let timeout_secs = u64::try_from(timeout.unwrap_or(0))
             .map_err(|_| anyhow::anyhow!("timeout must be a nonnegative i64"))?;
 
-        // Detect if it's a bundle or a problem
         let is_bundle = json.get("source").is_some()
             && json.get("target").is_some()
             && json.get("path").is_some();

problemreductions-cli/src/output.rs

@@ -115,7 +115,6 @@ pub fn format_table(
     rows: &[Vec<String>],
     color_fns: &[Option<CellFormatter>],
 ) -> String {
-    // Compute actual column widths (max of header width, specified width, and data width)
     let widths: Vec<usize> = columns
         .iter()
         .enumerate()
@@ -127,7 +126,6 @@ pub fn format_table(
 
     let mut text = String::new();
 
-    // Header
     text.push_str("  ");
     for (i, (header, align, _)) in columns.iter().enumerate() {
         if i > 0 {
@@ -140,7 +138,6 @@ pub fn format_table(
     }
     text.push('\n');
 
-    // Separator
     text.push_str("  ");
     for (i, _) in columns.iter().enumerate() {
         if i > 0 {
@@ -150,7 +147,6 @@ pub fn format_table(
     }
     text.push('\n');
 
-    // Data rows
     for row in rows {
         text.push_str("  ");
         for (i, (_, align, _)) in columns.iter().enumerate() {

problemreductions-macros/src/lib.rs

@@ -206,15 +206,6 @@ fn option_inner_type(ty: &Type) -> Option<&Type> {
 /// - `transform = { exact { ... }, upper_bound { ... }, unavailable { ... } }` — per-field relations
 /// - `transform = unavailable { field = "reason", ... }` — no symbolic parameter transform
 /// - `unavailable = { field = "reason", ... }` — fields that cannot be propagated
-///
-/// ## Syntax
-/// ```ignore
-/// #[reduction(transform = exact {
-///     num_vars = "num_vertices^2",
-///     num_constraints = num_edges,
-/// })]
-/// ```
-///
 #[proc_macro_attribute]
 pub fn reduction(attr: TokenStream, item: TokenStream) -> TokenStream {
     let attrs = parse_macro_input!(attr as ReductionAttrs);
@@ -598,28 +589,22 @@ fn generate_reduction_entry(
     attrs: &ReductionAttrs,
     impl_block: &ItemImpl,
 ) -> syn::Result<TokenStream2> {
-    // Extract the trait path (should be ReduceTo<Target>)
     let trait_path = impl_block
         .trait_
         .as_ref()
         .map(|(path, _)| path)
         .ok_or_else(|| syn::Error::new_spanned(impl_block, "Expected impl ReduceTo<T> for S"))?;
 
-    // Extract target type from ReduceTo<Target>
     let target_type = extract_target_from_trait(trait_path)?;
 
-    // Extract source type (Self type)
     let source_type = &impl_block.self_ty;
 
-    // Get type names
     let source_name = extract_type_name(source_type)
         .ok_or_else(|| syn::Error::new_spanned(source_type, "Cannot extract source type name"))?;
     let target_name = extract_type_name(&target_type)
         .ok_or_else(|| syn::Error::new_spanned(&target_type, "Cannot extract target type name"))?;
-    // Collect generic parameter info from the impl block
     let type_generics = collect_type_generic_names(&impl_block.generics);
 
-    // Generate variant fn bodies
     let source_variant_body = make_variant_fn_body(source_type, &type_generics)?;
     let target_variant_body = make_variant_fn_body(&target_type, &type_generics)?;
 
@@ -652,7 +637,6 @@ fn generate_reduction_entry(
         .iter()
         .map(|(field, reason)| quote! { crate::rules::registry::UnavailableParameterField { field: #field, reason: #reason } });
 
-    // Generate the combined output
     let output = quote! {
         #impl_block
 
@@ -926,8 +910,6 @@ pub fn register_brute_force(input: TokenStream) -> TokenStream {
 
 /// Generate code for all `declare_variants!` entries.
 fn generate_declare_variants(input: &DeclareVariantsInput) -> syn::Result<TokenStream2> {
-    // Validate default markers per problem name.
-    // Group entries by their base type name (e.g., "MaximumIndependentSet").
     let mut defaults_per_problem: HashMap<String, Vec<usize>> = HashMap::new();
     let mut problem_names = HashSet::new();
     for (i, entry) in input.entries.iter().enumerate() {
@@ -938,7 +920,6 @@ fn generate_declare_variants(input: &DeclareVariantsInput) -> syn::Result<TokenS
         }
     }
 
-    // Check for multiple defaults for the same problem
     for (name, indices) in &defaults_per_problem {
         if indices.len() > 1 {
             return Err(syn::Error::new(
@@ -973,15 +954,13 @@ fn generate_declare_variants(input: &DeclareVariantsInput) -> syn::Result<TokenS
         let is_default = entry.is_default;
         let alias_lits: Vec<_> = entry.aliases.iter().map(|s| s.value()).collect();
 
-        // Parse the complexity expression to validate syntax
         let parsed = problemreductions_expr::Expr::try_parse(&complexity_str).map_err(|e| {
             syn::Error::new(
                 entry.complexity.span(),
                 format!("invalid complexity expression \"{complexity_str}\": {e}"),
             )
         })?;
 
-        // Generate a compiled complexity evaluator over the problem-owned parameters.
         let complexity_eval_fn = generate_complexity_eval_fn(&parsed, ty)?;
 
         let construction_fields = if let Some(create_spec) = create_spec {