Repository navigation
Fix the open CodeQL alerts: no user path for YouTube cookies, checked preview path - #143
Merged
Merged
Conversation
… preview path Path injection (high): - YouTube cookies: Settings sends the cookies.txt's text, and the engine keeps it as youtube_cookies.txt in the data folder. The setting is now "", "firefox" or "file", never a path. The file must start with the Netscape header (yt-dlp refuses it otherwise), is capped at 1 MB, and is deleted when the setting is turned off. The Electron pick-cookies-file IPC is gone. - Preview: the overwritten preview path is checked to sit inside previews/. Stack-trace exposure: a model file's note in plugins/models.py is our own words; the error goes to the log. Notes and warnings: unused globals become module dicts, empty excepts say why, the store -> registry import is looked up by name, the SDK submodules are imported by name, and four small test-file fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 22 open code-scanning alerts on main.
Path injection (6, high)
youtube_cookies.txtin the data folder, so the setting is"","firefox"or"file"and never a path.pick-cookies-fileIPC is removed.normpath+startswith(previews/).Stack-trace exposure (3)
Notes and warnings (13)
_ipv4_only,_told_missing) are now module dicts.exceptblocks have comments saying why.Checks
tscprojects pass, and so do the cookies, preview, voice and API-contract tests.YoutubeDLCookieJar.🤖 Generated with Claude Code