[review-stack 3/4] tests-changed — synap5e/feat/asset-record-content-split - #15917
Draft
synap5e wants to merge 1 commit into
Conversation
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/2-tests-removed
branch
from
August 27, 2026 03:33
249d65a to
6c02978
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/3-tests-changed
branch
from
August 27, 2026 03:33
d9eff01 to
196911a
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/2-tests-removed
branch
from
August 27, 2026 20:10
6c02978 to
526366b
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/3-tests-changed
branch
from
August 27, 2026 20:10
196911a to
be8d90f
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/2-tests-removed
branch
from
August 28, 2026 02:30
526366b to
2946045
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/3-tests-changed
branch
from
August 28, 2026 02:30
be8d90f to
ec28834
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/2-tests-removed
branch
from
August 28, 2026 04:04
2946045 to
2a65f7e
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/3-tests-changed
branch
from
August 28, 2026 04:04
ec28834 to
91d4bf3
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/2-tests-removed
branch
from
August 29, 2026 06:47
2a65f7e to
1cc5ed4
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/3-tests-changed
branch
from
August 29, 2026 06:47
91d4bf3 to
8f5213b
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/2-tests-removed
branch
from
August 31, 2026 21:57
1cc5ed4 to
f2cd485
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/3-tests-changed
branch
from
August 31, 2026 21:57
8f5213b to
cdd6070
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/2-tests-removed
branch
from
August 31, 2026 22:34
f2cd485 to
023312c
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/3-tests-changed
branch
from
August 31, 2026 22:34
cdd6070 to
7e1369c
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/2-tests-removed
branch
from
August 31, 2026 23:00
023312c to
8b3f3e8
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/3-tests-changed
branch
from
August 31, 2026 23:00
7e1369c to
33f4763
Compare
Review-and-land stack for synap5e/feat/asset-record-content-split, generated by review-stack.py. Once approved, merges DOWN into the layer below (a fast-forward); only the bottom layer squash-merges into the real base. See ~/adocs/review-stack.md. Rule: remaining modified test files (incl. conftest.py / helpers) Question: Did the edits weaken an existing check? Source tip: f65c9e5 Merge-base: 783545f
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/2-tests-removed
branch
from
August 31, 2026 23:23
8b3f3e8 to
3945447
Compare
synap5e
force-pushed
the
synap5e/rs/asset-record-content-split/3-tests-changed
branch
from
August 31, 2026 23:23
33f4763 to
e7aa039
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer 3/4 of the review-and-land stack for
synap5e/feat/asset-record-content-split, generated byreview-stack.py. Full collapse procedure:~/adocs/review-stack.md. Once thestack starts collapsing, don't rerun
build/pushon it — a rebuild resets everylayer to its original scope from the untouched source branch and discards the collapse.
Once approved, merge this into #15916 (ordinary "Merge" — fast-forward). Once everything above has merged down into this one and it's approved, continue the collapse toward layer 1.
Rule: remaining modified test files (incl. conftest.py / helpers)
Question for this layer: Did the edits weaken an existing check?
Source tip:
f65c9e506829Stack:
code— Is the logic change right?tests-removed— For each dropped assertion: obsolete by a ruling, or covered by a tests-new test?tests-changed— Did the edits weaken an existing check?tests-new— Is the code layer well covered?Files (13, +1046/-1218):
tests-unit/assets_test/conftest.pytests-unit/assets_test/helpers.pytests-unit/assets_test/queries/conftest.pytests-unit/assets_test/queries/test_asset_reference_keyset.pytests-unit/assets_test/services/conftest.pytests-unit/assets_test/services/test_asset_response_loader_path.pytests-unit/assets_test/services/test_asset_response_preview_url.pytests-unit/assets_test/services/test_tagging.pytests-unit/assets_test/test_list_filter.pytests-unit/execution_test/test_enrich_output.pytests-unit/folder_paths_test/filter_by_content_types_test.pytests-unit/security_test/test_ghsa_779p_06_inline_svg_image_dest.pytests/execution/testing_nodes/testing-pack/specific_tests.py